-
Notifications
You must be signed in to change notification settings - Fork 319
Using stable config when a security manager is enabled should not prevent tracer startup #10006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🎯 Code Coverage 🔗 Commit SHA: acbee29 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
|
Can we have a unit test for that ? |
...s/config-utils/src/main/java/datadog/trace/bootstrap/config/provider/StableConfigSource.java
Show resolved
Hide resolved
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 6 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~acbee29b06, baseline=1.56.0~c05874d84e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.103 s) : 0, 1102916
Total [baseline] (8.879 s) : 0, 8878974
Agent [candidate] (1.101 s) : 0, 1100720
Total [candidate] (8.835 s) : 0, 8835481
section iast
Agent [baseline] (1.242 s) : 0, 1242030
Total [baseline] (9.567 s) : 0, 9567434
Agent [candidate] (1.24 s) : 0, 1240075
Total [candidate] (9.555 s) : 0, 9554717
gantt
title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~acbee29b06, baseline=1.56.0~c05874d84e
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.457 ms) : 0, 1457
crashtracking [candidate] (1.477 ms) : 0, 1477
BytebuddyAgent [baseline] (709.471 ms) : 0, 709471
BytebuddyAgent [candidate] (707.768 ms) : 0, 707768
GlobalTracer [baseline] (249.317 ms) : 0, 249317
GlobalTracer [candidate] (249.131 ms) : 0, 249131
AppSec [baseline] (32.163 ms) : 0, 32163
AppSec [candidate] (32.132 ms) : 0, 32132
Debugger [baseline] (63.0 ms) : 0, 63000
Debugger [candidate] (62.829 ms) : 0, 62829
Remote Config [baseline] (617.424 µs) : 0, 617
Remote Config [candidate] (630.137 µs) : 0, 630
Telemetry [baseline] (8.304 ms) : 0, 8304
Telemetry [candidate] (8.226 ms) : 0, 8226
Flare Poller [baseline] (3.747 ms) : 0, 3747
Flare Poller [candidate] (3.633 ms) : 0, 3633
section iast
crashtracking [baseline] (1.458 ms) : 0, 1458
crashtracking [candidate] (1.502 ms) : 0, 1502
BytebuddyAgent [baseline] (833.55 ms) : 0, 833550
BytebuddyAgent [candidate] (831.665 ms) : 0, 831665
GlobalTracer [baseline] (238.611 ms) : 0, 238611
GlobalTracer [candidate] (237.972 ms) : 0, 237972
AppSec [baseline] (33.307 ms) : 0, 33307
AppSec [candidate] (33.209 ms) : 0, 33209
Debugger [baseline] (60.161 ms) : 0, 60161
Debugger [candidate] (60.71 ms) : 0, 60710
Remote Config [baseline] (538.801 µs) : 0, 539
Remote Config [candidate] (539.127 µs) : 0, 539
Telemetry [baseline] (7.54 ms) : 0, 7540
Telemetry [candidate] (7.662 ms) : 0, 7662
Flare Poller [baseline] (3.491 ms) : 0, 3491
Flare Poller [candidate] (3.49 ms) : 0, 3490
IAST [baseline] (28.417 ms) : 0, 28417
IAST [candidate] (28.453 ms) : 0, 28453
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~acbee29b06, baseline=1.56.0~c05874d84e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.113 s) : 0, 1112894
Total [baseline] (10.811 s) : 0, 10811430
Agent [candidate] (1.11 s) : 0, 1109669
Total [candidate] (10.957 s) : 0, 10956808
section appsec
Agent [baseline] (1.296 s) : 0, 1296367
Total [baseline] (11.263 s) : 0, 11262579
Agent [candidate] (1.284 s) : 0, 1283789
Total [candidate] (11.278 s) : 0, 11278130
section iast
Agent [baseline] (1.243 s) : 0, 1242835
Total [baseline] (11.311 s) : 0, 11311028
Agent [candidate] (1.242 s) : 0, 1242204
Total [candidate] (11.343 s) : 0, 11342659
section profiling
Agent [baseline] (1.239 s) : 0, 1238571
Total [baseline] (11.322 s) : 0, 11322492
Agent [candidate] (1.236 s) : 0, 1235670
Total [candidate] (11.135 s) : 0, 11134655
gantt
title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~acbee29b06, baseline=1.56.0~c05874d84e
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.478 ms) : 0, 1478
crashtracking [candidate] (1.497 ms) : 0, 1497
BytebuddyAgent [baseline] (714.642 ms) : 0, 714642
BytebuddyAgent [candidate] (713.116 ms) : 0, 713116
GlobalTracer [baseline] (251.433 ms) : 0, 251433
GlobalTracer [candidate] (250.903 ms) : 0, 250903
AppSec [baseline] (32.393 ms) : 0, 32393
AppSec [candidate] (32.205 ms) : 0, 32205
Debugger [baseline] (65.143 ms) : 0, 65143
Debugger [candidate] (64.353 ms) : 0, 64353
Remote Config [baseline] (629.317 µs) : 0, 629
Remote Config [candidate] (628.923 µs) : 0, 629
Telemetry [baseline] (8.353 ms) : 0, 8353
Telemetry [candidate] (8.305 ms) : 0, 8305
Flare Poller [baseline] (3.792 ms) : 0, 3792
Flare Poller [candidate] (3.75 ms) : 0, 3750
section appsec
crashtracking [baseline] (1.474 ms) : 0, 1474
crashtracking [candidate] (1.488 ms) : 0, 1488
BytebuddyAgent [baseline] (743.127 ms) : 0, 743127
BytebuddyAgent [candidate] (733.208 ms) : 0, 733208
GlobalTracer [baseline] (242.49 ms) : 0, 242490
GlobalTracer [candidate] (241.352 ms) : 0, 241352
AppSec [baseline] (174.203 ms) : 0, 174203
AppSec [candidate] (173.792 ms) : 0, 173792
Debugger [baseline] (62.006 ms) : 0, 62006
Debugger [candidate] (61.568 ms) : 0, 61568
Remote Config [baseline] (693.478 µs) : 0, 693
Remote Config [candidate] (660.968 µs) : 0, 661
Telemetry [baseline] (8.26 ms) : 0, 8260
Telemetry [candidate] (8.152 ms) : 0, 8152
Flare Poller [baseline] (3.908 ms) : 0, 3908
Flare Poller [candidate] (3.891 ms) : 0, 3891
IAST [baseline] (24.884 ms) : 0, 24884
IAST [candidate] (24.767 ms) : 0, 24767
section iast
crashtracking [baseline] (1.449 ms) : 0, 1449
crashtracking [candidate] (1.487 ms) : 0, 1487
BytebuddyAgent [baseline] (834.425 ms) : 0, 834425
BytebuddyAgent [candidate] (833.057 ms) : 0, 833057
GlobalTracer [baseline] (238.491 ms) : 0, 238491
GlobalTracer [candidate] (238.71 ms) : 0, 238710
AppSec [baseline] (33.713 ms) : 0, 33713
AppSec [candidate] (34.069 ms) : 0, 34069
Debugger [baseline] (60.762 ms) : 0, 60762
Debugger [candidate] (60.934 ms) : 0, 60934
Remote Config [baseline] (539.042 µs) : 0, 539
Remote Config [candidate] (534.724 µs) : 0, 535
Telemetry [baseline] (7.581 ms) : 0, 7581
Telemetry [candidate] (7.588 ms) : 0, 7588
Flare Poller [baseline] (3.489 ms) : 0, 3489
Flare Poller [candidate] (3.535 ms) : 0, 3535
IAST [baseline] (27.42 ms) : 0, 27420
IAST [candidate] (27.5 ms) : 0, 27500
section profiling
ProfilingAgent [baseline] (97.894 ms) : 0, 97894
ProfilingAgent [candidate] (97.08 ms) : 0, 97080
crashtracking [baseline] (1.438 ms) : 0, 1438
crashtracking [candidate] (1.425 ms) : 0, 1425
BytebuddyAgent [baseline] (737.101 ms) : 0, 737101
BytebuddyAgent [candidate] (736.695 ms) : 0, 736695
GlobalTracer [baseline] (223.721 ms) : 0, 223721
GlobalTracer [candidate] (223.065 ms) : 0, 223065
AppSec [baseline] (32.352 ms) : 0, 32352
AppSec [candidate] (32.343 ms) : 0, 32343
Debugger [baseline] (63.633 ms) : 0, 63633
Debugger [candidate] (63.451 ms) : 0, 63451
Remote Config [baseline] (661.199 µs) : 0, 661
Remote Config [candidate] (645.136 µs) : 0, 645
Telemetry [baseline] (8.175 ms) : 0, 8175
Telemetry [candidate] (8.008 ms) : 0, 8008
Flare Poller [baseline] (3.776 ms) : 0, 3776
Flare Poller [candidate] (3.79 ms) : 0, 3790
Profiling [baseline] (98.486 ms) : 0, 98486
Profiling [candidate] (97.685 ms) : 0, 97685
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 18 metrics, 17 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~acbee29b06, baseline=1.56.0~c05874d84e
dateFormat X
axisFormat %s
section baseline
no_agent (1.214 ms) : 1202, 1226
. : milestone, 1214,
iast (3.334 ms) : 3285, 3383
. : milestone, 3334,
iast_FULL (5.932 ms) : 5874, 5991
. : milestone, 5932,
iast_GLOBAL (3.741 ms) : 3673, 3809
. : milestone, 3741,
profiling (2.159 ms) : 2140, 2178
. : milestone, 2159,
tracing (1.812 ms) : 1798, 1827
. : milestone, 1812,
section candidate
no_agent (1.183 ms) : 1172, 1194
. : milestone, 1183,
iast (3.269 ms) : 3227, 3312
. : milestone, 3269,
iast_FULL (5.924 ms) : 5863, 5984
. : milestone, 5924,
iast_GLOBAL (3.82 ms) : 3759, 3881
. : milestone, 3820,
profiling (2.212 ms) : 2191, 2232
. : milestone, 2212,
tracing (1.861 ms) : 1846, 1877
. : milestone, 1861,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~acbee29b06, baseline=1.56.0~c05874d84e
dateFormat X
axisFormat %s
section baseline
no_agent (17.106 ms) : 16937, 17274
. : milestone, 17106,
appsec (19.345 ms) : 19146, 19544
. : milestone, 19345,
code_origins (17.549 ms) : 17377, 17720
. : milestone, 17549,
iast (17.689 ms) : 17513, 17866
. : milestone, 17689,
profiling (18.507 ms) : 18322, 18693
. : milestone, 18507,
tracing (17.823 ms) : 17646, 17999
. : milestone, 17823,
section candidate
no_agent (17.951 ms) : 17767, 18136
. : milestone, 17951,
appsec (18.787 ms) : 18595, 18979
. : milestone, 18787,
code_origins (17.838 ms) : 17663, 18013
. : milestone, 17838,
iast (17.748 ms) : 17573, 17922
. : milestone, 17748,
profiling (18.8 ms) : 18612, 18987
. : milestone, 18800,
tracing (17.757 ms) : 17580, 17934
. : milestone, 17757,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~acbee29b06, baseline=1.56.0~c05874d84e
dateFormat X
axisFormat %s
section baseline
no_agent (1.472 ms) : 1461, 1484
. : milestone, 1472,
appsec (3.635 ms) : 3421, 3850
. : milestone, 3635,
iast (2.207 ms) : 2142, 2271
. : milestone, 2207,
iast_GLOBAL (2.264 ms) : 2199, 2329
. : milestone, 2264,
profiling (2.075 ms) : 2023, 2128
. : milestone, 2075,
tracing (2.048 ms) : 1997, 2099
. : milestone, 2048,
section candidate
no_agent (1.48 ms) : 1468, 1491
. : milestone, 1480,
appsec (3.699 ms) : 3482, 3916
. : milestone, 3699,
iast (2.211 ms) : 2147, 2276
. : milestone, 2211,
iast_GLOBAL (2.247 ms) : 2182, 2311
. : milestone, 2247,
profiling (2.076 ms) : 2024, 2129
. : milestone, 2076,
tracing (2.051 ms) : 2000, 2102
. : milestone, 2051,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~acbee29b06, baseline=1.56.0~c05874d84e
dateFormat X
axisFormat %s
section baseline
no_agent (14.943 s) : 14943000, 14943000
. : milestone, 14943000,
appsec (15.042 s) : 15042000, 15042000
. : milestone, 15042000,
iast (18.07 s) : 18070000, 18070000
. : milestone, 18070000,
iast_GLOBAL (17.938 s) : 17938000, 17938000
. : milestone, 17938000,
profiling (15.381 s) : 15381000, 15381000
. : milestone, 15381000,
tracing (14.627 s) : 14627000, 14627000
. : milestone, 14627000,
section candidate
no_agent (14.789 s) : 14789000, 14789000
. : milestone, 14789000,
appsec (15.164 s) : 15164000, 15164000
. : milestone, 15164000,
iast (18.251 s) : 18251000, 18251000
. : milestone, 18251000,
iast_GLOBAL (17.828 s) : 17828000, 17828000
. : milestone, 17828000,
profiling (14.983 s) : 14983000, 14983000
. : milestone, 14983000,
tracing (14.707 s) : 14707000, 14707000
. : milestone, 14707000,
|
What Does This Do
It avoid prematurely exiting on the premain when a security manager is enabled.
Prevents:
Motivation
Avoid exiting the agent premain too early because the config throws an unexpected SecurityException
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]