-
Notifications
You must be signed in to change notification settings - Fork 319
Fix Java version requirements for OpenFeature tests #10003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
leoromanovsky
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR; approving as I assume you are confident in this but could you please link to a failing test or the motivation behind this so we can learn from it?
|
This PR comes from @AlexeyKuznetsov-DD message that master build broke. |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 6 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.56.0-SNAPSHOT~f9602ef1e5, baseline=1.56.0-SNAPSHOT~4842f7f4c3
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.108 s) : 0, 1107888
Total [baseline] (10.776 s) : 0, 10775830
Agent [candidate] (1.11 s) : 0, 1109679
Total [candidate] (10.828 s) : 0, 10828292
section appsec
Agent [baseline] (1.289 s) : 0, 1289335
Total [baseline] (11.202 s) : 0, 11201858
Agent [candidate] (1.292 s) : 0, 1291636
Total [candidate] (11.273 s) : 0, 11273270
section iast
Agent [baseline] (1.242 s) : 0, 1242343
Total [baseline] (11.395 s) : 0, 11395176
Agent [candidate] (1.24 s) : 0, 1239823
Total [candidate] (11.25 s) : 0, 11249569
section profiling
Agent [baseline] (1.237 s) : 0, 1237371
Total [baseline] (11.1 s) : 0, 11100224
Agent [candidate] (1.242 s) : 0, 1241602
Total [candidate] (11.075 s) : 0, 11075348
gantt
title petclinic - break down per module: candidate=1.56.0-SNAPSHOT~f9602ef1e5, baseline=1.56.0-SNAPSHOT~4842f7f4c3
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.464 ms) : 0, 1464
crashtracking [candidate] (1.457 ms) : 0, 1457
BytebuddyAgent [baseline] (711.537 ms) : 0, 711537
BytebuddyAgent [candidate] (712.885 ms) : 0, 712885
GlobalTracer [baseline] (250.597 ms) : 0, 250597
GlobalTracer [candidate] (250.637 ms) : 0, 250637
AppSec [baseline] (32.222 ms) : 0, 32222
AppSec [candidate] (32.24 ms) : 0, 32240
Debugger [baseline] (64.149 ms) : 0, 64149
Debugger [candidate] (64.563 ms) : 0, 64563
Remote Config [baseline] (629.732 µs) : 0, 630
Remote Config [candidate] (630.33 µs) : 0, 630
Telemetry [baseline] (8.361 ms) : 0, 8361
Telemetry [candidate] (8.33 ms) : 0, 8330
Flare Poller [baseline] (3.84 ms) : 0, 3840
Flare Poller [candidate] (3.724 ms) : 0, 3724
section appsec
crashtracking [baseline] (1.463 ms) : 0, 1463
crashtracking [candidate] (1.465 ms) : 0, 1465
BytebuddyAgent [baseline] (735.744 ms) : 0, 735744
BytebuddyAgent [candidate] (738.132 ms) : 0, 738132
GlobalTracer [baseline] (242.209 ms) : 0, 242209
GlobalTracer [candidate] (242.383 ms) : 0, 242383
AppSec [baseline] (175.183 ms) : 0, 175183
AppSec [candidate] (174.771 ms) : 0, 174771
Debugger [baseline] (61.354 ms) : 0, 61354
Debugger [candidate] (61.936 ms) : 0, 61936
Remote Config [baseline] (680.667 µs) : 0, 681
Remote Config [candidate] (671.703 µs) : 0, 672
Telemetry [baseline] (8.315 ms) : 0, 8315
Telemetry [candidate] (8.212 ms) : 0, 8212
Flare Poller [baseline] (3.944 ms) : 0, 3944
Flare Poller [candidate] (3.938 ms) : 0, 3938
IAST [baseline] (25.124 ms) : 0, 25124
IAST [candidate] (24.954 ms) : 0, 24954
section iast
crashtracking [baseline] (1.452 ms) : 0, 1452
crashtracking [candidate] (1.447 ms) : 0, 1447
BytebuddyAgent [baseline] (832.921 ms) : 0, 832921
BytebuddyAgent [candidate] (831.448 ms) : 0, 831448
GlobalTracer [baseline] (238.31 ms) : 0, 238310
GlobalTracer [candidate] (238.002 ms) : 0, 238002
AppSec [baseline] (34.097 ms) : 0, 34097
AppSec [candidate] (34.996 ms) : 0, 34996
Debugger [baseline] (61.328 ms) : 0, 61328
Debugger [candidate] (60.658 ms) : 0, 60658
Remote Config [baseline] (537.364 µs) : 0, 537
Remote Config [candidate] (531.166 µs) : 0, 531
Telemetry [baseline] (7.674 ms) : 0, 7674
Telemetry [candidate] (7.589 ms) : 0, 7589
Flare Poller [baseline] (3.521 ms) : 0, 3521
Flare Poller [candidate] (3.483 ms) : 0, 3483
IAST [baseline] (27.37 ms) : 0, 27370
IAST [candidate] (26.644 ms) : 0, 26644
section profiling
crashtracking [baseline] (1.451 ms) : 0, 1451
crashtracking [candidate] (1.444 ms) : 0, 1444
BytebuddyAgent [baseline] (737.548 ms) : 0, 737548
BytebuddyAgent [candidate] (739.92 ms) : 0, 739920
GlobalTracer [baseline] (223.216 ms) : 0, 223216
GlobalTracer [candidate] (224.376 ms) : 0, 224376
AppSec [baseline] (32.173 ms) : 0, 32173
AppSec [candidate] (32.558 ms) : 0, 32558
Debugger [baseline] (63.494 ms) : 0, 63494
Debugger [candidate] (63.807 ms) : 0, 63807
Remote Config [baseline] (666.836 µs) : 0, 667
Remote Config [candidate] (652.606 µs) : 0, 653
Telemetry [baseline] (8.038 ms) : 0, 8038
Telemetry [candidate] (8.06 ms) : 0, 8060
Flare Poller [baseline] (3.754 ms) : 0, 3754
Flare Poller [candidate] (3.796 ms) : 0, 3796
ProfilingAgent [baseline] (97.07 ms) : 0, 97070
ProfilingAgent [candidate] (97.133 ms) : 0, 97133
Profiling [baseline] (97.66 ms) : 0, 97660
Profiling [candidate] (97.711 ms) : 0, 97711
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.56.0-SNAPSHOT~f9602ef1e5, baseline=1.56.0-SNAPSHOT~4842f7f4c3
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.103 s) : 0, 1103150
Total [baseline] (8.847 s) : 0, 8847419
Agent [candidate] (1.104 s) : 0, 1103619
Total [candidate] (8.836 s) : 0, 8836188
section iast
Agent [baseline] (1.239 s) : 0, 1239039
Total [baseline] (9.586 s) : 0, 9586019
Agent [candidate] (1.239 s) : 0, 1239426
Total [candidate] (9.541 s) : 0, 9541371
gantt
title insecure-bank - break down per module: candidate=1.56.0-SNAPSHOT~f9602ef1e5, baseline=1.56.0-SNAPSHOT~4842f7f4c3
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.461 ms) : 0, 1461
crashtracking [candidate] (1.462 ms) : 0, 1462
BytebuddyAgent [baseline] (708.804 ms) : 0, 708804
BytebuddyAgent [candidate] (709.737 ms) : 0, 709737
GlobalTracer [baseline] (249.429 ms) : 0, 249429
GlobalTracer [candidate] (249.651 ms) : 0, 249651
AppSec [baseline] (32.299 ms) : 0, 32299
AppSec [candidate] (32.156 ms) : 0, 32156
Debugger [baseline] (63.366 ms) : 0, 63366
Debugger [candidate] (63.025 ms) : 0, 63025
Remote Config [baseline] (637.68 µs) : 0, 638
Remote Config [candidate] (626.967 µs) : 0, 627
Telemetry [baseline] (8.382 ms) : 0, 8382
Telemetry [candidate] (8.249 ms) : 0, 8249
Flare Poller [baseline] (3.752 ms) : 0, 3752
Flare Poller [candidate] (3.729 ms) : 0, 3729
section iast
crashtracking [baseline] (1.457 ms) : 0, 1457
crashtracking [candidate] (1.456 ms) : 0, 1456
BytebuddyAgent [baseline] (831.981 ms) : 0, 831981
BytebuddyAgent [candidate] (832.16 ms) : 0, 832160
GlobalTracer [baseline] (237.663 ms) : 0, 237663
GlobalTracer [candidate] (237.617 ms) : 0, 237617
AppSec [baseline] (32.922 ms) : 0, 32922
AppSec [candidate] (33.131 ms) : 0, 33131
Debugger [baseline] (60.045 ms) : 0, 60045
Debugger [candidate] (60.033 ms) : 0, 60033
Remote Config [baseline] (558.558 µs) : 0, 559
Remote Config [candidate] (542.686 µs) : 0, 543
Telemetry [baseline] (7.625 ms) : 0, 7625
Telemetry [candidate] (7.642 ms) : 0, 7642
Flare Poller [baseline] (3.47 ms) : 0, 3470
Flare Poller [candidate] (3.501 ms) : 0, 3501
IAST [baseline] (28.286 ms) : 0, 28286
IAST [candidate] (28.282 ms) : 0, 28282
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 0 performance regressions! Performance is the same for 17 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~f9602ef1e5, baseline=1.56.0-SNAPSHOT~4842f7f4c3
dateFormat X
axisFormat %s
section baseline
no_agent (1.195 ms) : 1184, 1207
. : milestone, 1195,
iast (3.286 ms) : 3241, 3332
. : milestone, 3286,
iast_FULL (5.89 ms) : 5830, 5949
. : milestone, 5890,
iast_GLOBAL (3.653 ms) : 3584, 3723
. : milestone, 3653,
profiling (2.276 ms) : 2255, 2297
. : milestone, 2276,
tracing (1.839 ms) : 1824, 1854
. : milestone, 1839,
section candidate
no_agent (1.214 ms) : 1203, 1226
. : milestone, 1214,
iast (3.215 ms) : 3175, 3256
. : milestone, 3215,
iast_FULL (5.762 ms) : 5705, 5820
. : milestone, 5762,
iast_GLOBAL (3.353 ms) : 3305, 3401
. : milestone, 3353,
profiling (2.029 ms) : 2011, 2047
. : milestone, 2029,
tracing (1.78 ms) : 1766, 1794
. : milestone, 1780,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~f9602ef1e5, baseline=1.56.0-SNAPSHOT~4842f7f4c3
dateFormat X
axisFormat %s
section baseline
no_agent (19.219 ms) : 19024, 19414
. : milestone, 19219,
appsec (18.768 ms) : 18579, 18957
. : milestone, 18768,
code_origins (17.946 ms) : 17768, 18124
. : milestone, 17946,
iast (17.771 ms) : 17594, 17947
. : milestone, 17771,
profiling (19.069 ms) : 18880, 19258
. : milestone, 19069,
tracing (17.869 ms) : 17689, 18048
. : milestone, 17869,
section candidate
no_agent (17.886 ms) : 17703, 18069
. : milestone, 17886,
appsec (18.598 ms) : 18410, 18787
. : milestone, 18598,
code_origins (18.465 ms) : 18281, 18650
. : milestone, 18465,
iast (17.848 ms) : 17674, 18022
. : milestone, 17848,
profiling (18.717 ms) : 18529, 18905
. : milestone, 18717,
tracing (17.978 ms) : 17799, 18157
. : milestone, 17978,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~f9602ef1e5, baseline=1.56.0-SNAPSHOT~4842f7f4c3
dateFormat X
axisFormat %s
section baseline
no_agent (1.477 ms) : 1466, 1489
. : milestone, 1477,
appsec (2.468 ms) : 2416, 2520
. : milestone, 2468,
iast (2.218 ms) : 2154, 2283
. : milestone, 2218,
iast_GLOBAL (2.262 ms) : 2197, 2327
. : milestone, 2262,
profiling (2.076 ms) : 2024, 2129
. : milestone, 2076,
tracing (2.058 ms) : 2006, 2109
. : milestone, 2058,
section candidate
no_agent (1.477 ms) : 1466, 1489
. : milestone, 1477,
appsec (3.642 ms) : 3428, 3856
. : milestone, 3642,
iast (2.211 ms) : 2146, 2275
. : milestone, 2211,
iast_GLOBAL (2.265 ms) : 2200, 2331
. : milestone, 2265,
profiling (2.097 ms) : 2043, 2151
. : milestone, 2097,
tracing (2.054 ms) : 2002, 2105
. : milestone, 2054,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~f9602ef1e5, baseline=1.56.0-SNAPSHOT~4842f7f4c3
dateFormat X
axisFormat %s
section baseline
no_agent (15.046 s) : 15046000, 15046000
. : milestone, 15046000,
appsec (14.67 s) : 14670000, 14670000
. : milestone, 14670000,
iast (18.107 s) : 18107000, 18107000
. : milestone, 18107000,
iast_GLOBAL (17.729 s) : 17729000, 17729000
. : milestone, 17729000,
profiling (14.66 s) : 14660000, 14660000
. : milestone, 14660000,
tracing (14.687 s) : 14687000, 14687000
. : milestone, 14687000,
section candidate
no_agent (15.398 s) : 15398000, 15398000
. : milestone, 15398000,
appsec (15.253 s) : 15253000, 15253000
. : milestone, 15253000,
iast (18.473 s) : 18473000, 18473000
. : milestone, 18473000,
iast_GLOBAL (17.725 s) : 17725000, 17725000
. : milestone, 17725000,
profiling (14.592 s) : 14592000, 14592000
. : milestone, 14592000,
tracing (14.516 s) : 14516000, 14516000
. : milestone, 14516000,
|
|
@leoromanovsky The reason is this PR : tl;dr: |
What Does This Do
This PR fixes the tests requirements for one of the new OpenFeatures modules.
Motivation
The
masterbuild is failing onmaster:Additional Notes
Manual CI trigger with the non default VMs: https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-java/-/pipelines/83300885
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]