Skip to content

Crashtracker: dual ship to error tracking #10000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Crashtracker: dual ship to error tracking #10000

wants to merge 5 commits into from

Conversation

@amarziali
Copy link
Contributor

@amarziali amarziali commented Nov 19, 2025 •
edited
Loading

What Does This Do

This PR introduces dual shipping of crash reports to both the telemetry and error-tracking intakes. While only the stack-frame section of the payload is shared between the two destinations, the remaining fields have been adapted to each intake’s expected format.

We improved signal-info (sig_info) parsing to extract the program counter address more reliably, and this information is now also included in the telemetry payload. Additional handling has been added for cases where an hs_err file indicates an OutOfMemory crash, as these reports typically lack signal data.

Communication Improvements

The OkHttp client has been configured to support up to four concurrent operations — telemetry ping, telemetry upload, error-tracking ping, and error-tracking upload. Similar to profiling, the underlying thread pool has been customized so that threads run as daemon threads, allowing the JVM to exit cleanly without shutdown delays.

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@pr-commenter
Copy link

pr-commenter bot commented Nov 19, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/dualship
git_commit_date 1763731854 1763978748
git_commit_sha 614cc72 399f8cc
release_version 1.57.0-SNAPSHOT~614cc721f6 1.57.0-SNAPSHOT~399f8cc599
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1763980574 1763980574
ci_job_id 1253080283 1253080283
ci_pipeline_id 83783975 83783975
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-3qvit753 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-3qvit753 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 7 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~399f8cc599, baseline=1.57.0-SNAPSHOT~614cc721f6

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.101 s) : 0, 1100602
Total [baseline] (10.828 s) : 0, 10827985
Agent [candidate] (1.102 s) : 0, 1102217
Total [candidate] (10.838 s) : 0, 10838128
section appsec
Agent [baseline] (1.291 s) : 0, 1290548
Total [baseline] (11.176 s) : 0, 11175745
Agent [candidate] (1.286 s) : 0, 1285559
Total [candidate] (11.201 s) : 0, 11200649
section iast
Agent [baseline] (1.243 s) : 0, 1242695
Total [baseline] (11.3 s) : 0, 11299668
Agent [candidate] (1.24 s) : 0, 1240323
Total [candidate] (11.312 s) : 0, 11311618
section profiling
Agent [baseline] (1.231 s) : 0, 1230616
Total [baseline] (11.13 s) : 0, 11130296
Agent [candidate] (1.233 s) : 0, 1232668
Total [candidate] (11.093 s) : 0, 11092892
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.101 s -
Agent appsec 1.291 s 189.946 ms (17.3%)
Agent iast 1.243 s 142.093 ms (12.9%)
Agent profiling 1.231 s 130.013 ms (11.8%)
Total tracing 10.828 s -
Total appsec 11.176 s 347.76 ms (3.2%)
Total iast 11.3 s 471.683 ms (4.4%)
Total profiling 11.13 s 302.311 ms (2.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.102 s -
Agent appsec 1.286 s 183.341 ms (16.6%)
Agent iast 1.24 s 138.105 ms (12.5%)
Agent profiling 1.233 s 130.45 ms (11.8%)
Total tracing 10.838 s -
Total appsec 11.201 s 362.521 ms (3.3%)
Total iast 11.312 s 473.49 ms (4.4%)
Total profiling 11.093 s 254.763 ms (2.4%) 
gantt
    title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~399f8cc599, baseline=1.57.0-SNAPSHOT~614cc721f6

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.471 ms) : 0, 1471
crashtracking [candidate] (1.503 ms) : 0, 1503
BytebuddyAgent [baseline] (707.846 ms) : 0, 707846
BytebuddyAgent [candidate] (708.088 ms) : 0, 708088
GlobalTracer [baseline] (248.113 ms) : 0, 248113
GlobalTracer [candidate] (249.309 ms) : 0, 249309
AppSec [baseline] (32.019 ms) : 0, 32019
AppSec [candidate] (31.931 ms) : 0, 31931
Debugger [baseline] (63.935 ms) : 0, 63935
Debugger [candidate] (64.098 ms) : 0, 64098
Remote Config [baseline] (628.932 µs) : 0, 629
Remote Config [candidate] (645.451 µs) : 0, 645
Telemetry [baseline] (8.217 ms) : 0, 8217
Telemetry [candidate] (8.181 ms) : 0, 8181
Flare Poller [baseline] (3.661 ms) : 0, 3661
Flare Poller [candidate] (3.737 ms) : 0, 3737
section appsec
crashtracking [baseline] (1.479 ms) : 0, 1479
crashtracking [candidate] (1.499 ms) : 0, 1499
BytebuddyAgent [baseline] (736.715 ms) : 0, 736715
BytebuddyAgent [candidate] (734.082 ms) : 0, 734082
GlobalTracer [baseline] (243.119 ms) : 0, 243119
GlobalTracer [candidate] (241.604 ms) : 0, 241604
IAST [baseline] (24.916 ms) : 0, 24916
IAST [candidate] (24.777 ms) : 0, 24777
AppSec [baseline] (174.629 ms) : 0, 174629
AppSec [candidate] (174.543 ms) : 0, 174543
Debugger [baseline] (61.872 ms) : 0, 61872
Debugger [candidate] (61.401 ms) : 0, 61401
Remote Config [baseline] (671.857 µs) : 0, 672
Remote Config [candidate] (660.927 µs) : 0, 661
Telemetry [baseline] (8.225 ms) : 0, 8225
Telemetry [candidate] (8.213 ms) : 0, 8213
Flare Poller [baseline] (4.004 ms) : 0, 4004
Flare Poller [candidate] (3.897 ms) : 0, 3897
section iast
crashtracking [baseline] (1.494 ms) : 0, 1494
crashtracking [candidate] (1.488 ms) : 0, 1488
BytebuddyAgent [baseline] (834.415 ms) : 0, 834415
BytebuddyAgent [candidate] (832.69 ms) : 0, 832690
GlobalTracer [baseline] (238.011 ms) : 0, 238011
GlobalTracer [candidate] (237.643 ms) : 0, 237643
IAST [baseline] (28.493 ms) : 0, 28493
IAST [candidate] (27.36 ms) : 0, 27360
AppSec [baseline] (32.957 ms) : 0, 32957
AppSec [candidate] (33.945 ms) : 0, 33945
Debugger [baseline] (60.779 ms) : 0, 60779
Debugger [candidate] (60.847 ms) : 0, 60847
Remote Config [baseline] (543.808 µs) : 0, 544
Remote Config [candidate] (537.343 µs) : 0, 537
Telemetry [baseline] (7.622 ms) : 0, 7622
Telemetry [candidate] (7.567 ms) : 0, 7567
Flare Poller [baseline] (3.527 ms) : 0, 3527
Flare Poller [candidate] (3.496 ms) : 0, 3496
section profiling
crashtracking [baseline] (1.415 ms) : 0, 1415
crashtracking [candidate] (1.433 ms) : 0, 1433
BytebuddyAgent [baseline] (734.562 ms) : 0, 734562
BytebuddyAgent [candidate] (734.738 ms) : 0, 734738
GlobalTracer [baseline] (221.849 ms) : 0, 221849
GlobalTracer [candidate] (222.222 ms) : 0, 222222
AppSec [baseline] (32.128 ms) : 0, 32128
AppSec [candidate] (32.135 ms) : 0, 32135
Debugger [baseline] (62.653 ms) : 0, 62653
Debugger [candidate] (63.425 ms) : 0, 63425
Remote Config [baseline] (636.902 µs) : 0, 637
Remote Config [candidate] (634.949 µs) : 0, 635
Telemetry [baseline] (7.973 ms) : 0, 7973
Telemetry [candidate] (7.89 ms) : 0, 7890
Flare Poller [baseline] (3.722 ms) : 0, 3722
Flare Poller [candidate] (3.702 ms) : 0, 3702
ProfilingAgent [baseline] (96.831 ms) : 0, 96831
ProfilingAgent [candidate] (97.461 ms) : 0, 97461
Profiling [baseline] (97.413 ms) : 0, 97413
Profiling [candidate] (98.036 ms) : 0, 98036
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~399f8cc599, baseline=1.57.0-SNAPSHOT~614cc721f6

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.105 s) : 0, 1104560
Total [baseline] (8.964 s) : 0, 8964417
Agent [candidate] (1.103 s) : 0, 1102629
Total [candidate] (8.913 s) : 0, 8912928
section iast
Agent [baseline] (1.254 s) : 0, 1253926
Total [baseline] (9.642 s) : 0, 9641842
Agent [candidate] (1.24 s) : 0, 1239958
Total [candidate] (9.571 s) : 0, 9570676
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.105 s -
Agent iast 1.254 s 149.366 ms (13.5%)
Total tracing 8.964 s -
Total iast 9.642 s 677.425 ms (7.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.103 s -
Agent iast 1.24 s 137.329 ms (12.5%)
Total tracing 8.913 s -
Total iast 9.571 s 657.748 ms (7.4%) 
gantt
    title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~399f8cc599, baseline=1.57.0-SNAPSHOT~614cc721f6

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.495 ms) : 0, 1495
crashtracking [candidate] (1.482 ms) : 0, 1482
BytebuddyAgent [baseline] (710.554 ms) : 0, 710554
BytebuddyAgent [candidate] (709.358 ms) : 0, 709358
GlobalTracer [baseline] (249.619 ms) : 0, 249619
GlobalTracer [candidate] (249.265 ms) : 0, 249265
AppSec [baseline] (32.118 ms) : 0, 32118
AppSec [candidate] (31.873 ms) : 0, 31873
Debugger [baseline] (63.271 ms) : 0, 63271
Debugger [candidate] (63.0 ms) : 0, 63000
Remote Config [baseline] (641.131 µs) : 0, 641
Remote Config [candidate] (658.284 µs) : 0, 658
Telemetry [baseline] (8.281 ms) : 0, 8281
Telemetry [candidate] (8.42 ms) : 0, 8420
Flare Poller [baseline] (3.686 ms) : 0, 3686
Flare Poller [candidate] (3.792 ms) : 0, 3792
section iast
crashtracking [baseline] (1.503 ms) : 0, 1503
crashtracking [candidate] (1.474 ms) : 0, 1474
BytebuddyAgent [baseline] (844.203 ms) : 0, 844203
BytebuddyAgent [candidate] (832.457 ms) : 0, 832457
GlobalTracer [baseline] (238.428 ms) : 0, 238428
GlobalTracer [candidate] (238.251 ms) : 0, 238251
IAST [baseline] (26.933 ms) : 0, 26933
IAST [candidate] (29.457 ms) : 0, 29457
AppSec [baseline] (35.169 ms) : 0, 35169
AppSec [candidate] (32.241 ms) : 0, 32241
Debugger [baseline] (60.657 ms) : 0, 60657
Debugger [candidate] (59.663 ms) : 0, 59663
Remote Config [baseline] (552.374 µs) : 0, 552
Remote Config [candidate] (531.221 µs) : 0, 531
Telemetry [baseline] (7.754 ms) : 0, 7754
Telemetry [candidate] (7.574 ms) : 0, 7574
Flare Poller [baseline] (3.566 ms) : 0, 3566
Flare Poller [candidate] (3.461 ms) : 0, 3461
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/dualship
git_commit_date 1763731854 1763978748
git_commit_sha 614cc72 399f8cc
release_version 1.57.0-SNAPSHOT~614cc721f6 1.57.0-SNAPSHOT~399f8cc599
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1763981155 1763981155
ci_job_id 1253080284 1253080284
ci_pipeline_id 83783975 83783975
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-rcprdw5w 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-rcprdw5w 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 19 metrics, 16 unstable metrics.

scenario Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p95 Δ mean throughput candidate mean agg_http_req_duration_p50 candidate mean agg_http_req_duration_p95 candidate mean throughput baseline mean agg_http_req_duration_p50 baseline mean agg_http_req_duration_p95 baseline mean throughput
scenario:load:insecure-bank:iast:high_load better
[-166.796µs; -90.042µs] or [-6.438%; -3.475%]		 same
[-555.522µs; +55.520µs] or [-7.432%; +0.743%]		 unstable
[-93.562op/s; +216.375op/s] or [-6.786%; +15.694%]		 2.462ms 7.225ms 1440.094op/s 2.591ms 7.475ms 1378.688op/s
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~399f8cc599, baseline=1.57.0-SNAPSHOT~614cc721f6
    dateFormat X
    axisFormat %s
section baseline
no_agent (19.246 ms) : 19052, 19441
.   : milestone, 19246,
appsec (19.053 ms) : 18860, 19247
.   : milestone, 19053,
code_origins (17.797 ms) : 17619, 17975
.   : milestone, 17797,
iast (17.85 ms) : 17669, 18032
.   : milestone, 17850,
profiling (18.677 ms) : 18487, 18866
.   : milestone, 18677,
tracing (17.89 ms) : 17710, 18069
.   : milestone, 17890,
section candidate
no_agent (19.579 ms) : 19372, 19786
.   : milestone, 19579,
appsec (18.809 ms) : 18621, 18997
.   : milestone, 18809,
code_origins (17.703 ms) : 17524, 17882
.   : milestone, 17703,
iast (17.816 ms) : 17638, 17994
.   : milestone, 17816,
profiling (18.516 ms) : 18331, 18701
.   : milestone, 18516,
tracing (17.915 ms) : 17735, 18094
.   : milestone, 17915,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 19.246 ms [19.052 ms, 19.441 ms] -
appsec 19.053 ms [18.86 ms, 19.247 ms] -193.059 µs (-1.0%)
code_origins 17.797 ms [17.619 ms, 17.975 ms] -1.449 ms (-7.5%)
iast 17.85 ms [17.669 ms, 18.032 ms] -1.396 ms (-7.3%)
profiling 18.677 ms [18.487 ms, 18.866 ms] -569.937 µs (-3.0%)
tracing 17.89 ms [17.71 ms, 18.069 ms] -1.357 ms (-7.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 19.579 ms [19.372 ms, 19.786 ms] -
appsec 18.809 ms [18.621 ms, 18.997 ms] -769.999 µs (-3.9%)
code_origins 17.703 ms [17.524 ms, 17.882 ms] -1.876 ms (-9.6%)
iast 17.816 ms [17.638 ms, 17.994 ms] -1.763 ms (-9.0%)
profiling 18.516 ms [18.331 ms, 18.701 ms] -1.063 ms (-5.4%)
tracing 17.915 ms [17.735 ms, 18.094 ms] -1.664 ms (-8.5%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~399f8cc599, baseline=1.57.0-SNAPSHOT~614cc721f6
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.19 ms) : 1178, 1201
.   : milestone, 1190,
iast (3.321 ms) : 3270, 3373
.   : milestone, 3321,
iast_FULL (5.901 ms) : 5843, 5959
.   : milestone, 5901,
iast_GLOBAL (3.609 ms) : 3545, 3673
.   : milestone, 3609,
profiling (2.104 ms) : 2086, 2122
.   : milestone, 2104,
tracing (1.826 ms) : 1810, 1841
.   : milestone, 1826,
section candidate
no_agent (1.18 ms) : 1169, 1191
.   : milestone, 1180,
iast (3.176 ms) : 3130, 3223
.   : milestone, 3176,
iast_FULL (5.767 ms) : 5710, 5825
.   : milestone, 5767,
iast_GLOBAL (3.608 ms) : 3548, 3667
.   : milestone, 3608,
profiling (2.074 ms) : 2056, 2092
.   : milestone, 2074,
tracing (1.85 ms) : 1835, 1865
.   : milestone, 1850,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.19 ms [1.178 ms, 1.201 ms] -
iast 3.321 ms [3.27 ms, 3.373 ms] 2.132 ms (179.1%)
iast_FULL 5.901 ms [5.843 ms, 5.959 ms] 4.711 ms (395.9%)
iast_GLOBAL 3.609 ms [3.545 ms, 3.673 ms] 2.419 ms (203.3%)
profiling 2.104 ms [2.086 ms, 2.122 ms] 913.97 µs (76.8%)
tracing 1.826 ms [1.81 ms, 1.841 ms] 635.838 µs (53.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.18 ms [1.169 ms, 1.191 ms] -
iast 3.176 ms [3.13 ms, 3.223 ms] 1.996 ms (169.2%)
iast_FULL 5.767 ms [5.71 ms, 5.825 ms] 4.587 ms (388.8%)
iast_GLOBAL 3.608 ms [3.548 ms, 3.667 ms] 2.428 ms (205.7%)
profiling 2.074 ms [2.056 ms, 2.092 ms] 893.789 µs (75.7%)
tracing 1.85 ms [1.835 ms, 1.865 ms] 670.29 µs (56.8%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/dualship
git_commit_date 1763731854 1763978748
git_commit_sha 614cc72 399f8cc
release_version 1.57.0-SNAPSHOT~614cc721f6 1.57.0-SNAPSHOT~399f8cc599
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1763980774 1763980774
ci_job_id 1253080286 1253080286
ci_pipeline_id 83783975 83783975
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-gfrvbqtt 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-gfrvbqtt 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.

scenario Δ mean execution_time candidate mean execution_time baseline mean execution_time
scenario:dacapo:tomcat:appsec better
[-1.439ms; -1.091ms] or [-38.736%; -29.362%]		 2.451ms 3.716ms
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~399f8cc599, baseline=1.57.0-SNAPSHOT~614cc721f6
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.471 ms) : 1460, 1483
.   : milestone, 1471,
appsec (3.716 ms) : 3493, 3939
.   : milestone, 3716,
iast (2.203 ms) : 2138, 2267
.   : milestone, 2203,
iast_GLOBAL (2.252 ms) : 2187, 2317
.   : milestone, 2252,
profiling (2.089 ms) : 2035, 2143
.   : milestone, 2089,
tracing (2.027 ms) : 1976, 2077
.   : milestone, 2027,
section candidate
no_agent (1.474 ms) : 1463, 1486
.   : milestone, 1474,
appsec (2.451 ms) : 2399, 2502
.   : milestone, 2451,
iast (2.207 ms) : 2143, 2272
.   : milestone, 2207,
iast_GLOBAL (2.256 ms) : 2191, 2321
.   : milestone, 2256,
profiling (2.087 ms) : 2033, 2141
.   : milestone, 2087,
tracing (2.042 ms) : 1991, 2092
.   : milestone, 2042,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.471 ms [1.46 ms, 1.483 ms] -
appsec 3.716 ms [3.493 ms, 3.939 ms] 2.245 ms (152.5%)
iast 2.203 ms [2.138 ms, 2.267 ms] 731.203 µs (49.7%)
iast_GLOBAL 2.252 ms [2.187 ms, 2.317 ms] 780.517 µs (53.0%)
profiling 2.089 ms [2.035 ms, 2.143 ms] 617.766 µs (42.0%)
tracing 2.027 ms [1.976 ms, 2.077 ms] 555.54 µs (37.8%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.474 ms [1.463 ms, 1.486 ms] -
appsec 2.451 ms [2.399 ms, 2.502 ms] 976.551 µs (66.2%)
iast 2.207 ms [2.143 ms, 2.272 ms] 733.246 µs (49.7%)
iast_GLOBAL 2.256 ms [2.191 ms, 2.321 ms] 782.215 µs (53.1%)
profiling 2.087 ms [2.033 ms, 2.141 ms] 612.532 µs (41.6%)
tracing 2.042 ms [1.991 ms, 2.092 ms] 567.567 µs (38.5%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~399f8cc599, baseline=1.57.0-SNAPSHOT~614cc721f6
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.833 s) : 14833000, 14833000
.   : milestone, 14833000,
appsec (14.726 s) : 14726000, 14726000
.   : milestone, 14726000,
iast (18.65 s) : 18650000, 18650000
.   : milestone, 18650000,
iast_GLOBAL (17.967 s) : 17967000, 17967000
.   : milestone, 17967000,
profiling (14.679 s) : 14679000, 14679000
.   : milestone, 14679000,
tracing (14.742 s) : 14742000, 14742000
.   : milestone, 14742000,
section candidate
no_agent (15.584 s) : 15584000, 15584000
.   : milestone, 15584000,
appsec (15.206 s) : 15206000, 15206000
.   : milestone, 15206000,
iast (18.194 s) : 18194000, 18194000
.   : milestone, 18194000,
iast_GLOBAL (17.446 s) : 17446000, 17446000
.   : milestone, 17446000,
profiling (14.559 s) : 14559000, 14559000
.   : milestone, 14559000,
tracing (14.806 s) : 14806000, 14806000
.   : milestone, 14806000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.833 s [14.833 s, 14.833 s] -
appsec 14.726 s [14.726 s, 14.726 s] -107.0 ms (-0.7%)
iast 18.65 s [18.65 s, 18.65 s] 3.817 s (25.7%)
iast_GLOBAL 17.967 s [17.967 s, 17.967 s] 3.134 s (21.1%)
profiling 14.679 s [14.679 s, 14.679 s] -154.0 ms (-1.0%)
tracing 14.742 s [14.742 s, 14.742 s] -91.0 ms (-0.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.584 s [15.584 s, 15.584 s] -
appsec 15.206 s [15.206 s, 15.206 s] -378.0 ms (-2.4%)
iast 18.194 s [18.194 s, 18.194 s] 2.61 s (16.7%)
iast_GLOBAL 17.446 s [17.446 s, 17.446 s] 1.862 s (11.9%)
profiling 14.559 s [14.559 s, 14.559 s] -1.025 s (-6.6%)
tracing 14.806 s [14.806 s, 14.806 s] -778.0 ms (-5.0%)

@pr-commenter
Copy link

pr-commenter bot commented Nov 21, 2025

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1763737917 1763738252
end_time 2025-11-21T15:13:19 2025-11-21T15:18:55
git_branch master andrea.marziali/dualship
git_commit_sha 614cc72 b921659
start_time 2025-11-21T15:11:57 2025-11-21T15:17:33
See matching parameters
Baseline Candidate
ci_job_id 1250844207 1250844207
ci_pipeline_id 83600252 83600252
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date 1763736936 1763736936

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 7 metrics, 8 unstable metrics.

See unchanged results
scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:noprobe unstable
[-59.135µs; +34.084µs] or [-19.580%; +11.286%]		 unstable
[-73.753µs; +41.176µs] or [-21.331%; +11.909%]		 unstable
[-89.749µs; +51.609µs] or [-24.689%; +14.197%]		 unstable
[-703.419µs; +293.699µs] or [-59.843%; +24.986%]		 unstable
[-127.167op/s; +127.167op/s] or [-5.277%; +5.277%]
scenario:basic same same same unstable
[-92.405µs; +176.369µs] or [-11.781%; +22.486%]		 unstable
[-127.260op/s; +255.465op/s] or [-5.090%; +10.219%]
scenario:loop same same same unstable
[-322.103µs; +564.535µs] or [-3.695%; +6.477%]		 same
Request duration reports for reports 
gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (345.758 µs) : 277, 414
.   : milestone, 346,
basic (296.369 µs) : 286, 307
.   : milestone, 296,
loop (8.442 ms) : 8380, 8504
.   : milestone, 8442,
section candidate
noprobe (329.469 µs) : 294, 365
.   : milestone, 329,
basic (294.3 µs) : 287, 302
.   : milestone, 294,
loop (8.44 ms) : 8379, 8501
.   : milestone, 8440,
Loading
  • baseline results
Scenario Request median duration [CI 0.99]
noprobe 345.758 µs [277.278 µs, 414.238 µs]
basic 296.369 µs [285.882 µs, 306.857 µs]
loop 8.442 ms [8.38 ms, 8.504 ms]
  • candidate results
Scenario Request median duration [CI 0.99]
noprobe 329.469 µs [293.572 µs, 365.366 µs]
basic 294.3 µs [286.684 µs, 301.917 µs]
loop 8.44 ms [8.379 ms, 8.501 ms]

@amarziali amarziali force-pushed the andrea.marziali/dualship branch from b921659 to 0882768 Compare November 21, 2025 15:34
@amarziali amarziali marked this pull request as ready for review November 24, 2025 09:16
@amarziali amarziali requested review from a team as code owners November 24, 2025 09:16
@amarziali amarziali requested a review from dougqh November 24, 2025 09:16
@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2025

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@amarziali amarziali added type: enhancement Enhancements and improvements comp: crash tracking Crash Tracking labels Nov 24, 2025
gleocadie
gleocadie approved these changes Nov 24, 2025
View reviewed changes
Copy link

@gleocadie gleocadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

GianlucaBortoli
GianlucaBortoli requested changes Nov 24, 2025
View reviewed changes
Copy link
Member

@GianlucaBortoli GianlucaBortoli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shipping crashes to the error tracking intake should be opt in like in libdatadog via the usual config mechanisms.

But the rest of the logic looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GianlucaBortoli GianlucaBortoli GianlucaBortoli requested changes

@gleocadie gleocadie gleocadie approved these changes

@dougqh dougqh Awaiting requested review from dougqh dougqh is a code owner automatically assigned from DataDog/apm-java

@jbachorik jbachorik Awaiting requested review from jbachorik

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

comp: crash tracking Crash Tracking type: enhancement Enhancements and improvements

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@amarziali @GianlucaBortoli @gleocadie