Skip to content

feat(internal/{appsec,traceprof}): reduce dependency on google.golang.org/grpc#4183

Merged
darccio merged 13 commits intomainfrom
dario.castane/apmlp-494/testapp-isolation
Dec 19, 2025
Merged

feat(internal/{appsec,traceprof}): reduce dependency on google.golang.org/grpc#4183
darccio merged 13 commits intomainfrom
dario.castane/apmlp-494/testapp-isolation

Conversation

@darccio
Copy link
Copy Markdown
Member

@darccio darccio commented Nov 27, 2025 •
edited
Loading

What does this PR do?

Isolates testapp (only used by internal/traceprof) and replaces metadata.MD with a simpler map[string][]string.

Stacked on #4182.

Motivation

Reduce the scope of our dependencies. In this case, grpc is an indirect dependency through go.opentelemetry.io/collector/component and others.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

darccio added 11 commits November 27, 2025 13:08
@darccio
feat(instrumentation/appsec/emitter/waf): replace mapstructure/v2 by …
65c8d9b 
…tailored code
@darccio
chore: make fix-modules after removing mapstructure/v2
f7acb83
@darccio
fix(instrumentation/appsec/emitter/waf/actions): update TestNewBlockP…
502d2fb 
…arams to realistic scenario
@darccio
chore(instrumentation/appsec/emitter/waf/actions): benchmark new impl…
b5e2b0d 
…ementation
@darccio
fix(instrumentation/appsec/emitter/waf/actions): update TestNewRedire…
65039e2 
…ctParams to realistic scenario
@darccio
feat(ddtrace/opentelemetry): remove Masterminds/semver/v3 usage in tests
49848be
@darccio
feat(internal/version): remove Masterminds/semver/v3 usage
f84d62a
@darccio
fix: go mod tidy & make fix-modules
aa0aa13
@darccio
feat(internal/traceprof/traceproftest): isolate testapp into tracepro…
b7f066f 
…ftest
@darccio
feat(internal/appsec/listener/httpsec): remove google.golang.org/grpc…
7d86a21 
…/metadata
@darccio
chore: go mod tidy (grpc becomes indirect)
60f439b
@darccio darccio requested review from a team as code owners November 27, 2025 17:34
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Nov 27, 2025 •
edited
Loading

Benchmarks

Benchmark execution time: 2025-12-19 12:26:04

Comparing candidate commit 38c30ba in PR branch dario.castane/apmlp-494/testapp-isolation with baseline commit ea97c59 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

Base automatically changed from dario.castane/apmlp-494/masterminds-semver to dario.castane/apmlp-494/mapstructure November 28, 2025 15:25
@dd-mergequeue dd-mergequeue Bot requested review from a team as code owners November 28, 2025 15:25
Base automatically changed from dario.castane/apmlp-494/mapstructure to main December 1, 2025 19:18
@darccio
Copy link
Copy Markdown
Member Author

darccio commented Dec 19, 2025

/merge

@dd-devflow-routing-codex
Copy link
Copy Markdown

dd-devflow-routing-codex Bot commented Dec 19, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-12-19 12:11:23 UTC ℹ️ Start processing command /merge

2025-12-19 12:11:33 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-12-19 12:11:48 UTC ⚠️ MergeQueue: This merge request was unqueued

dario.castane@datadoghq.com unqueued this merge request

@darccio
Copy link
Copy Markdown
Member Author

darccio commented Dec 19, 2025

/merge -c

@dd-devflow-routing-codex
Copy link
Copy Markdown

dd-devflow-routing-codex Bot commented Dec 19, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-12-19 12:11:39 UTC ℹ️ Start processing command /merge -c

@darccio darccio merged commit 2ec5e6f into main Dec 19, 2025
298 of 300 checks passed
@darccio darccio deleted the dario.castane/apmlp-494/testapp-isolation branch December 19, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kakkoyun kakkoyun kakkoyun approved these changes

@genesor genesor genesor approved these changes

@nsrip-dd nsrip-dd nsrip-dd approved these changes

Assignees

No one assigned

Labels

mergequeue-status: removed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@darccio @kakkoyun @genesor @nsrip-dd