-
Notifications
You must be signed in to change notification settings - Fork 488
feat(contrib/sarama): option to add custom consumer/producer span tags #3993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Discussing this with colleagues we also came up with the idea of changing this to a more generic |
This sounds more future-proof TBH. |
|
Cool, thanks for the feedback @kakkoyun. I'm on vacation for the next few weeks so not sure when I'll be able to update this, but I'll try to make some time to do so. |
6700372 to
f57982f
Compare
f57982f to
0debdab
Compare
|
@kakkoyun Could you please let me know if there are any additional changes needed, or if the implemented code looks good to you? |
|
@rarguelloF I have pushed the requested changes, can you please check it again? Thanks |
|
@rarguelloF anything missing here? |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
Tests failed on this commit 4222043: What to do next?
|
|
@fabiomargarido sorry I think it is a flaky test, it should be merged soon |
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
The expected merge time in
|
What does this PR do?
Add
WithConsumerCustomTagandWithProducerCustomTagoptions to enable adding custom tags to spans generated by wrapped consumers and producers.Motivation
Including extra information (e.g. Kafka message keys) as tags on spans can greatly enhance observability, enabling users to filter, group, and analyze traces based on specific message properties. This improves debugging capabilities and provides a clearer understanding of message flow within Kafka-based systems.
Reviewer's Checklist
./scripts/lint.shlocally.Unsure? Have a question? Request a review!