-
Notifications
You must be signed in to change notification settings - Fork 485
feat: datadog-lambda-go #3943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: datadog-lambda-go #3943
Conversation
c5daabc to
7122306
Compare
…ation.Version(). cold_start now in string.
| pkgs := GetPackages() | ||
| for pkg, info := range pkgs { | ||
| t.Run(string(pkg), func(t *testing.T) { | ||
| // Skip packages that don't implement analytics functionality |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know if this kind of skip is acceptable. Currently the datadog-lambda-go doesn't support instrumentation telemetry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't checked all the nitty-gritty details of the package itself since it's just a move.
Otherwise, it looks good to me.
We might need to update the CODEOWNERS though.
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
What does this PR do?
We are moving datadog-lambda-go to dd-trace-go (finally) !!!
This PR just
After this PR,
datadog-lambda-go's release will be done along with dd-trace-go as github.com/DataDog/dd-trace-go/contrib/aws/datadog-lambda-go/v2This PR does NOT include
Motivation
datadog-lambda-gotodd-trace-gois in general a better structure for future enhancements and maintenance.Testing
Smoke tested with a real lambda. Note that the datadog-lambda version will be the same as dd-trace-go version.

Reviewer's Checklist
./scripts/lint.shlocally.Benchmark and system-tests are going to be in other PRs.
https://datadoghq.atlassian.net/browse/APMSVLS-183