Skip to content

feat(ddtrace/opentelemetry): update expected span names based on otelhttp version#3551

Merged
darccio merged 1 commit intomainfrom
dario.castane/otel-breaking-change-20250526
May 27, 2025
Merged

feat(ddtrace/opentelemetry): update expected span names based on otelhttp version#3551
darccio merged 1 commit intomainfrom
dario.castane/otel-breaking-change-20250526

Conversation

@darccio
Copy link
Copy Markdown
Member

@darccio darccio commented May 26, 2025

What does this PR do?

Adapts assertions to allow otelhttp related test according to its version, as v0.61.0 introduces a new default semantic conventions version.

Motivation

Allow our smoke tests to handle the breaking change.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running golangci-lint run locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@darccio darccio requested a review from a team as a code owner May 26, 2025 19:36
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented May 26, 2025

Benchmarks

Benchmark execution time: 2025-05-26 21:32:27

Comparing candidate commit 0355147 in PR branch dario.castane/otel-breaking-change-20250526 with baseline commit 31f6d0d in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 21 metrics, 0 unstable metrics.

@darccio darccio force-pushed the dario.castane/otel-breaking-change-20250526 branch from 7827aef to 0355147 Compare May 26, 2025 21:21
@darccio darccio merged commit 1d6075b into main May 27, 2025
191 checks passed
@darccio darccio deleted the dario.castane/otel-breaking-change-20250526 branch May 27, 2025 08:19
darccio added a commit that referenced this pull request May 27, 2025
darccio added a commit that referenced this pull request May 27, 2025
darccio added a commit that referenced this pull request May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants