feat(apisec): implement new API Security sampler#3315
Conversation
Implementation of the new API Security sampler defined by the [latest RFC](https://docs.google.com/document/d/1PYoHms9PPXR8V_5_T5-KXAhoFDKQYA8mTnmS12xkGOE/edit?tab=t.0). This change makes the API Security sampler make decisions specific to a given endpoint (method + route + response status code) instead of using a simplistic sampling rate. This allows for improved coverage and accuracy of schema extraction as part of API Security. This change uses the sampler implementation from github.com/DataDog/appsec-internal-go#39.
github-actions
Bot
added
the
apm:ecosystem
Datadog ReportBranch report: ✅ 0 Failed, 4451 Passed, 66 Skipped, 3m 42.86s Total Time |
BenchmarksBenchmark execution time: 2025-04-03 10:47:28 Comparing candidate commit dcc6eb5 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 55 metrics, 1 unstable metrics. |
eliottness
left a comment
eliottness
left a comment
There was a problem hiding this comment.
Do you feel like working on apisec telemetry metrics in another PR ?
nsrip-dd
left a comment
nsrip-dd
left a comment
There was a problem hiding this comment.
Rubber stamp for the profiling bits (just go.mod/go.sum changes)
RomainMuller
force-pushed
the
romain.marcadier/APPSEC-56547/api-sec-sampler
branch
from
750d466 to
55c3db6
Compare
RomainMuller
force-pushed
the
romain.marcadier/APPSEC-56547/api-sec-sampler
branch
from
68b606f to
2dde675
Compare
| spanopts = append(spanopts, httptraceinternal.HeaderTagsFromRequest(req, r.config.headerTags)) | ||
| resource := r.config.resourceNamer(r, req) | ||
| httptrace.TraceAndServe(r.Router, w, req, &httptrace.ServeConfig{ | ||
| Framework: "github.com/gorilla/mux", |
There was a problem hiding this comment.
@RomainMuller Do all HTTP contribs need to register this Framework field? It's to add this to contribution guidelines.
There was a problem hiding this comment.
AppSec basically uses this to tag telemetry when we are unable to obtain some information... So this is optional, but I reckon helps if present (that might be useful for APM telemetry, too, in the future?)
Implementation of the new API Security sampler defined by the [latest RFC](https://docs.google.com/document/d/1PYoHms9PPXR8V_5_T5-KXAhoFDKQYA8mTnmS12xkGOE/edit?tab=t.0). This change makes the API Security sampler make decisions specific to a given endpoint (method + route + response status code) instead of using a simplistic sampling rate. This allows for improved coverage and accuracy of schema extraction as part of API Security. This change uses the sampler implementation from DataDog/appsec-internal-go#39.
4 participants
Implementation of the new API Security sampler defined by the latest RFC.
This change makes the API Security sampler make decisions specific to a given endpoint (method + route + response status code) instead of using a simplistic sampling rate. This allows for improved coverage and accuracy of schema extraction as part of API Security.
This change uses the sampler implementation from DataDog/appsec-internal-go#39.
Reviewer's Checklist
v2-devbranch and reviewed by @DataDog/apm-go.Unsure? Have a question? Request a review!