Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appsec: new user monitoring SDK telemetry #3312

Merged

Conversation

RomainMuller
Copy link
Contributor

Adds the new user monitoring SDK telemetry as specified by RFC-1017. This is used to track usage of the old & new APIs for user monitoring.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

Adds the new user monitoring SDK telemetry as specified by RFC-1017.
This is used to track usage of the old & new APIs for user monitoring.
@RomainMuller RomainMuller marked this pull request as ready for review March 19, 2025 11:40
@RomainMuller RomainMuller requested review from a team as code owners March 19, 2025 11:40
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Mar 19, 2025

Datadog Report

Branch report: romain.marcadier/APPSEC-56555/ato-sdk-consolidation
Commit report: 4825aa8
Test service: dd-trace-go

❌ 1 Failed (1 Known Flaky), 4385 Passed, 64 Skipped, 3m 45.68s Total Time

❌ Failed Tests (1)

  • TestAnalyticsSettings - github.com/DataDog/dd-trace-go/contrib/gorm.io/gorm.v1/v2 - ❄️ Known flaky - Details

    Expand for error
     
     2025/03/19 11:44:34 �[31;1m/home/runner/work/dd-trace-go/dd-trace-go/contrib/gorm.io/gorm.v1/gorm_test.go:419 �[35;1minsufficient arguments
     �[0m�[33m[0.310ms] �[34;1m[rows:-]�[0m SELECT * FROM "products" LIMIT 1
     2025/03/19 11:44:34 insufficient arguments
    

@pr-commenter
Copy link

pr-commenter bot commented Mar 19, 2025

Benchmarks

Benchmark execution time: 2025-03-19 12:09:17

Comparing candidate commit 8a4c2ce in PR branch romain.marcadier/APPSEC-56555/ato-sdk-consolidation with baseline commit 75ae7cd in branch v2-dev.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 0 unstable metrics.

@RomainMuller RomainMuller merged commit de3ec4e into v2-dev Mar 24, 2025
100 of 192 checks passed
@RomainMuller RomainMuller deleted the romain.marcadier/APPSEC-56555/ato-sdk-consolidation branch March 24, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants