contrib/database/sql: add in ddh, dddb propagation

[tabgok]

What does this PR do?

This PR adds in the ddh and dddb peer service tags to SQL comments.

Motivation

This change allows the DBM product to propagate service name information which maps with the inferred entities/services used by APM.

Reviewer's Checklist

• Changed code has unit tests for its functionality at or near 100% coverage.
• System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
• There is a benchmark for any new code, or changes to existing code.
• If this interacts with the agent in a new way, a system test has been added.
• Add an appropriate team label so this PR gets put in the right place for the release notes.
• Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

For Datadog employees:

• If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
• This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

[pr-commenter]

Benchmarks

Benchmark execution time: 2024-02-22 20:03:14

Comparing candidate commit b51d551 in PR branch teague.bick/AIT-9706/dbm-peer-service-tags with baseline commit 1dfe613 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 40 metrics, 1 unstable metrics.

[rarguelloF]

Nice work, but I think we need a slightly different approach because of the issue mentioned in one of the comments (it will only work when there's a parent span + the parent span is modified).

The code in this integration is a little bit tricky, since it starts the span after the actual query is executed and the DBM comments are injected (there is a comment in the injectComments function explaining the rationale behind this).

For this reason, probably the simplest approach to achieve this is:

• Update the tracer.SQLCommentCarrier to include 2 new fields: PeerHostname and PeerDBName and use those for the comment injection.
• Update injectComments to set these 2 new fields accessing the corresponding tags from tc.meta.

Please let me know if you agree and/or wanna discuss the approach in more detail! 🙇

[rarguelloF]

Looking great! Just a small change in the newly introduced ParseDSN logic changes and should be good to go!

[rarguelloF]

One last comment I missed in the previous review, which I noticed from the failed tests in the CI.

[tabgok]

/merge

[dd-devflow]

❌ MergeQueue

You are not allowed to use the merge queue towards main.

If you need support, contact us on Slack #ci-interfaces with those details!

[tabgok]

/merge

[dd-devflow]

❌ MergeQueue

You are not allowed to use the merge queue towards main.

If you need support, contact us on Slack #ci-interfaces with those details!

[rarguelloF]

/merge

[dd-devflow]

🚂 MergeQueue

Pull request added to the queue.

This build is going to start soon! (estimated merge in less than 58s)

Use /merge -c to cancel this operation!