Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddtrace/tracer: clean orchestrion startup logs #2206

Merged
merged 1 commit into from
Sep 6, 2023
Merged

ddtrace/tracer: clean orchestrion startup logs #2206

merged 1 commit into from
Sep 6, 2023
+7 −7

Conversation

ahmed-mez
Copy link
Contributor

@ahmed-mez ahmed-mez commented Sep 6, 2023 •
edited
Loading

What does this PR do?

Drop the orchestrion metadata field from startup logs if empty.

Motivation

Cleaner log - related to #2205

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@ahmed-mez ahmed-mez requested review from darccio and a team September 6, 2023 11:44
@ahmed-mez ahmed-mez merged commit b49b27c into main Sep 6, 2023
50 checks passed
@ahmed-mez ahmed-mez deleted the ahmed/imrove-startup-log branch September 6, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darccio darccio darccio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahmed-mez @darccio