List the versions that changed in package-version-bump PRs#8518
Open
andrewlock wants to merge 2 commits intomasterfrom
Open
List the versions that changed in package-version-bump PRs#8518andrewlock wants to merge 2 commits intomasterfrom
andrewlock wants to merge 2 commits intomasterfrom
Conversation
andrewlock
added
the
area:builds
andrewlock
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c10f073bcd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
andrewlock
force-pushed
the
andrew/add-summary-to-bump-package-versions
branch
from
0c81009 to
fe3814c
Compare
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8518) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8518) - mean (73ms) : 71, 75
master - mean (73ms) : 70, 76
section Bailout
This PR (8518) - mean (79ms) : 75, 83
master - mean (78ms) : 74, 82
section CallTarget+Inlining+NGEN
This PR (8518) - mean (1,080ms) : 1030, 1130
master - mean (1,083ms) : 1033, 1133
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8518) - mean (115ms) : 109, 121
master - mean (114ms) : 109, 119
section Bailout
This PR (8518) - mean (119ms) : 113, 126
master - mean (119ms) : 113, 124
section CallTarget+Inlining+NGEN
This PR (8518) - mean (783ms) : 757, 809
master - mean (777ms) : 746, 808
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8518) - mean (105ms) : 98, 112
master - mean (104ms) : 97, 112
section Bailout
This PR (8518) - mean (103ms) : 100, 106
master - mean (103ms) : 99, 106
section CallTarget+Inlining+NGEN
This PR (8518) - mean (942ms) : 910, 975
master - mean (940ms) : 907, 974
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8518) - mean (102ms) : 97, 106
master - mean (101ms) : 97, 106
section Bailout
This PR (8518) - mean (105ms) : 99, 111
master - mean (104ms) : 98, 110
section CallTarget+Inlining+NGEN
This PR (8518) - mean (826ms) : 777, 875
master - mean (822ms) : 786, 858
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8518) - mean (202ms) : 194, 210
master - mean (199ms) : 193, 204
section Bailout
This PR (8518) - mean (206ms) : 199, 214
master - mean (202ms) : 197, 208
section CallTarget+Inlining+NGEN
This PR (8518) - mean (1,198ms) : 1148, 1248
master - mean (1,180ms) : 1122, 1238
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8518) - mean (291ms) : 280, 302
master - mean (289ms) : 278, 300
section Bailout
This PR (8518) - mean (294ms) : 280, 307
master - mean (290ms) : 281, 299
section CallTarget+Inlining+NGEN
This PR (8518) - mean (961ms) : 927, 996
master - mean (950ms) : 923, 977
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8518) - mean (287ms) : 273, 300
master - mean (283ms) : 271, 294
section Bailout
This PR (8518) - mean (286ms) : 272, 300
master - mean (283ms) : 271, 294
section CallTarget+Inlining+NGEN
This PR (8518) - mean (1,158ms) : 1112, 1203
master - mean (1,144ms) : 1094, 1194
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8518) - mean (284ms) : 271, 297
master - mean (279ms) : 269, 290
section Bailout
This PR (8518) - mean (286ms) : 271, 301
master - mean (281ms) : 273, 289
section CallTarget+Inlining+NGEN
This PR (8518) - mean (1,057ms) : 988, 1125
master - mean (1,036ms) : 988, 1085
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
BenchmarksBenchmark execution time: 2026-04-24 12:37:18 Comparing candidate commit fe3814c in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 27 metrics, 0 unstable metrics, 58 known flaky benchmarks, 29 flaky benchmarks without significant changes.
|
bouwkast
approved these changes
Apr 27, 2026
Collaborator
bouwkast
left a comment
bouwkast
left a comment
There was a problem hiding this comment.
Nice improvement thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Lists the package versions that were updated in the description of version-bump PRs
Reason for change
In #8504 we removed all the "honeypot" csproj files that dependabot was using, mostly because the PRs it was creating weren't very useful, were noisy, and required us to trigger a separate PR anyway, so we switched to a schedule.
However, when reviewing the [Test Package Versions Bump] PRs, these files were the main ones I was reviewing, as they were easy to read. As a workaround, this PR extends the "cool down report" to be a more generalized "bump report", that lists the changes to the packages that were bumped too.
We could extend this even further in the future to include release note changes (like dependabot does) or
dotnet inspectupdates, as we've discussed in the past, though I can also see those being overly noisy for the common cases.Implementation details
Extend the existing report to include the list of packages that were bumped too.
Test coverage
Ran it locally, and it produced the following:
Package Version Updates
Bold entries indicate major-version bumps.
(new)means no previous version existed.Package Version Cooldown Report
The following versions were published less than 2 days ago and have been overridden.
These require manual review before inclusion.