Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Sending CI Vis Data to HQ #6621

Merged
merged 2 commits into from
Feb 11, 2025
Merged

[CI] Sending CI Vis Data to HQ #6621

merged 2 commits into from
Feb 11, 2025

Conversation

link04
Copy link
Contributor

@link04 link04 commented Feb 3, 2025 •
edited
Loading

Summary of changes

To have all data in one org so that it can be viewed collectively for all tracer languages.

Test coverage

This is the test 🫨
image

@link04 link04 requested a review from a team as a code owner February 3, 2025 15:47
@github-actions github-actions bot added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Feb 3, 2025
@andrewlock
Copy link
Member

andrewlock commented Feb 3, 2025 •
edited
Loading

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6621) - mean (69ms)  : 67, 72
     .   : milestone, 69,
    master - mean (69ms)  : 67, 72
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6621) - mean (995ms)  : 969, 1021
     .   : milestone, 995,
    master - mean (988ms)  : 965, 1012
     .   : milestone, 988,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6621) - mean (103ms)  : 101, 105
     .   : milestone, 103,
    master - mean (102ms)  : 100, 104
     .   : milestone, 102,

    section CallTarget+Inlining+NGEN
    This PR (6621) - mean (677ms)  : 660, 693
     .   : milestone, 677,
    master - mean (674ms)  : 657, 692
     .   : milestone, 674,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6621) - mean (90ms)  : 88, 92
     .   : milestone, 90,
    master - mean (89ms)  : 87, 92
     .   : milestone, 89,

    section CallTarget+Inlining+NGEN
    This PR (6621) - mean (634ms)  : 615, 653
     .   : milestone, 634,
    master - mean (630ms)  : 614, 647
     .   : milestone, 630,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6621) - mean (190ms)  : 186, 193
     .   : milestone, 190,
    master - mean (190ms)  : 185, 196
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6621) - mean (1,101ms)  : 1068, 1135
     .   : milestone, 1101,
    master - mean (1,104ms)  : 1074, 1134
     .   : milestone, 1104,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6621) - mean (270ms)  : 266, 273
     .   : milestone, 270,
    master - mean (271ms)  : 265, 276
     .   : milestone, 271,

    section CallTarget+Inlining+NGEN
    This PR (6621) - mean (863ms)  : 834, 892
     .   : milestone, 863,
    master - mean (863ms)  : 835, 892
     .   : milestone, 863,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6621) - mean (262ms)  : 257, 267
     .   : milestone, 262,
    master - mean (262ms)  : 258, 266
     .   : milestone, 262,

    section CallTarget+Inlining+NGEN
    This PR (6621) - mean (850ms)  : 815, 886
     .   : milestone, 850,
    master - mean (847ms)  : 817, 878
     .   : milestone, 847,
Loading

@bouwkast
Copy link
Contributor

bouwkast commented Feb 4, 2025

Were you able to see the data from this run to see whether it worked or not?

andrewlock
andrewlock approved these changes Feb 11, 2025
View reviewed changes
Copy link
Member

@andrewlock andrewlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We should also update all the dashboards used in the release process as neccessary 🙂

@andrewlock
Copy link
Member

Benchmarks Report for tracer 🐌

Benchmarks for #6621 compared to master:

  • 2 benchmarks are faster, with geometric mean 1.165
  • 1 benchmarks are slower, with geometric mean 1.276
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.98μs 45.5ns 319ns 0.0157 0.00783 0 5.61 KB
master StartStopWithChild netcoreapp3.1 9.86μs 54.6ns 345ns 0.0193 0.00482 0 5.81 KB
master StartStopWithChild net472 15.9μs 40.8ns 153ns 1.05 0.315 0.102 6.21 KB
#6621 StartStopWithChild net6.0 8.08μs 46.3ns 334ns 0.0117 0.00391 0 5.61 KB
#6621 StartStopWithChild netcoreapp3.1 9.94μs 54.2ns 325ns 0.0201 0.01 0 5.8 KB
#6621 StartStopWithChild net472 16.2μs 48.2ns 187ns 1.04 0.32 0.0961 6.21 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 474μs 352ns 1.32μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 639μs 369ns 1.43μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 842μs 558ns 2.09μs 0.419 0 0 3.3 KB
#6621 WriteAndFlushEnrichedTraces net6.0 484μs 218ns 817ns 0 0 0 2.7 KB
#6621 WriteAndFlushEnrichedTraces netcoreapp3.1 657μs 538ns 2.08μs 0 0 0 2.7 KB
#6621 WriteAndFlushEnrichedTraces net472 848μs 784ns 2.93μs 0.419 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 133μs 625ns 2.5μs 0.197 0 0 14.47 KB
master SendRequest netcoreapp3.1 145μs 301ns 1.16μs 0.217 0 0 17.27 KB
master SendRequest net472 0.00565ns 0.0018ns 0.00697ns 0 0 0 0 b
#6621 SendRequest net6.0 127μs 445ns 1.72μs 0.189 0 0 14.47 KB
#6621 SendRequest netcoreapp3.1 148μs 235ns 910ns 0.221 0 0 17.27 KB
#6621 SendRequest net472 0.00177ns 0.000779ns 0.00292ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 610μs 3.41μs 22.6μs 0.563 0 0 41.71 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 666μs 3.31μs 19.3μs 0.345 0 0 41.7 KB
master WriteAndFlushEnrichedTraces net472 851μs 4μs 15.5μs 8.5 2.55 0.425 53.28 KB
#6621 WriteAndFlushEnrichedTraces net6.0 588μs 3.23μs 19.4μs 0.566 0 0 41.71 KB
#6621 WriteAndFlushEnrichedTraces netcoreapp3.1 691μs 3.44μs 15μs 0.355 0 0 41.71 KB
#6621 WriteAndFlushEnrichedTraces net472 856μs 4.08μs 16.3μs 8.13 2.57 0.428 53.32 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.31μs 1.49ns 5.78ns 0.0143 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.76μs 4.44ns 17.2ns 0.0138 0 0 1.02 KB
master ExecuteNonQuery net472 2.11μs 1.47ns 5.5ns 0.157 0.00106 0 987 B
#6621 ExecuteNonQuery net6.0 1.29μs 1.05ns 3.8ns 0.0141 0 0 1.02 KB
#6621 ExecuteNonQuery netcoreapp3.1 1.71μs 2.08ns 8.06ns 0.0137 0 0 1.02 KB
#6621 ExecuteNonQuery net472 2μs 1.66ns 6.43ns 0.156 0.00101 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.19μs 0.962ns 3.6ns 0.0134 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.62μs 0.705ns 2.64ns 0.0129 0 0 976 B
master CallElasticsearch net472 2.55μs 1.94ns 7.5ns 0.158 0 0 995 B
master CallElasticsearchAsync net6.0 1.38μs 0.479ns 1.79ns 0.0131 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.71μs 1.01ns 3.92ns 0.0135 0 0 1.02 KB
master CallElasticsearchAsync net472 2.76μs 0.999ns 3.6ns 0.167 0 0 1.05 KB
#6621 CallElasticsearch net6.0 1.31μs 0.958ns 3.59ns 0.0138 0 0 976 B
#6621 CallElasticsearch netcoreapp3.1 1.58μs 0.554ns 2ns 0.0133 0 0 976 B
#6621 CallElasticsearch net472 2.58μs 1.42ns 5.3ns 0.157 0 0 995 B
#6621 CallElasticsearchAsync net6.0 1.27μs 0.895ns 3.35ns 0.0133 0 0 952 B
#6621 CallElasticsearchAsync netcoreapp3.1 1.7μs 0.346ns 1.29ns 0.0136 0 0 1.02 KB
#6621 CallElasticsearchAsync net472 2.66μs 1.8ns 6.96ns 0.166 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.31μs 0.63ns 2.36ns 0.0132 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.61μs 1.25ns 4.69ns 0.013 0 0 952 B
master ExecuteAsync net472 1.85μs 0.467ns 1.81ns 0.145 0 0 915 B
#6621 ExecuteAsync net6.0 1.38μs 1.7ns 6.59ns 0.0132 0 0 952 B
#6621 ExecuteAsync netcoreapp3.1 1.65μs 4.02ns 15.6ns 0.013 0 0 952 B
#6621 ExecuteAsync net472 1.81μs 0.311ns 1.16ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.34μs 1.56ns 6.03ns 0.0306 0 0 2.31 KB
master SendAsync netcoreapp3.1 5.28μs 2.71ns 10.1ns 0.037 0 0 2.85 KB
master SendAsync net472 7.56μs 1.72ns 6.67ns 0.493 0 0 3.12 KB
#6621 SendAsync net6.0 4.26μs 1.5ns 5.63ns 0.0316 0 0 2.31 KB
#6621 SendAsync netcoreapp3.1 5.38μs 2.75ns 10.7ns 0.0375 0 0 2.85 KB
#6621 SendAsync net472 7.41μs 1.74ns 6.75ns 0.493 0 0 3.12 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.54μs 0.816ns 3.16ns 0.0232 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.13μs 1.24ns 4.82ns 0.0215 0 0 1.64 KB
master EnrichedLog net472 2.59μs 0.922ns 3.57ns 0.25 0 0 1.57 KB
#6621 EnrichedLog net6.0 1.57μs 1.09ns 4.08ns 0.0225 0 0 1.64 KB
#6621 EnrichedLog netcoreapp3.1 2.18μs 8.06ns 31.2ns 0.0222 0 0 1.64 KB
#6621 EnrichedLog net472 2.64μs 0.969ns 3.75ns 0.249 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 112μs 66.8ns 250ns 0.0556 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 117μs 98.6ns 369ns 0 0 0 4.28 KB
master EnrichedLog net472 151μs 129ns 500ns 0.676 0.225 0 4.46 KB
#6621 EnrichedLog net6.0 112μs 105ns 363ns 0.0566 0 0 4.28 KB
#6621 EnrichedLog netcoreapp3.1 116μs 89.4ns 335ns 0 0 0 4.28 KB
#6621 EnrichedLog net472 149μs 131ns 507ns 0.674 0.225 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.02μs 1.22ns 4.23ns 0.0302 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.12μs 0.99ns 3.7ns 0.0289 0 0 2.2 KB
master EnrichedLog net472 4.93μs 0.559ns 1.94ns 0.32 0 0 2.02 KB
#6621 EnrichedLog net6.0 2.92μs 1.06ns 4.09ns 0.0307 0 0 2.2 KB
#6621 EnrichedLog netcoreapp3.1 4.22μs 1.07ns 4.01ns 0.0294 0 0 2.2 KB
#6621 EnrichedLog net472 4.75μs 0.575ns 2.15ns 0.321 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.39μs 0.736ns 2.85ns 0.0161 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.89μs 0.58ns 2.17ns 0.015 0 0 1.14 KB
master SendReceive net472 2.15μs 0.962ns 3.72ns 0.183 0 0 1.16 KB
#6621 SendReceive net6.0 1.35μs 1.05ns 3.92ns 0.0161 0 0 1.14 KB
#6621 SendReceive netcoreapp3.1 1.77μs 1.59ns 6.17ns 0.0152 0 0 1.14 KB
#6621 SendReceive net472 2.08μs 1.61ns 6.23ns 0.183 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.68μs 1.07ns 3.85ns 0.0215 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.97μs 6.71ns 26ns 0.0217 0 0 1.65 KB
master EnrichedLog net472 4.42μs 2.71ns 10.5ns 0.322 0 0 2.04 KB
#6621 EnrichedLog net6.0 2.83μs 1.24ns 4.79ns 0.0227 0 0 1.6 KB
#6621 EnrichedLog netcoreapp3.1 3.88μs 1.32ns 5.13ns 0.0213 0 0 1.65 KB
#6621 EnrichedLog net472 4.4μs 3.49ns 13.5ns 0.322 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6621

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 1.276 395.23 504.45

Faster 🎉 in #6621

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1 1.210 795.31 657.20
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net472 1.122 867.10 772.51

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 395ns 0.495ns 1.92ns 0.00804 0 0 576 B
master StartFinishSpan netcoreapp3.1 600ns 0.716ns 2.77ns 0.00779 0 0 576 B
master StartFinishSpan net472 664ns 0.883ns 3.3ns 0.0916 0 0 578 B
master StartFinishScope net6.0 528ns 0.806ns 3.12ns 0.00988 0 0 696 B
master StartFinishScope netcoreapp3.1 795ns 0.975ns 3.65ns 0.00913 0 0 696 B
master StartFinishScope net472 873ns 4.19ns 16.8ns 0.104 0 0 658 B
#6621 StartFinishSpan net6.0 504ns 0.504ns 1.95ns 0.00802 0 0 576 B
#6621 StartFinishSpan netcoreapp3.1 569ns 0.741ns 2.87ns 0.00785 0 0 576 B
#6621 StartFinishSpan net472 712ns 1.13ns 4.37ns 0.0917 0 0 578 B
#6621 StartFinishScope net6.0 559ns 0.851ns 3.3ns 0.00982 0 0 696 B
#6621 StartFinishScope netcoreapp3.1 656ns 1.16ns 4.51ns 0.00951 0 0 696 B
#6621 StartFinishScope net472 772ns 1.11ns 4.29ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 650ns 0.353ns 1.37ns 0.0098 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 924ns 0.793ns 3.07ns 0.00929 0 0 696 B
master RunOnMethodBegin net472 1.06μs 0.795ns 3.08ns 0.104 0 0 658 B
#6621 RunOnMethodBegin net6.0 650ns 0.599ns 2.32ns 0.00977 0 0 696 B
#6621 RunOnMethodBegin netcoreapp3.1 922ns 1.44ns 5.56ns 0.00922 0 0 696 B
#6621 RunOnMethodBegin net472 1.11μs 1.95ns 7.56ns 0.104 0 0 658 B

@link04 link04 merged commit 4e98576 into master Feb 11, 2025
139 of 142 checks passed
@link04 link04 deleted the maximo/sending-ci-vis-to-prod branch February 11, 2025 19:17
@github-actions github-actions bot added this to the vNext-v3 milestone Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bouwkast bouwkast bouwkast approved these changes

@andrewlock andrewlock andrewlock approved these changes

Assignees
No one assigned
Labels
area:builds project files, build scripts, pipelines, versioning, releases, packages
Projects
None yet
Milestone
3.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@link04 @andrewlock @bouwkast