[CI Visibility] Add Xunit.v3 support #6573

tonyredondo · 2025-01-17T16:37:40Z

Summary of changes

This PR adds support for xUnit.v3

Reason for change

We were missing the support for this new xUnit nuget package

Implementation details

It's a new integration that uses some of the existing xUnit integration code.

This PR also contains:

Add support for DuckTyping a ValueTask and ValueTask return type enabling the await keyword.
Add support for tests to run with dotnet exec

Test coverage

Two new test classes were added to test Evp Proxy, EFD and ATR.

Other details

andrewlock · 2025-01-28T00:50:43Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6573) - mean (79ms)  : 72, 86
     .   : milestone, 79,
    master - mean (69ms)  : 66, 72
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6573) - mean (1,028ms)  : 921, 1135
     .   : milestone, 1028,
    master - mean (990ms)  : 968, 1011
     .   : milestone, 990,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6573) - mean (103ms)  : 100, 105
     .   : milestone, 103,
    master - mean (102ms)  : 100, 105
     .   : milestone, 102,

    section CallTarget+Inlining+NGEN
    This PR (6573) - mean (674ms)  : 656, 692
     .   : milestone, 674,
    master - mean (675ms)  : 660, 691
     .   : milestone, 675,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6573) - mean (90ms)  : 88, 92
     .   : milestone, 90,
    master - mean (93ms)  : 83, 103
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (6573) - mean (635ms)  : 619, 650
     .   : milestone, 635,
    master - mean (632ms)  : 612, 651
     .   : milestone, 632,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6573) - mean (191ms)  : 186, 196
     .   : milestone, 191,
    master - mean (190ms)  : 187, 193
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6573) - mean (1,109ms)  : 1070, 1147
     .   : milestone, 1109,
    master - mean (1,100ms)  : 1068, 1131
     .   : milestone, 1100,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6573) - mean (271ms)  : 266, 277
     .   : milestone, 271,
    master - mean (269ms)  : 265, 273
     .   : milestone, 269,

    section CallTarget+Inlining+NGEN
    This PR (6573) - mean (863ms)  : 830, 897
     .   : milestone, 863,
    master - mean (861ms)  : 838, 884
     .   : milestone, 861,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6573) - mean (262ms)  : 258, 266
     .   : milestone, 262,
    master - mean (262ms)  : 257, 267
     .   : milestone, 262,

    section CallTarget+Inlining+NGEN
    This PR (6573) - mean (841ms)  : 801, 881
     .   : milestone, 841,
    master - mean (843ms)  : 811, 874
     .   : milestone, 843,

andrewlock · 2025-01-28T01:24:18Z

Benchmarks Report for tracer 🐌

Benchmarks for #6573 compared to master:

2 benchmarks are faster, with geometric mean 1.172
All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	7.68μs	41.9ns	268ns	0.0194	0.00776	0	5.61 KB
master	`StartStopWithChild`	netcoreapp3.1	9.89μs	54.7ns	350ns	0.0229	0.00918	0	5.8 KB
master	`StartStopWithChild`	net472	15.9μs	65.4ns	253ns	1.04	0.315	0.0945	6.21 KB
#6573	`StartStopWithChild`	net6.0	7.78μs	42.3ns	247ns	0.0154	0.00768	0	5.61 KB
#6573	`StartStopWithChild`	netcoreapp3.1	9.86μs	52.8ns	285ns	0.0188	0.00942	0	5.8 KB
#6573	`StartStopWithChild`	net472	15.9μs	34.8ns	135ns	1.04	0.309	0.103	6.21 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	488μs	382ns	1.43μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	646μs	415ns	1.55μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	877μs	2.4μs	9.28μs	0.431	3.3 KB
#6573	`WriteAndFlushEnrichedTraces`	net6.0	482μs	247ns	892ns	0	2.7 KB
#6573	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	668μs	353ns	1.37μs	0	2.7 KB
#6573	`WriteAndFlushEnrichedTraces`	net472	848μs	498ns	1.86μs	0.422	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	128μs	456ns	1.77μs	0.194	14.47 KB
master	`SendRequest`	netcoreapp3.1	144μs	412ns	1.59μs	0.211	17.28 KB
master	`SendRequest`	net472	0.0079ns	0.00219ns	0.00848ns	0	0 b
#6573	`SendRequest`	net6.0	129μs	567ns	2.19μs	0.196	14.47 KB
#6573	`SendRequest`	netcoreapp3.1	146μs	356ns	1.38μs	0.216	17.27 KB
#6573	`SendRequest`	net472	0.0118ns	0.00136ns	0.00528ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	548μs	1.08μs	3.74μs	0.571	0	0	41.51 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	686μs	3.78μs	24.2μs	0.326	0	0	41.75 KB
master	`WriteAndFlushEnrichedTraces`	net472	877μs	3.99μs	16μs	8.45	2.53	0.422	53.34 KB
#6573	`WriteAndFlushEnrichedTraces`	net6.0	568μs	3.18μs	20.9μs	0.576	0	0	41.69 KB
#6573	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	693μs	3.95μs	27.6μs	0.34	0	0	41.84 KB
#6573	`WriteAndFlushEnrichedTraces`	net472	847μs	4.2μs	17.3μs	8.69	2.48	0.414	53.29 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteNonQuery`	net6.0	1.27μs	1.07ns	4.01ns	0.0147	0	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.73μs	1.88ns	7.3ns	0.0139	0	1.02 KB
master	`ExecuteNonQuery`	net472	2.02μs	2.72ns	10.5ns	0.156	0.00101	987 B
#6573	`ExecuteNonQuery`	net6.0	1.28μs	0.924ns	3.46ns	0.014	0	1.02 KB
#6573	`ExecuteNonQuery`	netcoreapp3.1	1.78μs	1.41ns	5.28ns	0.0133	0	1.02 KB
#6573	`ExecuteNonQuery`	net472	2.02μs	1.5ns	5.81ns	0.157	0.001	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.26μs	0.565ns	2.19ns	0.0134	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.52μs	0.813ns	3.04ns	0.0131	976 B
master	`CallElasticsearch`	net472	2.62μs	1.73ns	6.7ns	0.158	995 B
master	`CallElasticsearchAsync`	net6.0	1.32μs	0.428ns	1.66ns	0.0132	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.69μs	1.12ns	4.2ns	0.0136	1.02 KB
master	`CallElasticsearchAsync`	net472	2.61μs	2.39ns	9.25ns	0.167	1.05 KB
#6573	`CallElasticsearch`	net6.0	1.22μs	0.346ns	1.29ns	0.014	976 B
#6573	`CallElasticsearch`	netcoreapp3.1	1.51μs	1.77ns	6.84ns	0.0129	976 B
#6573	`CallElasticsearch`	net472	2.67μs	1.56ns	6.05ns	0.157	995 B
#6573	`CallElasticsearchAsync`	net6.0	1.37μs	2.45ns	9.49ns	0.0131	952 B
#6573	`CallElasticsearchAsync`	netcoreapp3.1	1.63μs	0.922ns	3.45ns	0.0138	1.02 KB
#6573	`CallElasticsearchAsync`	net472	2.65μs	1.33ns	4.98ns	0.166	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6573

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net6.0	1.208	1,519.19	1,258.01

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.52μs	0.958ns	3.71ns	0.013	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.6μs	0.69ns	2.67ns	0.0128	952 B
master	`ExecuteAsync`	net472	1.83μs	0.234ns	0.874ns	0.145	915 B
#6573	`ExecuteAsync`	net6.0	1.26μs	0.453ns	1.7ns	0.0132	952 B
#6573	`ExecuteAsync`	netcoreapp3.1	1.65μs	0.611ns	2.2ns	0.0124	952 B
#6573	`ExecuteAsync`	net472	1.83μs	0.631ns	2.44ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.38μs	1.72ns	6.19ns	0.0327	2.31 KB
master	`SendAsync`	netcoreapp3.1	5.36μs	2.67ns	10.3ns	0.0376	2.85 KB
master	`SendAsync`	net472	7.44μs	4.13ns	15.4ns	0.492	3.12 KB
#6573	`SendAsync`	net6.0	4.49μs	2.07ns	8.03ns	0.0315	2.31 KB
#6573	`SendAsync`	netcoreapp3.1	5.24μs	2.2ns	8.24ns	0.0395	2.85 KB
#6573	`SendAsync`	net472	7.41μs	3.1ns	12ns	0.496	3.12 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.54μs	0.859ns	3.1ns	0.0231	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.15μs	0.703ns	2.43ns	0.0226	1.64 KB
master	`EnrichedLog`	net472	2.48μs	0.699ns	2.62ns	0.249	1.57 KB
#6573	`EnrichedLog`	net6.0	1.63μs	0.867ns	3.24ns	0.0231	1.64 KB
#6573	`EnrichedLog`	netcoreapp3.1	2.19μs	1.96ns	7.08ns	0.0221	1.64 KB
#6573	`EnrichedLog`	net472	2.57μs	1.7ns	6.57ns	0.248	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	111μs	127ns	491ns	0.0556	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	116μs	103ns	384ns	0.058	0	4.28 KB
master	`EnrichedLog`	net472	151μs	373ns	1.44μs	0.681	0.227	4.46 KB
#6573	`EnrichedLog`	net6.0	113μs	87.8ns	304ns	0.0562	0	4.28 KB
#6573	`EnrichedLog`	netcoreapp3.1	116μs	136ns	528ns	0.0578	0	4.28 KB
#6573	`EnrichedLog`	net472	150μs	104ns	389ns	0.678	0.226	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.12μs	3.28ns	12.3ns	0.0305	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.25μs	1.31ns	5.07ns	0.0298	2.2 KB
master	`EnrichedLog`	net472	4.94μs	1.45ns	5.62ns	0.319	2.02 KB
#6573	`EnrichedLog`	net6.0	3μs	0.772ns	2.99ns	0.03	2.2 KB
#6573	`EnrichedLog`	netcoreapp3.1	4.16μs	1.66ns	6.21ns	0.0292	2.2 KB
#6573	`EnrichedLog`	net472	5.02μs	1.61ns	6.24ns	0.321	2.02 KB

Benchmarks.Trace.RedisBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6573

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.RedisBenchmark.SendReceive‑net6.0	1.138	1,452.72	1,277.01

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.45μs	1.79ns	6.95ns	0.0157	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.75μs	0.79ns	3.06ns	0.0154	1.14 KB
master	`SendReceive`	net472	2.13μs	1.68ns	6.52ns	0.184	1.16 KB
#6573	`SendReceive`	net6.0	1.28μs	1ns	3.89ns	0.016	1.14 KB
#6573	`SendReceive`	netcoreapp3.1	1.78μs	0.816ns	3.05ns	0.0151	1.14 KB
#6573	`SendReceive`	net472	2.05μs	2.39ns	9.25ns	0.183	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.68μs	0.678ns	2.63ns	0.0214	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.74μs	7.02ns	27.2ns	0.0224	1.65 KB
master	`EnrichedLog`	net472	4.48μs	2.52ns	9.74ns	0.323	2.04 KB
#6573	`EnrichedLog`	net6.0	2.73μs	1.5ns	5.82ns	0.0219	1.6 KB
#6573	`EnrichedLog`	netcoreapp3.1	3.95μs	1.53ns	5.92ns	0.0217	1.65 KB
#6573	`EnrichedLog`	net472	4.43μs	4.14ns	16ns	0.323	2.04 KB

Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	447ns	0.765ns	2.96ns	0.00807	576 B
master	`StartFinishSpan`	netcoreapp3.1	565ns	0.832ns	3.11ns	0.0078	576 B
master	`StartFinishSpan`	net472	625ns	1.81ns	7ns	0.0918	578 B
master	`StartFinishScope`	net6.0	489ns	0.715ns	2.77ns	0.00968	696 B
master	`StartFinishScope`	netcoreapp3.1	688ns	1.65ns	6.4ns	0.00937	696 B
master	`StartFinishScope`	net472	751ns	1.82ns	6.8ns	0.105	658 B
#6573	`StartFinishSpan`	net6.0	470ns	0.62ns	2.4ns	0.00804	576 B
#6573	`StartFinishSpan`	netcoreapp3.1	579ns	0.83ns	3.21ns	0.00783	576 B
#6573	`StartFinishSpan`	net472	651ns	0.377ns	1.41ns	0.0916	578 B
#6573	`StartFinishScope`	net6.0	497ns	0.864ns	3.35ns	0.00974	696 B
#6573	`StartFinishScope`	netcoreapp3.1	748ns	0.847ns	3.28ns	0.00937	696 B
#6573	`StartFinishScope`	net472	801ns	0.438ns	1.64ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	645ns	1.11ns	4.3ns	0.00974	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	914ns	1.54ns	5.95ns	0.00914	696 B
master	`RunOnMethodBegin`	net472	1.08μs	2.66ns	10.3ns	0.104	658 B
#6573	`RunOnMethodBegin`	net6.0	646ns	0.392ns	1.52ns	0.00972	696 B
#6573	`RunOnMethodBegin`	netcoreapp3.1	960ns	0.446ns	1.67ns	0.00911	696 B
#6573	`RunOnMethodBegin`	net472	1.07μs	0.543ns	2.1ns	0.104	658 B

tracer/src/Datadog.Trace/Ci/CIVisibility.cs

tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/Testing/XUnit/ITestCase.cs

tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/Testing/XUnit/RetryMessageBus.cs

...c/Datadog.Trace/ClrProfiler/AutoInstrumentation/Testing/XUnit/V3/AssemblyMetadataStructV3.cs

tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/Testing/XUnit/V3/IXunitTestCaseV3.cs

...ofiler/AutoInstrumentation/Testing/XUnit/V3/XunitTestMethodRunnerContextCtorV3Integration.cs

andrewlock · 2025-02-05T11:31:02Z

tracer/src/Datadog.Trace/DuckTyping/IDuckTypeTask.cs

+/// Duck type task interface
+/// </summary>
+/// <typeparam name="T">Type of the result</typeparam>
+public interface IDuckTypeTask<out T> : IDuckType


This seems like it is pretty much a direct overlap with #6480... I feel like we should maybe try to unify those with these at least? 🤔 Not in this PR, just a thought.

Yes we need to do that in a different PR

tracer/src/Datadog.Tracer.Native/cor_profiler.cpp

andrewlock · 2025-02-05T11:37:11Z

tracer/test/Datadog.Trace.ClrProfiler.IntegrationTests/CI/XUnitEvpTestsV3.cs

+
+#if NET6_0_OR_GREATER
+[UsesVerify]
+public class XUnitEvpTestsV3 : TestingFrameworkEvpTest


I'm guessing there's a lot of duplication here with the xunit tests, right? Rather than duplicate 500 lines of test code, can we derive one from the other or something? FWIW, it feels like a huge number of the asserts are essentially already covered by the snapshots, no? 🤔

True, I'll work on that in a different PR, because it doesn't affect only xUnit v3 support. It will need a complete refactor of the tests.

tracer/test/Datadog.Trace.TestHelpers.AutoInstrumentation/TestHelper.cs

andrewlock · 2025-02-10T11:57:27Z

.../ClrProfiler/AutoInstrumentation/Testing/XUnit/V3/XUnitTestAssemblyRunnerRunV3Integration.cs

@@ -43,7 +43,7 @@ internal static CallTargetState OnMethodBegin<TTarget, TContext>(TTarget instanc
            var testBundleString = new AssemblyName(assemblyName).Name ?? string.Empty;

            // Extract the version of the framework from the TestClassRunner base class
-            var frameworkType = instance.GetType();
+            var frameworkType = instance!.GetType();


Haha, I guess this is a consequence of me suggesting removing the instance check 😅 can probably fix it with it a where TTarget : notnull, but whether we want/should do that is a different question 😅 ~~I still think you should have a context.Instance is null check, but I don't know...~~ Sorry, you did in the next commit!

bouwkast

👍

Looks like v1.1.0 came out a few days ago, but I think this should be fine, not seeing anything in it.

bouwkast · 2025-02-10T14:11:47Z

tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/Testing/XUnit/V3/CustomTestCase.cs

+
+    public ref TReturn? GetInternalDuckTypedInstance<TReturn>()
+    {
+        throw new NotImplementedException();


Just wondering if this is intentional

tonyredondo added 2 commits January 17, 2025 16:46

Initial structure to support XUnit3

c4469c7

Add support for TestModule reporting.

dac90b1

tonyredondo added the status:work-in-progress Actively worked on. If this is a PR, no review needed yet. WIP. label Jan 17, 2025

tonyredondo self-assigned this Jan 17, 2025

github-actions bot added the area:ci-visibility label Jan 17, 2025

tonyredondo added 17 commits January 20, 2025 10:12

Add support for TestSuite reporting

057c175

Add support for reporting Tests

5160ced

Refactor

e288d20

changes

ea0eacf

changes

cc6c9b8

Add support for Ducktyping Async/Await methods

8d1c594

Fixes

d1877e8

fixes and new test suite

fa37edf

Start to create the custom retrymessagebus for v3

5624ab5

Changes

48fb37e

Changes

1c9a521

fix

09ccf08

retries test

6c095b3

Fixes

442c943

Integration registration

4ae926a

Merge branch 'master' into tony/civisibility-xunit3-support

d0e9cfc

add missing nullable

2aff0f8

tonyredondo removed the status:work-in-progress Actively worked on. If this is a PR, no review needed yet. WIP. label Jan 24, 2025

tonyredondo marked this pull request as ready for review January 24, 2025 15:08

tonyredondo requested review from a team as code owners January 24, 2025 15:08

tonyredondo added 2 commits January 24, 2025 16:18

Missing solution change

d4d3e7c

fixes

694457e

fixes

5b2805c

DataDog deleted a comment from datadog-ddstaging bot Jan 24, 2025

DataDog deleted a comment from andrewlock Jan 24, 2025

DataDog deleted a comment from datadog-ddstaging bot Jan 24, 2025

tonyredondo added 5 commits January 26, 2025 23:54

changes

71829a9

changes

90a5bfa

Fix tests

56fe8e5

Fix

8aa7189

Fix snapshots

81a7081

DataDog deleted a comment from andrewlock Jan 28, 2025

andrewlock approved these changes Feb 5, 2025

View reviewed changes

tonyredondo added 3 commits February 10, 2025 11:31

Changes from the review

0bb1ed8

Changes from review

c5f706f

Merge branch 'master' into tony/civisibility-xunit3-support

ae71133

andrewlock reviewed Feb 10, 2025

View reviewed changes

bouwkast approved these changes Feb 10, 2025

View reviewed changes

tonyredondo merged commit 50a95c5 into master Feb 10, 2025
140 of 144 checks passed

tonyredondo deleted the tony/civisibility-xunit3-support branch February 10, 2025 15:03

github-actions bot added this to the vNext-v3 milestone Feb 10, 2025

andrewlock added type:new-feature area:automatic-instrumentation Automatic instrumentation managed C# code (Datadog.Trace.ClrProfiler.Managed) area:integrations labels Feb 11, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CI Visibility] Add Xunit.v3 support #6573

[CI Visibility] Add Xunit.v3 support #6573

tonyredondo commented Jan 17, 2025 •

edited

Loading

andrewlock commented Jan 28, 2025 •

edited

Loading

andrewlock commented Jan 28, 2025 •

edited

Loading

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #6573

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #6573

Raw results

Raw results

Raw results

Raw results

andrewlock Feb 5, 2025

tonyredondo Feb 10, 2025

andrewlock Feb 5, 2025

tonyredondo Feb 10, 2025

andrewlock Feb 10, 2025 •

edited

Loading

bouwkast left a comment

bouwkast Feb 10, 2025

[CI Visibility] Add Xunit.v3 support #6573

[CI Visibility] Add Xunit.v3 support #6573

Conversation

tonyredondo commented Jan 17, 2025 • edited Loading

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

andrewlock commented Jan 28, 2025 • edited Loading

Execution-Time Benchmarks Report ⏱️

andrewlock commented Jan 28, 2025 • edited Loading

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #6573

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #6573

Raw results

Raw results

Raw results

Raw results

andrewlock Feb 5, 2025

Choose a reason for hiding this comment

tonyredondo Feb 10, 2025

Choose a reason for hiding this comment

andrewlock Feb 5, 2025

Choose a reason for hiding this comment

tonyredondo Feb 10, 2025

Choose a reason for hiding this comment

andrewlock Feb 10, 2025 • edited Loading

Choose a reason for hiding this comment

bouwkast left a comment

Choose a reason for hiding this comment

bouwkast Feb 10, 2025

Choose a reason for hiding this comment

tonyredondo commented Jan 17, 2025 •

edited

Loading

andrewlock commented Jan 28, 2025 •

edited

Loading

andrewlock commented Jan 28, 2025 •

edited

Loading

andrewlock Feb 10, 2025 •

edited

Loading