[Dynamic Instrumentation] DEBUG-3223 SymDB compression fix

[dudikeleti]

Summary of changes

This PR fix an error that occur when we send compressed symbols.
Since I use a using declaration (which extend the idisposable object scope) I have to call Flush manually before I use the underline stream.

Future work will be to do the upload in an efficient way by reducing allocation .

[andrewlock]

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

• This PR (6556)
• master

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

• Welch test with statistical test for significance of 5%
• Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6556) - mean (69ms)  : 66, 72
     .   : milestone, 69,
    master - mean (69ms)  : 66, 72
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6556) - mean (979ms)  : 960, 998
     .   : milestone, 979,
    master - mean (981ms)  : 959, 1004
     .   : milestone, 981,

Loading

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6556) - mean (107ms)  : 105, 109
     .   : milestone, 107,
    master - mean (108ms)  : 106, 110
     .   : milestone, 108,

    section CallTarget+Inlining+NGEN
    This PR (6556) - mean (680ms)  : 665, 695
     .   : milestone, 680,
    master - mean (680ms)  : 662, 698
     .   : milestone, 680,

Loading

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6556) - mean (91ms)  : 89, 93
     .   : milestone, 91,
    master - mean (91ms)  : 89, 93
     .   : milestone, 91,

    section CallTarget+Inlining+NGEN
    This PR (6556) - mean (632ms)  : 614, 651
     .   : milestone, 632,
    master - mean (637ms)  : 617, 657
     .   : milestone, 637,

Loading

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6556) - mean (190ms)  : 187, 193
     .   : milestone, 190,
    master - mean (190ms)  : 186, 194
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6556) - mean (1,092ms)  : 1065, 1119
     .   : milestone, 1092,
    master - mean (1,091ms)  : 1062, 1119
     .   : milestone, 1091,

Loading

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6556) - mean (275ms)  : 269, 280
     .   : milestone, 275,
    master - mean (276ms)  : 271, 280
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (6556) - mean (867ms)  : 838, 897
     .   : milestone, 867,
    master - mean (865ms)  : 838, 892
     .   : milestone, 865,

Loading

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6556) - mean (264ms)  : 259, 269
     .   : milestone, 264,
    master - mean (263ms)  : 259, 267
     .   : milestone, 263,

    section CallTarget+Inlining+NGEN
    This PR (6556) - mean (849ms)  : 814, 884
     .   : milestone, 849,
    master - mean (844ms)  : 813, 875
     .   : milestone, 844,

Loading

[datadog-ddstaging]

Datadog Report

Branch report: dudik/fix-symbd-gzip
Commit report: d839af3
Test service: dd-trace-dotnet

✅ 0 Failed, 252813 Passed, 2847 Skipped, 32h 24m 39.47s Total Time

[vandonr]

nit: since those 2 lines are the same code, albeit on a different type, they could be outside the #if/else

[GreenMatan]

LGTM