Update dotnet-install scripts for impending change of .NET install domains #6484

andrewlock · 2024-12-24T13:22:21Z

Summary of changes

Updates the dotnet-install.sh and dotnet-install.ps scripts following advice in dotnet/announcements#336

Reason for change

From the linked announcement:

Some .NET binaries and installers are hosted on Azure Content Delivery Network (CDN) domains that end in .azureedge.net. These domains are hosted by edg.io, which will soon cease operations due to bankruptcy. We are required to migrate to a new CDN and will be using new domains going forward. It is possible that .azureedge.net domains will have downtime or become permanently unavailable.

Implementation details

Update the scripts with the versions provided in the initial announcements. These scripts aren't "final", and we don't need to merge them yet (and we will need to update the VMs when we do), so for now this is a "break glass if things stop working" scenario. Not that the powershell script isn't signed, so we should definitely wait for that too if we can.

Test coverage

This PR is the test - as long as it builds ok, we're good

Other details

I haven't really looked through the changes. They're mostly superficial, other than preferring the new CDN domain and using a fallback

datadog-ddstaging · 2024-12-24T13:54:19Z

Datadog Report

Branch report: andrew/ci/prepare-fix-for-changing-dotnet-install-script
Commit report: 7802743
Test service: dd-trace-dotnet

✅ 0 Failed, 246258 Passed, 1985 Skipped, 18h 58m 49.09s Total Time

andrewlock · 2024-12-24T13:56:04Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6484) - mean (69ms)  : 65, 74
     .   : milestone, 69,
    master - mean (69ms)  : 65, 74
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6484) - mean (978ms)  : 957, 999
     .   : milestone, 978,
    master - mean (981ms)  : 959, 1003
     .   : milestone, 981,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6484) - mean (107ms)  : 105, 110
     .   : milestone, 107,
    master - mean (108ms)  : 106, 111
     .   : milestone, 108,

    section CallTarget+Inlining+NGEN
    This PR (6484) - mean (675ms)  : 658, 692
     .   : milestone, 675,
    master - mean (676ms)  : 660, 691
     .   : milestone, 676,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6484) - mean (91ms)  : 89, 93
     .   : milestone, 91,
    master - mean (91ms)  : 89, 93
     .   : milestone, 91,

    section CallTarget+Inlining+NGEN
    This PR (6484) - mean (629ms)  : 610, 648
     .   : milestone, 629,
    master - mean (637ms)  : 614, 660
     .   : milestone, 637,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6484) - mean (190ms)  : 186, 194
     .   : milestone, 190,
    master - mean (190ms)  : 185, 195
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6484) - mean (1,088ms)  : 1056, 1121
     .   : milestone, 1088,
    master - mean (1,087ms)  : 1064, 1110
     .   : milestone, 1087,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6484) - mean (275ms)  : 271, 280
     .   : milestone, 275,
    master - mean (276ms)  : 272, 281
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (6484) - mean (864ms)  : 827, 901
     .   : milestone, 864,
    master - mean (865ms)  : 832, 897
     .   : milestone, 865,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6484) - mean (264ms)  : 261, 268
     .   : milestone, 264,
    master - mean (264ms)  : 260, 268
     .   : milestone, 264,

    section CallTarget+Inlining+NGEN
    This PR (6484) - mean (842ms)  : 809, 876
     .   : milestone, 842,
    master - mean (846ms)  : 807, 885
     .   : milestone, 846,

andrewlock · 2024-12-24T15:00:52Z

Benchmarks Report for tracer 🐌

Benchmarks for #6484 compared to master:

1 benchmarks are faster, with geometric mean 1.127
1 benchmarks have fewer allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	7.83μs	39ns	187ns	0.0196	0.00786	0	5.61 KB
master	`StartStopWithChild`	netcoreapp3.1	10.1μs	55.7ns	334ns	0.0197	0.00987	0	5.8 KB
master	`StartStopWithChild`	net472	16.2μs	52.6ns	204ns	1.04	0.3	0.0892	6.2 KB
#6484	`StartStopWithChild`	net6.0	7.83μs	42.3ns	284ns	0.0184	0.00736	0	5.61 KB
#6484	`StartStopWithChild`	netcoreapp3.1	10μs	47.9ns	230ns	0.0205	0.0102	0	5.8 KB
#6484	`StartStopWithChild`	net472	15.9μs	62.1ns	241ns	1.04	0.311	0.0957	6.21 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	479μs	351ns	1.36μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	647μs	573ns	2.06μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	851μs	536ns	2μs	0.422	3.3 KB
#6484	`WriteAndFlushEnrichedTraces`	net6.0	480μs	195ns	754ns	0	2.7 KB
#6484	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	664μs	596ns	2.31μs	0	2.7 KB
#6484	`WriteAndFlushEnrichedTraces`	net472	852μs	754ns	2.92μs	0.425	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	126μs	545ns	2.11μs	0.191	14.47 KB
master	`SendRequest`	netcoreapp3.1	148μs	271ns	1.05μs	0.22	17.27 KB
master	`SendRequest`	net472	0.00712ns	0.00251ns	0.00973ns	0	0 b
#6484	`SendRequest`	net6.0	131μs	474ns	1.84μs	0.195	14.47 KB
#6484	`SendRequest`	netcoreapp3.1	149μs	159ns	596ns	0.221	17.27 KB
#6484	`SendRequest`	net472	0.00156ns	0.000468ns	0.00181ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #6484

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1	41.93 KB	41.68 KB	-253 B	-0.60%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	561μs	2.09μs	7.52μs	0.553	0	0	41.65 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	642μs	2.71μs	9.4μs	0.316	0	0	41.93 KB
master	`WriteAndFlushEnrichedTraces`	net472	850μs	4.05μs	16.2μs	8.75	2.5	0.417	53.29 KB
#6484	`WriteAndFlushEnrichedTraces`	net6.0	564μs	2.32μs	8.69μs	0.566	0	0	41.71 KB
#6484	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	654μs	3.43μs	16.8μs	0.316	0	0	41.68 KB
#6484	`WriteAndFlushEnrichedTraces`	net472	826μs	3.95μs	16.3μs	8.17	2.45	0.408	53.28 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteNonQuery`	net6.0	1.41μs	1.09ns	4.06ns	0.0141	0	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.75μs	2.09ns	8.09ns	0.0133	0	1.02 KB
master	`ExecuteNonQuery`	net472	2.06μs	1.33ns	4.79ns	0.157	0.00103	987 B
#6484	`ExecuteNonQuery`	net6.0	1.3μs	1.11ns	4.32ns	0.0142	0	1.02 KB
#6484	`ExecuteNonQuery`	netcoreapp3.1	1.8μs	1.58ns	6.13ns	0.0136	0	1.02 KB
#6484	`ExecuteNonQuery`	net472	2.02μs	0.866ns	3.12ns	0.156	0.00102	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.26μs	0.439ns	1.64ns	0.0137	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.58μs	0.575ns	2.15ns	0.0134	976 B
master	`CallElasticsearch`	net472	2.53μs	2.12ns	8.21ns	0.158	995 B
master	`CallElasticsearchAsync`	net6.0	1.3μs	1.08ns	4.06ns	0.0129	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.63μs	0.803ns	2.9ns	0.0139	1.02 KB
master	`CallElasticsearchAsync`	net472	2.69μs	1.68ns	6.28ns	0.166	1.05 KB
#6484	`CallElasticsearch`	net6.0	1.34μs	0.49ns	1.83ns	0.0136	976 B
#6484	`CallElasticsearch`	netcoreapp3.1	1.55μs	0.371ns	1.39ns	0.013	976 B
#6484	`CallElasticsearch`	net472	2.57μs	1.25ns	4.5ns	0.158	995 B
#6484	`CallElasticsearchAsync`	net6.0	1.3μs	0.897ns	3.36ns	0.0135	952 B
#6484	`CallElasticsearchAsync`	netcoreapp3.1	1.64μs	0.524ns	1.96ns	0.0139	1.02 KB
#6484	`CallElasticsearchAsync`	net472	2.59μs	1.03ns	3.85ns	0.166	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.26μs	0.358ns	1.34ns	0.0132	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.6μs	1.32ns	4.75ns	0.0125	952 B
master	`ExecuteAsync`	net472	1.85μs	0.627ns	2.43ns	0.145	915 B
#6484	`ExecuteAsync`	net6.0	1.28μs	0.549ns	2.05ns	0.0134	952 B
#6484	`ExecuteAsync`	netcoreapp3.1	1.64μs	1.74ns	6.72ns	0.0128	952 B
#6484	`ExecuteAsync`	net472	1.81μs	0.512ns	1.98ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.47μs	3.19ns	11.9ns	0.0315	2.31 KB
master	`SendAsync`	netcoreapp3.1	5.33μs	2.35ns	8.81ns	0.0372	2.85 KB
master	`SendAsync`	net472	7.38μs	1.72ns	6.65ns	0.494	3.12 KB
#6484	`SendAsync`	net6.0	4.44μs	0.885ns	3.43ns	0.031	2.31 KB
#6484	`SendAsync`	netcoreapp3.1	5.2μs	1.68ns	6.05ns	0.039	2.85 KB
#6484	`SendAsync`	net472	7.35μs	1.14ns	4.27ns	0.494	3.12 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.59μs	4.65ns	20.3ns	0.0225	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.25μs	1.52ns	5.48ns	0.0224	1.64 KB
master	`EnrichedLog`	net472	2.57μs	0.582ns	2.25ns	0.249	1.57 KB
#6484	`EnrichedLog`	net6.0	1.5μs	0.727ns	2.72ns	0.0233	1.64 KB
#6484	`EnrichedLog`	netcoreapp3.1	2.28μs	0.892ns	3.34ns	0.0226	1.64 KB
#6484	`EnrichedLog`	net472	2.57μs	1.51ns	5.66ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	115μs	121ns	451ns	0.0582	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	120μs	160ns	619ns	0.0595	0	4.28 KB
master	`EnrichedLog`	net472	150μs	154ns	596ns	0.673	0.224	4.46 KB
#6484	`EnrichedLog`	net6.0	115μs	112ns	433ns	0.0572	0	4.28 KB
#6484	`EnrichedLog`	netcoreapp3.1	119μs	119ns	460ns	0	0	4.28 KB
#6484	`EnrichedLog`	net472	150μs	183ns	685ns	0.669	0.223	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.03μs	1.22ns	4.74ns	0.0302	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.42μs	1.58ns	6.13ns	0.0287	2.2 KB
master	`EnrichedLog`	net472	4.9μs	0.929ns	3.48ns	0.32	2.02 KB
#6484	`EnrichedLog`	net6.0	2.91μs	0.752ns	2.81ns	0.0306	2.2 KB
#6484	`EnrichedLog`	netcoreapp3.1	4.13μs	1.24ns	4.46ns	0.0291	2.2 KB
#6484	`EnrichedLog`	net472	4.89μs	1.77ns	6.85ns	0.319	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.41μs	1.19ns	4.62ns	0.0156	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.89μs	1.2ns	4.66ns	0.0151	1.14 KB
master	`SendReceive`	net472	2.06μs	0.794ns	2.97ns	0.183	1.16 KB
#6484	`SendReceive`	net6.0	1.44μs	0.663ns	2.57ns	0.0158	1.14 KB
#6484	`SendReceive`	netcoreapp3.1	1.84μs	0.705ns	2.73ns	0.0156	1.14 KB
#6484	`SendReceive`	net472	1.99μs	1.04ns	4.02ns	0.183	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.73μs	0.972ns	3.64ns	0.0218	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	4.15μs	4.34ns	16.8ns	0.0209	1.65 KB
master	`EnrichedLog`	net472	4.49μs	3.63ns	14.1ns	0.323	2.04 KB
#6484	`EnrichedLog`	net6.0	2.69μs	0.971ns	3.76ns	0.0216	1.6 KB
#6484	`EnrichedLog`	netcoreapp3.1	3.88μs	1.33ns	5.16ns	0.0215	1.65 KB
#6484	`EnrichedLog`	net472	4.35μs	2.56ns	9.59ns	0.323	2.04 KB

Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	405ns	0.555ns	2.15ns	0.00799	576 B
master	`StartFinishSpan`	netcoreapp3.1	613ns	0.888ns	3.44ns	0.00781	576 B
master	`StartFinishSpan`	net472	621ns	1.12ns	4.35ns	0.0916	578 B
master	`StartFinishScope`	net6.0	566ns	0.962ns	3.73ns	0.00983	696 B
master	`StartFinishScope`	netcoreapp3.1	777ns	0.71ns	2.75ns	0.00915	696 B
master	`StartFinishScope`	net472	783ns	1.16ns	4.51ns	0.104	658 B
#6484	`StartFinishSpan`	net6.0	403ns	0.727ns	2.82ns	0.00816	576 B
#6484	`StartFinishSpan`	netcoreapp3.1	593ns	1.03ns	4.01ns	0.00765	576 B
#6484	`StartFinishSpan`	net472	641ns	1.05ns	4.07ns	0.0918	578 B
#6484	`StartFinishScope`	net6.0	542ns	0.788ns	3.05ns	0.00963	696 B
#6484	`StartFinishScope`	netcoreapp3.1	721ns	3.87ns	21.2ns	0.00931	696 B
#6484	`StartFinishScope`	net472	803ns	1.03ns	3.98ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6484

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0	1.127	720.25	639.34

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	720ns	0.761ns	2.95ns	0.00962	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	919ns	1.42ns	5.5ns	0.00946	696 B
master	`RunOnMethodBegin`	net472	1.16μs	1.17ns	4.53ns	0.104	658 B
#6484	`RunOnMethodBegin`	net6.0	639ns	1.29ns	5ns	0.00958	696 B
#6484	`RunOnMethodBegin`	netcoreapp3.1	876ns	1.51ns	5.87ns	0.00911	696 B
#6484	`RunOnMethodBegin`	net472	1.11μs	1.52ns	5.9ns	0.104	658 B

andrewlock · 2025-01-23T05:37:59Z

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6484) (11.049M)   : 0, 11048674
    master (11.135M)   : 0, 11135145
    benchmarks/2.9.0 (11.045M)   : 0, 11045405

    section Automatic
    This PR (6484) (7.183M)   : 0, 7182845
    master (7.298M)   : 0, 7297948
    benchmarks/2.9.0 (7.885M)   : 0, 7885346

    section Trace stats
    master (7.586M)   : 0, 7586055

    section Manual
    master (11.227M)   : 0, 11227312

    section Manual + Automatic
    This PR (6484) (6.706M)   : 0, 6705642
    master (6.788M)   : 0, 6787941

    section DD_TRACE_ENABLED=0
    master (10.406M)   : 0, 10406339

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6484) (9.762M)   : 0, 9762101
    master (9.672M)   : 0, 9671914
    benchmarks/2.9.0 (9.586M)   : 0, 9586476

    section Automatic
    This PR (6484) (6.337M)   : 0, 6336975
    master (6.522M)   : 0, 6522061

    section Trace stats
    master (6.683M)   : 0, 6683263

    section Manual
    master (9.606M)   : 0, 9606045

    section Manual + Automatic
    This PR (6484) (5.999M)   : 0, 5998661
    master (6.103M)   : 0, 6102558

    section DD_TRACE_ENABLED=0
    master (8.863M)   : 0, 8862691

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6484) (9.898M)   : 0, 9898174

    section Automatic
    This PR (6484) (6.447M)   : 0, 6447099

    section Manual + Automatic
    This PR (6484) (6.147M)   : 0, 6146965

datadog-ddstaging · 2025-01-30T18:06:48Z

Datadog Report

Branch report: andrew/ci/prepare-fix-for-changing-dotnet-install-script
Commit report: f9b4bac
Test service: dd-trace-dotnet

✅ 0 Failed, 247133 Passed, 2129 Skipped, 19h 10m 14.92s Total Time

andrewlock added area:builds project files, build scripts, pipelines, versioning, releases, packages status:do-not-merge Work is done. Can review, but do not merge yet. labels Dec 24, 2024

andrewlock requested a review from a team as a code owner December 24, 2024 13:22

kevingosse approved these changes Jan 2, 2025

View reviewed changes

lucaspimentel approved these changes Jan 6, 2025

View reviewed changes

lucaspimentel mentioned this pull request Jan 17, 2025

Point to the new domains / URLs from Microsoft in dotnet-install #6574

Closed

andrewlock force-pushed the andrew/ci/prepare-fix-for-changing-dotnet-install-script branch 3 times, most recently from fd4fc30 to 7802743 Compare January 22, 2025 18:51

andrewlock added 2 commits January 30, 2025 17:33

Update dotnet-install scripts

8de5efc

Update to latest

f9b4bac

andrewlock force-pushed the andrew/ci/prepare-fix-for-changing-dotnet-install-script branch from 7802743 to f9b4bac Compare January 30, 2025 17:35

andrewlock merged commit 014beb5 into master Jan 31, 2025
133 of 137 checks passed

andrewlock deleted the andrew/ci/prepare-fix-for-changing-dotnet-install-script branch January 31, 2025 07:09

github-actions bot added this to the vNext-v3 milestone Jan 31, 2025

andrewlock mentioned this pull request Jan 31, 2025

Move the Nuke arguments into the gitlab file #6611

Merged

andrewlock removed the status:do-not-merge Work is done. Can review, but do not merge yet. label Feb 11, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update dotnet-install scripts for impending change of .NET install domains #6484

Update dotnet-install scripts for impending change of .NET install domains #6484

andrewlock commented Dec 24, 2024

datadog-ddstaging bot commented Dec 24, 2024 •

edited

Loading

andrewlock commented Dec 24, 2024 •

edited

Loading

andrewlock commented Dec 24, 2024 •

edited

Loading

Raw results

Raw results

Raw results

Fewer allocations 🎉 in #6484

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #6484

Raw results

andrewlock commented Jan 23, 2025

datadog-ddstaging bot commented Jan 30, 2025 •

edited

Loading

Update dotnet-install scripts for impending change of .NET install domains #6484

Update dotnet-install scripts for impending change of .NET install domains #6484

Conversation

andrewlock commented Dec 24, 2024

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

datadog-ddstaging bot commented Dec 24, 2024 • edited Loading

Datadog Report

andrewlock commented Dec 24, 2024 • edited Loading

Execution-Time Benchmarks Report ⏱️

andrewlock commented Dec 24, 2024 • edited Loading

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

Fewer allocations 🎉 in #6484

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #6484

Raw results

andrewlock commented Jan 23, 2025

Throughput/Crank Report ⚡

datadog-ddstaging bot commented Jan 30, 2025 • edited Loading

Datadog Report

datadog-ddstaging bot commented Dec 24, 2024 •

edited

Loading

andrewlock commented Dec 24, 2024 •

edited

Loading

andrewlock commented Dec 24, 2024 •

edited

Loading

datadog-ddstaging bot commented Jan 30, 2025 •

edited

Loading