Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test Package Versions Bump] Updating package versions #6478

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Updates the package versions for integration tests.

@github-actions github-actions bot requested review from a team as code owners December 20, 2024 16:57
Copy link
Member

@andrewlock andrewlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if it passes

@andrewlock
Copy link
Member

andrewlock commented Dec 20, 2024

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6478) - mean (68ms)  : 66, 71
     .   : milestone, 68,
    master - mean (69ms)  : 64, 73
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6478) - mean (973ms)  : 950, 997
     .   : milestone, 973,
    master - mean (974ms)  : 953, 994
     .   : milestone, 974,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6478) - mean (107ms)  : 105, 110
     .   : milestone, 107,
    master - mean (107ms)  : 105, 109
     .   : milestone, 107,

    section CallTarget+Inlining+NGEN
    This PR (6478) - mean (676ms)  : 662, 690
     .   : milestone, 676,
    master - mean (676ms)  : 661, 692
     .   : milestone, 676,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6478) - mean (91ms)  : 89, 93
     .   : milestone, 91,
    master - mean (91ms)  : 89, 93
     .   : milestone, 91,

    section CallTarget+Inlining+NGEN
    This PR (6478) - mean (634ms)  : 616, 652
     .   : milestone, 634,
    master - mean (632ms)  : 617, 647
     .   : milestone, 632,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6478) - mean (194ms)  : 189, 198
     .   : milestone, 194,
    master - mean (193ms)  : 189, 198
     .   : milestone, 193,

    section CallTarget+Inlining+NGEN
    This PR (6478) - mean (1,098ms)  : 1066, 1129
     .   : milestone, 1098,
    master - mean (1,100ms)  : 1074, 1127
     .   : milestone, 1100,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6478) - mean (277ms)  : 273, 281
     .   : milestone, 277,
    master - mean (278ms)  : 274, 282
     .   : milestone, 278,

    section CallTarget+Inlining+NGEN
    This PR (6478) - mean (871ms)  : 839, 903
     .   : milestone, 871,
    master - mean (875ms)  : 851, 899
     .   : milestone, 875,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6478) - mean (267ms)  : 261, 272
     .   : milestone, 267,
    master - mean (266ms)  : 262, 271
     .   : milestone, 266,

    section CallTarget+Inlining+NGEN
    This PR (6478) - mean (851ms)  : 812, 889
     .   : milestone, 851,
    master - mean (852ms)  : 819, 885
     .   : milestone, 852,

Loading

@andrewlock
Copy link
Member

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6478) (11.161M)   : 0, 11161420
    master (11.166M)   : 0, 11165619
    benchmarks/2.9.0 (11.033M)   : 0, 11032866

    section Automatic
    This PR (6478) (7.249M)   : 0, 7249425
    master (7.232M)   : 0, 7232435
    benchmarks/2.9.0 (7.786M)   : 0, 7785853

    section Trace stats
    master (7.555M)   : 0, 7555239

    section Manual
    master (11.218M)   : 0, 11218357

    section Manual + Automatic
    This PR (6478) (6.713M)   : 0, 6713418
    master (6.695M)   : 0, 6694720

    section DD_TRACE_ENABLED=0
    master (10.195M)   : 0, 10194994

Loading
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6478) (9.556M)   : 0, 9556097
    master (9.350M)   : 0, 9350086
    benchmarks/2.9.0 (9.495M)   : 0, 9494821

    section Automatic
    This PR (6478) (6.455M)   : 0, 6455153
    master (6.223M)   : 0, 6222880

    section Trace stats
    master (6.644M)   : 0, 6644302

    section Manual
    master (9.490M)   : 0, 9490052

    section Manual + Automatic
    This PR (6478) (5.966M)   : 0, 5966262
    master (5.826M)   : 0, 5826117

    section DD_TRACE_ENABLED=0
    master (8.806M)   : 0, 8806093

Loading
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6478) (9.268M)   : 0, 9268450
    master (10.038M)   : 0, 10038108
    benchmarks/2.9.0 (10.020M)   : 0, 10019592

    section Automatic
    This PR (6478) (6.018M)   : crit ,0, 6017981
    master (6.759M)   : 0, 6759031
    benchmarks/2.9.0 (7.255M)   : 0, 7255257

    section Trace stats
    master (7.327M)   : 0, 7327150

    section Manual
    master (10.148M)   : 0, 10147695

    section Manual + Automatic
    This PR (6478) (5.600M)   : crit ,0, 5599802
    master (6.270M)   : 0, 6270298

    section DD_TRACE_ENABLED=0
    master (9.572M)   : 0, 9571995

Loading

@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Dec 20, 2024

Datadog Report

Branch report: bot/test-package-versions-bump
Commit report: 088e5e6
Test service: dd-trace-dotnet

✅ 0 Failed, 456870 Passed, 2835 Skipped, 19h 36m 8.52s Total Time

@andrewlock
Copy link
Member

andrewlock commented Dec 21, 2024

Benchmarks Report for tracer 🐌

Benchmarks for #6478 compared to master:

  • 2 benchmarks are faster, with geometric mean 1.193
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.89μs 42.1ns 231ns 0.0191 0.00762 0 5.61 KB
master StartStopWithChild netcoreapp3.1 10.3μs 56.9ns 346ns 0.02 0.00998 0 5.8 KB
master StartStopWithChild net472 16.4μs 46.6ns 174ns 1.04 0.326 0.0979 6.21 KB
#6478 StartStopWithChild net6.0 8.16μs 40.3ns 176ns 0.0129 0.00429 0 5.61 KB
#6478 StartStopWithChild netcoreapp3.1 10.2μs 53.7ns 263ns 0.0248 0.00994 0 5.8 KB
#6478 StartStopWithChild net472 16.6μs 62.4ns 242ns 1.04 0.312 0.0903 6.2 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 505μs 187ns 674ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 665μs 191ns 713ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 851μs 601ns 2.25μs 0.425 0 0 3.3 KB
#6478 WriteAndFlushEnrichedTraces net6.0 467μs 721ns 2.79μs 0 0 0 2.7 KB
#6478 WriteAndFlushEnrichedTraces netcoreapp3.1 647μs 479ns 1.79μs 0 0 0 2.7 KB
#6478 WriteAndFlushEnrichedTraces net472 845μs 693ns 2.68μs 0.425 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 159μs 1.17μs 11.7μs 0.155 0 0 14.47 KB
master SendRequest netcoreapp3.1 171μs 989ns 8.85μs 0.16 0 0 17.27 KB
master SendRequest net472 0.00147ns 0.000331ns 0.00119ns 0 0 0 0 b
#6478 SendRequest net6.0 158μs 1.01μs 9.85μs 0.148 0 0 14.47 KB
#6478 SendRequest netcoreapp3.1 177μs 1.33μs 13.2μs 0.155 0 0 17.27 KB
#6478 SendRequest net472 0.00164ns 0.000668ns 0.00259ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 574μs 3.16μs 19.7μs 0.571 0 0 41.6 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 667μs 3.5μs 18.2μs 0.319 0 0 41.66 KB
master WriteAndFlushEnrichedTraces net472 874μs 3.72μs 14.4μs 8.19 2.59 0.431 53.28 KB
#6478 WriteAndFlushEnrichedTraces net6.0 570μs 2.83μs 12.3μs 0.546 0 0 41.7 KB
#6478 WriteAndFlushEnrichedTraces netcoreapp3.1 664μs 3.21μs 15.4μs 0.327 0 0 41.85 KB
#6478 WriteAndFlushEnrichedTraces net472 825μs 2.82μs 10.5μs 8.17 2.45 0.408 53.27 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.28μs 1.12ns 4.19ns 0.0142 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.86μs 1.63ns 6.3ns 0.0138 0 0 1.02 KB
master ExecuteNonQuery net472 2.11μs 1.82ns 7.04ns 0.156 0.00105 0 987 B
#6478 ExecuteNonQuery net6.0 1.27μs 1.85ns 7.15ns 0.0145 0 0 1.02 KB
#6478 ExecuteNonQuery netcoreapp3.1 1.86μs 2.31ns 8.96ns 0.0141 0 0 1.02 KB
#6478 ExecuteNonQuery net472 2.13μs 2.39ns 8.95ns 0.156 0.00106 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.25μs 0.547ns 2.05ns 0.0138 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.61μs 1.32ns 5.13ns 0.0128 0 0 976 B
master CallElasticsearch net472 2.49μs 2.37ns 9.17ns 0.158 0 0 995 B
master CallElasticsearchAsync net6.0 1.35μs 0.4ns 1.44ns 0.013 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.76μs 1.28ns 4.95ns 0.014 0 0 1.02 KB
master CallElasticsearchAsync net472 2.68μs 0.672ns 2.42ns 0.166 0 0 1.05 KB
#6478 CallElasticsearch net6.0 1.31μs 4.07ns 15.2ns 0.0134 0 0 976 B
#6478 CallElasticsearch netcoreapp3.1 1.55μs 1.77ns 6.84ns 0.0132 0 0 976 B
#6478 CallElasticsearch net472 2.39μs 1.28ns 4.95ns 0.157 0 0 995 B
#6478 CallElasticsearchAsync net6.0 1.25μs 0.83ns 3.1ns 0.0132 0 0 952 B
#6478 CallElasticsearchAsync netcoreapp3.1 1.7μs 3.45ns 12.9ns 0.0135 0 0 1.02 KB
#6478 CallElasticsearchAsync net472 2.6μs 0.931ns 3.61ns 0.166 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.34μs 0.61ns 2.28ns 0.0139 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.59μs 0.735ns 2.75ns 0.0129 0 0 952 B
master ExecuteAsync net472 1.84μs 0.58ns 2.17ns 0.145 0 0 915 B
#6478 ExecuteAsync net6.0 1.26μs 0.743ns 2.78ns 0.0133 0 0 952 B
#6478 ExecuteAsync netcoreapp3.1 1.61μs 0.725ns 2.71ns 0.0127 0 0 952 B
#6478 ExecuteAsync net472 1.84μs 0.491ns 1.84ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.46μs 0.961ns 3.72ns 0.0313 0 0 2.31 KB
master SendAsync netcoreapp3.1 5.12μs 1.94ns 6.98ns 0.0361 0 0 2.85 KB
master SendAsync net472 7.37μs 1.27ns 4.57ns 0.494 0 0 3.12 KB
#6478 SendAsync net6.0 4.48μs 1.8ns 6.74ns 0.0315 0 0 2.31 KB
#6478 SendAsync netcoreapp3.1 5.24μs 3.61ns 14ns 0.037 0 0 2.85 KB
#6478 SendAsync net472 7.38μs 1.99ns 7.46ns 0.493 0 0 3.12 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.46μs 0.521ns 1.88ns 0.0228 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.25μs 9.33ns 36.1ns 0.0218 0 0 1.64 KB
master EnrichedLog net472 2.67μs 1.31ns 4.9ns 0.25 0 0 1.57 KB
#6478 EnrichedLog net6.0 1.46μs 0.471ns 1.83ns 0.023 0 0 1.64 KB
#6478 EnrichedLog netcoreapp3.1 2.17μs 0.85ns 3.18ns 0.0217 0 0 1.64 KB
#6478 EnrichedLog net472 2.77μs 1.25ns 4.68ns 0.249 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 119μs 165ns 616ns 0.0598 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 122μs 179ns 691ns 0 0 0 4.28 KB
master EnrichedLog net472 153μs 130ns 503ns 0.687 0.229 0 4.46 KB
#6478 EnrichedLog net6.0 120μs 219ns 848ns 0 0 0 4.28 KB
#6478 EnrichedLog netcoreapp3.1 121μs 113ns 421ns 0 0 0 4.28 KB
#6478 EnrichedLog net472 150μs 162ns 628ns 0.68 0.227 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.96μs 0.942ns 3.65ns 0.0312 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.11μs 1.58ns 6.11ns 0.0289 0 0 2.2 KB
master EnrichedLog net472 4.86μs 1.22ns 4.74ns 0.32 0 0 2.02 KB
#6478 EnrichedLog net6.0 3.05μs 1.12ns 4.19ns 0.0304 0 0 2.2 KB
#6478 EnrichedLog netcoreapp3.1 4.36μs 2.35ns 8.46ns 0.0284 0 0 2.2 KB
#6478 EnrichedLog net472 4.98μs 1.47ns 5.68ns 0.32 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.4μs 0.47ns 1.76ns 0.0162 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.82μs 8.41ns 32.6ns 0.0155 0 0 1.14 KB
master SendReceive net472 2.13μs 0.448ns 1.74ns 0.184 0 0 1.16 KB
#6478 SendReceive net6.0 1.39μs 0.889ns 3.44ns 0.0158 0 0 1.14 KB
#6478 SendReceive netcoreapp3.1 1.9μs 0.903ns 3.5ns 0.0151 0 0 1.14 KB
#6478 SendReceive net472 2.12μs 2.14ns 8.28ns 0.183 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.78μs 0.78ns 2.92ns 0.0224 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.87μs 2.61ns 10.1ns 0.0213 0 0 1.65 KB
master EnrichedLog net472 4.36μs 5.45ns 21.1ns 0.324 0 0 2.04 KB
#6478 EnrichedLog net6.0 2.67μs 0.579ns 2.24ns 0.0226 0 0 1.6 KB
#6478 EnrichedLog netcoreapp3.1 3.97μs 2.25ns 8.71ns 0.0218 0 0 1.65 KB
#6478 EnrichedLog net472 4.39μs 1.69ns 6.56ns 0.323 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6478

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 1.230 593.56 482.75
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1 1.157 652.47 563.77 several?

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 413ns 0.199ns 0.769ns 0.00802 0 0 576 B
master StartFinishSpan netcoreapp3.1 639ns 3.5ns 20.1ns 0.00752 0 0 576 B
master StartFinishSpan net472 660ns 0.547ns 2.12ns 0.0917 0 0 578 B
master StartFinishScope net6.0 594ns 0.422ns 1.63ns 0.00982 0 0 696 B
master StartFinishScope netcoreapp3.1 745ns 0.867ns 3.36ns 0.00932 0 0 696 B
master StartFinishScope net472 833ns 1.4ns 5.41ns 0.105 0 0 658 B
#6478 StartFinishSpan net6.0 458ns 0.354ns 1.37ns 0.00807 0 0 576 B
#6478 StartFinishSpan netcoreapp3.1 564ns 0.422ns 1.58ns 0.00762 0 0 576 B
#6478 StartFinishSpan net472 661ns 0.686ns 2.57ns 0.0917 0 0 578 B
#6478 StartFinishScope net6.0 483ns 0.179ns 0.693ns 0.00979 0 0 696 B
#6478 StartFinishScope netcoreapp3.1 721ns 0.478ns 1.85ns 0.00945 0 0 696 B
#6478 StartFinishScope net472 916ns 0.603ns 2.33ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 638ns 0.866ns 3.35ns 0.00963 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 894ns 0.805ns 3.12ns 0.00927 0 0 696 B
master RunOnMethodBegin net472 1.1μs 1.08ns 4.18ns 0.104 0 0 658 B
#6478 RunOnMethodBegin net6.0 629ns 0.482ns 1.86ns 0.00976 0 0 696 B
#6478 RunOnMethodBegin netcoreapp3.1 930ns 1.44ns 5.56ns 0.00961 0 0 696 B
#6478 RunOnMethodBegin net472 1.14μs 0.674ns 2.61ns 0.104 0 0 658 B

@github-actions github-actions bot force-pushed the bot/test-package-versions-bump branch from 4f099a6 to 088e5e6 Compare December 22, 2024 00:25
@andrewlock andrewlock merged commit 5bbffca into master Dec 23, 2024
51 of 53 checks passed
@andrewlock andrewlock deleted the bot/test-package-versions-bump branch December 23, 2024 10:15
@github-actions github-actions bot added this to the vNext-v3 milestone Dec 23, 2024
@andrewlock andrewlock added area:tests unit tests, integration tests area:test-apps apps used to test integrations dependencies Pull requests that update a dependency file area:dependabot dependabot updates labels Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dependabot dependabot updates area:test-apps apps used to test integrations area:tests unit tests, integration tests dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant