[Build] Fix version bump autogen files error #6464

daniel-romano-DD · 2024-12-19T11:55:10Z

Summary of changes

Fix autogen files checker error when version is bumped

Reason for change

Implementation details

Removed the version string from autoget files so when version bump happens, the autogen file checker does not fail.

Test coverage

Other details

andrewlock

Thanks for the fix!

datadog-ddstaging · 2024-12-19T12:22:27Z

Datadog Report

Branch report: dani/apm/fix_version_bump_error
Commit report: 95f058c
Test service: dd-trace-dotnet

✅ 0 Failed, 467025 Passed, 3707 Skipped, 33h 21m 22.95s Total Time

@vandonr

## Summary of changes Fix the build and the version-bump action ## Reason for change In #6457, @vandonr spotted that we accidentally, incorrectly, "bumped" the required version of cmake. ![image](https://github.com/user-attachments/assets/5843c1db-2dad-439e-8ed8-eeeb2d05def5) Additionally, the new calltargets_generated.g.cpp file _also_ now embeds the version, so we need to either update that, or stop embedding the version. @daniel-romano-DD is looking into the latter approach [here](#6464), so this PR is just a fix to unblock PRs. ## Implementation details - Revert the broken CMakeLists.txt - Fix the broken generated file - Be more discerning in our CMakeLists updates ## Test coverage Tested the version bump routine locally, and confirmed it works as expected now. ## Other details It would be _really_ nice if the version bumping just required bumping one or two values... That _might_ be somewhat feasible in the future, but for now...

andrewlock · 2024-12-19T17:03:41Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6464) - mean (69ms)  : 65, 72
     .   : milestone, 69,
    master - mean (68ms)  : 66, 71
     .   : milestone, 68,

    section CallTarget+Inlining+NGEN
    This PR (6464) - mean (979ms)  : 956, 1002
     .   : milestone, 979,
    master - mean (978ms)  : 959, 997
     .   : milestone, 978,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6464) - mean (108ms)  : 105, 110
     .   : milestone, 108,
    master - mean (107ms)  : 105, 110
     .   : milestone, 107,

    section CallTarget+Inlining+NGEN
    This PR (6464) - mean (678ms)  : 664, 693
     .   : milestone, 678,
    master - mean (678ms)  : 664, 693
     .   : milestone, 678,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6464) - mean (91ms)  : 89, 93
     .   : milestone, 91,
    master - mean (91ms)  : 89, 94
     .   : milestone, 91,

    section CallTarget+Inlining+NGEN
    This PR (6464) - mean (639ms)  : 622, 656
     .   : milestone, 639,
    master - mean (636ms)  : 618, 653
     .   : milestone, 636,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6464) - mean (194ms)  : 190, 198
     .   : milestone, 194,
    master - mean (193ms)  : 190, 196
     .   : milestone, 193,

    section CallTarget+Inlining+NGEN
    This PR (6464) - mean (1,101ms)  : 1072, 1131
     .   : milestone, 1101,
    master - mean (1,104ms)  : 1076, 1132
     .   : milestone, 1104,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6464) - mean (278ms)  : 274, 282
     .   : milestone, 278,
    master - mean (279ms)  : 275, 283
     .   : milestone, 279,

    section CallTarget+Inlining+NGEN
    This PR (6464) - mean (874ms)  : 844, 904
     .   : milestone, 874,
    master - mean (872ms)  : 851, 893
     .   : milestone, 872,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6464) - mean (267ms)  : 263, 271
     .   : milestone, 267,
    master - mean (267ms)  : 262, 272
     .   : milestone, 267,

    section CallTarget+Inlining+NGEN
    This PR (6464) - mean (852ms)  : 827, 877
     .   : milestone, 852,
    master - mean (851ms)  : 813, 889
     .   : milestone, 851,

andrewlock · 2024-12-19T23:06:35Z

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6464) (11.149M)   : 0, 11149215
    master (11.080M)   : 0, 11079759
    benchmarks/2.9.0 (11.033M)   : 0, 11032866

    section Automatic
    This PR (6464) (7.288M)   : 0, 7287725
    master (7.154M)   : 0, 7154253
    benchmarks/2.9.0 (7.786M)   : 0, 7785853

    section Trace stats
    master (7.512M)   : 0, 7512246

    section Manual
    master (11.035M)   : 0, 11035311

    section Manual + Automatic
    This PR (6464) (6.672M)   : 0, 6671897
    master (6.611M)   : 0, 6611049

    section DD_TRACE_ENABLED=0
    master (10.155M)   : 0, 10155447

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6464) (9.506M)   : 0, 9505886
    master (9.567M)   : 0, 9566967
    benchmarks/2.9.0 (9.495M)   : 0, 9494821

    section Automatic
    This PR (6464) (6.346M)   : 0, 6345514
    master (6.361M)   : 0, 6360592

    section Trace stats
    master (6.540M)   : 0, 6540289

    section Manual
    master (9.643M)   : 0, 9642857

    section Manual + Automatic
    This PR (6464) (5.894M)   : 0, 5893945
    master (5.877M)   : 0, 5877320

    section DD_TRACE_ENABLED=0
    master (8.928M)   : 0, 8928120

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6464) (9.939M)   : 0, 9938987
    master (9.916M)   : 0, 9915888
    benchmarks/2.9.0 (10.020M)   : 0, 10019592

    section Automatic
    This PR (6464) (6.293M)   : 0, 6293161
    master (6.337M)   : 0, 6336520
    benchmarks/2.9.0 (7.255M)   : 0, 7255257

    section Trace stats
    master (6.963M)   : 0, 6963468

    section Manual
    master (9.842M)   : 0, 9842464

    section Manual + Automatic
    This PR (6464) (6.082M)   : 0, 6081719
    master (6.172M)   : 0, 6171910

    section DD_TRACE_ENABLED=0
    master (9.319M)   : 0, 9318507

andrewlock · 2024-12-20T07:34:57Z

Benchmarks Report for tracer 🐌

Benchmarks for #6464 compared to master:

1 benchmarks are faster, with geometric mean 1.123
All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	7.97μs	45.5ns	328ns	0.0191	0.00766	0	5.61 KB
master	`StartStopWithChild`	netcoreapp3.1	10.3μs	55.2ns	282ns	0.0255	0.0102	0	5.8 KB
master	`StartStopWithChild`	net472	16.4μs	35.7ns	129ns	1.04	0.314	0.0993	6.21 KB
#6464	`StartStopWithChild`	net6.0	7.98μs	43.5ns	301ns	0.0153	0.00766	0	5.62 KB
#6464	`StartStopWithChild`	netcoreapp3.1	10.3μs	53.4ns	272ns	0.0155	0.00515	0	5.8 KB
#6464	`StartStopWithChild`	net472	16.3μs	53.5ns	207ns	1.04	0.312	0.0905	6.21 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	490μs	485ns	1.88μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	647μs	451ns	1.75μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	856μs	363ns	1.41μs	0.425	3.3 KB
#6464	`WriteAndFlushEnrichedTraces`	net6.0	497μs	322ns	1.21μs	0	2.7 KB
#6464	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	658μs	562ns	2.18μs	0	2.7 KB
#6464	`WriteAndFlushEnrichedTraces`	net472	859μs	818ns	3.06μs	0.428	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	158μs	1.01μs	9.83μs	0.142	14.47 KB
master	`SendRequest`	netcoreapp3.1	175μs	1.01μs	8.21μs	0.175	17.27 KB
master	`SendRequest`	net472	0ns	0ns	0ns	0	0 b
#6464	`SendRequest`	net6.0	157μs	1.04μs	10.3μs	0.145	14.47 KB
#6464	`SendRequest`	netcoreapp3.1	175μs	1.24μs	12.3μs	0.173	17.27 KB
#6464	`SendRequest`	net472	0.0115ns	0.00255ns	0.00988ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	585μs	3.26μs	19.9μs	0.576	0	0	41.64 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	688μs	3.7μs	21.3μs	0.324	0	0	41.73 KB
master	`WriteAndFlushEnrichedTraces`	net472	825μs	3.76μs	14.6μs	8.47	2.42	0.403	53.31 KB
#6464	`WriteAndFlushEnrichedTraces`	net6.0	569μs	3.07μs	17.9μs	0.568	0	0	41.48 KB
#6464	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	666μs	3.64μs	21.9μs	0.332	0	0	41.81 KB
#6464	`WriteAndFlushEnrichedTraces`	net472	827μs	3.33μs	12.9μs	8.47	2.42	0.403	53.3 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteNonQuery`	net6.0	1.29μs	1.77ns	6.84ns	0.0143	0	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.77μs	1.87ns	7.24ns	0.0132	0	1.02 KB
master	`ExecuteNonQuery`	net472	2.1μs	1.95ns	7.56ns	0.156	0.00105	987 B
#6464	`ExecuteNonQuery`	net6.0	1.28μs	1.03ns	3.86ns	0.0139	0	1.02 KB
#6464	`ExecuteNonQuery`	netcoreapp3.1	1.71μs	1.33ns	5.15ns	0.0138	0	1.02 KB
#6464	`ExecuteNonQuery`	net472	2.08μs	2.21ns	8.56ns	0.156	0.00104	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.29μs	0.511ns	1.91ns	0.0135	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.57μs	0.364ns	1.31ns	0.0132	976 B
master	`CallElasticsearch`	net472	2.55μs	0.953ns	3.44ns	0.157	995 B
master	`CallElasticsearchAsync`	net6.0	1.26μs	0.553ns	2.07ns	0.0133	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.64μs	0.817ns	3.06ns	0.014	1.02 KB
master	`CallElasticsearchAsync`	net472	2.47μs	0.991ns	3.57ns	0.166	1.05 KB
#6464	`CallElasticsearch`	net6.0	1.2μs	0.693ns	2.5ns	0.0138	976 B
#6464	`CallElasticsearch`	netcoreapp3.1	1.5μs	1.72ns	6.44ns	0.0129	976 B
#6464	`CallElasticsearch`	net472	2.59μs	2.62ns	10.1ns	0.158	995 B
#6464	`CallElasticsearchAsync`	net6.0	1.39μs	0.515ns	1.99ns	0.0132	952 B
#6464	`CallElasticsearchAsync`	netcoreapp3.1	1.66μs	0.946ns	3.54ns	0.0141	1.02 KB
#6464	`CallElasticsearchAsync`	net472	2.65μs	1.96ns	7.6ns	0.167	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.3μs	0.86ns	3.22ns	0.013	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.62μs	1.6ns	6.18ns	0.0128	952 B
master	`ExecuteAsync`	net472	1.84μs	0.5ns	1.87ns	0.145	915 B
#6464	`ExecuteAsync`	net6.0	1.31μs	0.86ns	3.22ns	0.0132	952 B
#6464	`ExecuteAsync`	netcoreapp3.1	1.66μs	0.377ns	1.36ns	0.0123	952 B
#6464	`ExecuteAsync`	net472	1.78μs	0.416ns	1.61ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.55μs	1.85ns	7.16ns	0.0318	2.31 KB
master	`SendAsync`	netcoreapp3.1	5.33μs	3.79ns	14.7ns	0.0373	2.85 KB
master	`SendAsync`	net472	7.32μs	1.64ns	6.36ns	0.494	3.12 KB
#6464	`SendAsync`	net6.0	4.45μs	1.68ns	6.5ns	0.0312	2.31 KB
#6464	`SendAsync`	netcoreapp3.1	5.44μs	4.96ns	17.2ns	0.0381	2.85 KB
#6464	`SendAsync`	net472	7.37μs	1.51ns	5.66ns	0.493	3.12 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.5μs	0.745ns	2.79ns	0.0234	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.28μs	1.22ns	4.74ns	0.0221	1.64 KB
master	`EnrichedLog`	net472	2.58μs	1.74ns	6.74ns	0.249	1.57 KB
#6464	`EnrichedLog`	net6.0	1.49μs	0.611ns	2.28ns	0.0231	1.64 KB
#6464	`EnrichedLog`	netcoreapp3.1	2.21μs	0.954ns	3.57ns	0.0222	1.64 KB
#6464	`EnrichedLog`	net472	2.72μs	1.11ns	4.17ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	118μs	152ns	587ns	0.059	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	122μs	270ns	1.04μs	0.061	0	4.28 KB
master	`EnrichedLog`	net472	150μs	206ns	744ns	0.686	0.229	4.46 KB
#6464	`EnrichedLog`	net6.0	116μs	151ns	585ns	0.0578	0	4.28 KB
#6464	`EnrichedLog`	netcoreapp3.1	121μs	81.1ns	304ns	0	0	4.28 KB
#6464	`EnrichedLog`	net472	151μs	209ns	808ns	0.677	0.226	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.12μs	1.1ns	4.13ns	0.0298	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.2μs	1.65ns	6.17ns	0.0294	2.2 KB
master	`EnrichedLog`	net472	4.91μs	1.81ns	7.02ns	0.319	2.02 KB
#6464	`EnrichedLog`	net6.0	2.94μs	1.03ns	3.99ns	0.0314	2.2 KB
#6464	`EnrichedLog`	netcoreapp3.1	4.02μs	1.85ns	7.15ns	0.0281	2.2 KB
#6464	`EnrichedLog`	net472	5.06μs	1.44ns	5.4ns	0.32	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.46μs	0.829ns	3.1ns	0.0161	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.74μs	0.707ns	2.74ns	0.0156	1.14 KB
master	`SendReceive`	net472	2.16μs	0.782ns	2.82ns	0.183	1.16 KB
#6464	`SendReceive`	net6.0	1.36μs	1.7ns	6.59ns	0.0163	1.14 KB
#6464	`SendReceive`	netcoreapp3.1	1.72μs	1.15ns	4.3ns	0.0157	1.14 KB
#6464	`SendReceive`	net472	2.12μs	0.538ns	2.08ns	0.183	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.63μs	1.32ns	5.12ns	0.0223	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.92μs	1.5ns	5.82ns	0.0216	1.65 KB
master	`EnrichedLog`	net472	4.4μs	7.54ns	29.2ns	0.322	2.04 KB
#6464	`EnrichedLog`	net6.0	2.77μs	1.43ns	5.16ns	0.0222	1.6 KB
#6464	`EnrichedLog`	netcoreapp3.1	3.86μs	1.02ns	3.94ns	0.0213	1.65 KB
#6464	`EnrichedLog`	net472	4.37μs	3.77ns	14.6ns	0.324	2.04 KB

Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6464

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net472	1.123	928.44	826.62

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	452ns	0.322ns	1.25ns	0.00812	576 B
master	`StartFinishSpan`	netcoreapp3.1	660ns	0.47ns	1.82ns	0.00756	576 B
master	`StartFinishSpan`	net472	695ns	0.521ns	2.02ns	0.0915	578 B
master	`StartFinishScope`	net6.0	544ns	0.249ns	0.963ns	0.00975	696 B
master	`StartFinishScope`	netcoreapp3.1	717ns	0.581ns	2.25ns	0.00958	696 B
master	`StartFinishScope`	net472	929ns	0.627ns	2.35ns	0.105	658 B
#6464	`StartFinishSpan`	net6.0	458ns	0.253ns	0.979ns	0.00806	576 B
#6464	`StartFinishSpan`	netcoreapp3.1	611ns	0.576ns	2.23ns	0.00765	576 B
#6464	`StartFinishSpan`	net472	633ns	0.49ns	1.9ns	0.0916	578 B
#6464	`StartFinishScope`	net6.0	544ns	0.137ns	0.495ns	0.00975	696 B
#6464	`StartFinishScope`	netcoreapp3.1	695ns	0.7ns	2.71ns	0.00942	696 B
#6464	`StartFinishScope`	net472	826ns	0.677ns	2.62ns	0.105	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	621ns	3.01ns	12.1ns	0.00988	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	930ns	0.674ns	2.61ns	0.00935	696 B
master	`RunOnMethodBegin`	net472	1.12μs	0.939ns	3.64ns	0.104	658 B
#6464	`RunOnMethodBegin`	net6.0	630ns	0.709ns	2.75ns	0.00983	696 B
#6464	`RunOnMethodBegin`	netcoreapp3.1	977ns	0.653ns	2.53ns	0.00931	696 B
#6464	`RunOnMethodBegin`	net472	1.18μs	1.05ns	4.08ns	0.105	658 B

Removed unneeded file Removed utils function Rebase fix

daniel-romano-DD changed the title ~~Fix version bump autogen files error~~ [Build] Fix version bump autogen files error Dec 19, 2024

daniel-romano-DD added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Dec 19, 2024

andrewlock approved these changes Dec 19, 2024

View reviewed changes

daniel-romano-DD marked this pull request as ready for review December 19, 2024 12:05

daniel-romano-DD requested review from a team as code owners December 19, 2024 12:05

andrewlock mentioned this pull request Dec 19, 2024

Fix the build and some versions #6466

Merged

daniel-romano-DD force-pushed the dani/apm/fix_version_bump_error branch from dff1481 to 1454b63 Compare December 19, 2024 15:22

daniel-romano-DD force-pushed the dani/apm/fix_version_bump_error branch 2 times, most recently from 4c5da3c to 95f058c Compare December 23, 2024 12:16

Fix version bump autogen files error

95f058c

Removed unneeded file Removed utils function Rebase fix

NachoEchevarria approved these changes Dec 24, 2024

View reviewed changes

daniel-romano-DD merged commit 2cdde8d into master Dec 24, 2024
106 of 107 checks passed

daniel-romano-DD deleted the dani/apm/fix_version_bump_error branch December 24, 2024 09:54

github-actions bot added this to the vNext-v3 milestone Dec 24, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Build] Fix version bump autogen files error #6464

[Build] Fix version bump autogen files error #6464

daniel-romano-DD commented Dec 19, 2024 •

edited

Loading

andrewlock left a comment

datadog-ddstaging bot commented Dec 19, 2024 •

edited

Loading

andrewlock commented Dec 19, 2024 •

edited

Loading

andrewlock commented Dec 19, 2024

andrewlock commented Dec 20, 2024 •

edited

Loading

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #6464

Raw results

Raw results

[Build] Fix version bump autogen files error #6464

[Build] Fix version bump autogen files error #6464

Conversation

daniel-romano-DD commented Dec 19, 2024 • edited Loading

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

andrewlock left a comment

Choose a reason for hiding this comment

datadog-ddstaging bot commented Dec 19, 2024 • edited Loading

Datadog Report

andrewlock commented Dec 19, 2024 • edited Loading

Execution-Time Benchmarks Report ⏱️

andrewlock commented Dec 19, 2024

Throughput/Crank Report ⚡

andrewlock commented Dec 20, 2024 • edited Loading

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #6464

Raw results

Raw results

daniel-romano-DD commented Dec 19, 2024 •

edited

Loading

datadog-ddstaging bot commented Dec 19, 2024 •

edited

Loading

andrewlock commented Dec 19, 2024 •

edited

Loading

andrewlock commented Dec 20, 2024 •

edited

Loading