[tracing] add null checks when iterating headers in propagators #6460

lucaspimentel · 2024-12-19T04:25:42Z

Summary of changes

Add null checks in ParseUtility to avoid a NullReferenceException.

Reason for change

If a user passes a delegate to SpanContextExtractor which returns null enumerables, the methods in ParseUtility will throw a NullReferenceException when they try to iterate over the values with foreach.

For example, Dictionary<TKey, TValue>.GetValueOrDefault(TKey) can return null if TValue is nullable:

var dict = new Dictionary<string, List<string>>();
SpanContextExtractor.Extract(headers, (dict, key) => dict.GetValueOrDefault(key))

I noticed this while using manual instrumentation for system tests. The workaround I used at the time was to add a null-coalescing operator:

SpanContextExtractor.Extract(headers, (dict, key) => dict.GetValueOrDefault(key) ?? [])

Implementation details

Add nullability annotations and the missing check for null.

Test coverage

Expanded existing tests:

add test with null enumerable (confirmed that test failed before the fix and passed after)
unrelated to this change: add test with multiple values, ensure we use the first valid value

Other details

n/a

datadog-ddstaging · 2024-12-19T05:01:30Z

Datadog Report

Branch report: lpimentel/ParseUtility-add-null-checks
Commit report: 8d1a69f
Test service: dd-trace-dotnet

❌ 1 Failed (0 Known Flaky), 458117 Passed, 2818 Skipped, 19h 39m 26.49s Total Time

❌ Failed Tests (1)

TestInstrumentedUnitTests - Datadog.Trace.Security.IntegrationTests.Iast.IastInstrumentationUnitTests - Details
Expand for error
```
 Expected exit code: 0, actual exit code: 1.
```

andrewlock · 2024-12-19T05:11:08Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6460) - mean (69ms)  : 66, 72
     .   : milestone, 69,
    master - mean (69ms)  : 66, 72
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6460) - mean (1,005ms)  : 983, 1026
     .   : milestone, 1005,
    master - mean (1,003ms)  : 976, 1030
     .   : milestone, 1003,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6460) - mean (103ms)  : 100, 106
     .   : milestone, 103,
    master - mean (103ms)  : 100, 105
     .   : milestone, 103,

    section CallTarget+Inlining+NGEN
    This PR (6460) - mean (686ms)  : 666, 706
     .   : milestone, 686,
    master - mean (687ms)  : 670, 703
     .   : milestone, 687,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6460) - mean (89ms)  : 87, 90
     .   : milestone, 89,
    master - mean (89ms)  : 87, 91
     .   : milestone, 89,

    section CallTarget+Inlining+NGEN
    This PR (6460) - mean (640ms)  : 621, 659
     .   : milestone, 640,
    master - mean (645ms)  : 628, 661
     .   : milestone, 645,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6460) - mean (191ms)  : 188, 195
     .   : milestone, 191,
    master - mean (190ms)  : 185, 196
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6460) - mean (1,118ms)  : 1080, 1155
     .   : milestone, 1118,
    master - mean (1,106ms)  : 1078, 1134
     .   : milestone, 1106,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6460) - mean (270ms)  : 266, 275
     .   : milestone, 270,
    master - mean (270ms)  : 266, 274
     .   : milestone, 270,

    section CallTarget+Inlining+NGEN
    This PR (6460) - mean (878ms)  : 850, 905
     .   : milestone, 878,
    master - mean (876ms)  : 847, 905
     .   : milestone, 876,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6460) - mean (263ms)  : 259, 266
     .   : milestone, 263,
    master - mean (262ms)  : 258, 266
     .   : milestone, 262,

    section CallTarget+Inlining+NGEN
    This PR (6460) - mean (856ms)  : 822, 890
     .   : milestone, 856,
    master - mean (855ms)  : 826, 884
     .   : milestone, 855,

andrewlock · 2024-12-19T06:22:35Z

Benchmarks Report for tracer 🐌

Benchmarks for #6460 compared to master:

1 benchmarks are slower, with geometric mean 1.136
All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	8.49μs	49.3ns	455ns	0.0164	0.00819	0	5.61 KB
master	`StartStopWithChild`	netcoreapp3.1	10.8μs	61.6ns	508ns	0.0158	0.00527	0	5.8 KB
master	`StartStopWithChild`	net472	16.2μs	53.4ns	192ns	1.04	0.312	0.0961	6.21 KB
#6460	`StartStopWithChild`	net6.0	8.48μs	49.2ns	400ns	0.0133	0.00442	0	5.61 KB
#6460	`StartStopWithChild`	netcoreapp3.1	10.7μs	60.9ns	435ns	0.0202	0.0101	0	5.81 KB
#6460	`StartStopWithChild`	net472	16.3μs	50.4ns	189ns	1.03	0.287	0.0819	6.2 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	498μs	360ns	1.3μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	678μs	180ns	649ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	871μs	836ns	3.13μs	0.437	3.3 KB
#6460	`WriteAndFlushEnrichedTraces`	net6.0	497μs	273ns	1.06μs	0	2.7 KB
#6460	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	653μs	574ns	2.22μs	0	2.7 KB
#6460	`WriteAndFlushEnrichedTraces`	net472	857μs	612ns	2.37μs	0.428	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	131μs	364ns	1.41μs	0.199	14.48 KB
master	`SendRequest`	netcoreapp3.1	146μs	276ns	1.07μs	0.215	17.27 KB
master	`SendRequest`	net472	0.000119ns	6.65E‑05ns	0.000258ns	0	0 b
#6460	`SendRequest`	net6.0	132μs	221ns	858ns	0.13	14.47 KB
#6460	`SendRequest`	netcoreapp3.1	151μs	303ns	1.13μs	0.226	17.27 KB
#6460	`SendRequest`	net472	0.000488ns	0.000283ns	0.0011ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	566μs	3.03μs	16.3μs	0.584	0	0	41.57 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	702μs	3.93μs	32.4μs	0.342	0	0	41.74 KB
master	`WriteAndFlushEnrichedTraces`	net472	844μs	4.03μs	15.6μs	8.39	2.52	0.419	53.26 KB
#6460	`WriteAndFlushEnrichedTraces`	net6.0	579μs	2.93μs	13.4μs	0.571	0	0	41.55 KB
#6460	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	670μs	3.53μs	17.3μs	0.334	0	0	41.76 KB
#6460	`WriteAndFlushEnrichedTraces`	net472	863μs	2.54μs	9.49μs	8.25	2.6	0.434	53.27 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteNonQuery`	net6.0	1.28μs	0.63ns	2.27ns	0.0142	0	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.81μs	1.48ns	5.32ns	0.0137	0	1.02 KB
master	`ExecuteNonQuery`	net472	2.1μs	3.26ns	12.6ns	0.156	0.00105	987 B
#6460	`ExecuteNonQuery`	net6.0	1.27μs	1.02ns	3.96ns	0.0141	0	1.02 KB
#6460	`ExecuteNonQuery`	netcoreapp3.1	1.87μs	2.81ns	10.9ns	0.0138	0	1.02 KB
#6460	`ExecuteNonQuery`	net472	2.08μs	1.44ns	5.39ns	0.156	0.00103	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.28μs	0.307ns	1.11ns	0.0134	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.66μs	0.608ns	2.28ns	0.0133	976 B
master	`CallElasticsearch`	net472	2.59μs	1.32ns	4.93ns	0.157	995 B
master	`CallElasticsearchAsync`	net6.0	1.27μs	0.699ns	2.71ns	0.0134	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.53μs	0.588ns	2.12ns	0.0139	1.02 KB
master	`CallElasticsearchAsync`	net472	2.64μs	3.53ns	13.7ns	0.167	1.05 KB
#6460	`CallElasticsearch`	net6.0	1.27μs	0.727ns	2.81ns	0.0134	976 B
#6460	`CallElasticsearch`	netcoreapp3.1	1.56μs	0.727ns	2.72ns	0.0128	976 B
#6460	`CallElasticsearch`	net472	2.57μs	2.15ns	8.32ns	0.157	995 B
#6460	`CallElasticsearchAsync`	net6.0	1.23μs	0.817ns	3.06ns	0.0129	952 B
#6460	`CallElasticsearchAsync`	netcoreapp3.1	1.65μs	0.884ns	3.31ns	0.0141	1.02 KB
#6460	`CallElasticsearchAsync`	net472	2.6μs	1.63ns	6.31ns	0.166	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.32μs	0.607ns	2.27ns	0.0132	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.67μs	0.489ns	1.69ns	0.0125	952 B
master	`ExecuteAsync`	net472	1.85μs	0.478ns	1.72ns	0.145	915 B
#6460	`ExecuteAsync`	net6.0	1.2μs	1.54ns	5.76ns	0.0133	952 B
#6460	`ExecuteAsync`	netcoreapp3.1	1.69μs	0.58ns	2.17ns	0.0127	952 B
#6460	`ExecuteAsync`	net472	1.91μs	0.618ns	2.23ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.26μs	1.24ns	4.28ns	0.032	2.31 KB
master	`SendAsync`	netcoreapp3.1	5.34μs	1.27ns	4.57ns	0.0373	2.85 KB
master	`SendAsync`	net472	7.45μs	2.51ns	9.73ns	0.496	3.12 KB
#6460	`SendAsync`	net6.0	4.35μs	2.77ns	10.7ns	0.0326	2.31 KB
#6460	`SendAsync`	netcoreapp3.1	5.45μs	2.77ns	10.7ns	0.0384	2.85 KB
#6460	`SendAsync`	net472	7.44μs	1.14ns	4.12ns	0.496	3.12 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.48μs	1.2ns	4.48ns	0.0229	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.19μs	0.963ns	3.6ns	0.0229	1.64 KB
master	`EnrichedLog`	net472	2.63μs	0.704ns	2.64ns	0.249	1.57 KB
#6460	`EnrichedLog`	net6.0	1.52μs	2.99ns	11.2ns	0.0226	1.64 KB
#6460	`EnrichedLog`	netcoreapp3.1	2.3μs	1.51ns	5.84ns	0.022	1.64 KB
#6460	`EnrichedLog`	net472	2.63μs	0.92ns	3.44ns	0.25	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	112μs	213ns	824ns	0.0553	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	118μs	165ns	640ns	0.0587	0	4.28 KB
master	`EnrichedLog`	net472	149μs	180ns	698ns	0.663	0.221	4.46 KB
#6460	`EnrichedLog`	net6.0	114μs	68.6ns	266ns	0.0567	0	4.28 KB
#6460	`EnrichedLog`	netcoreapp3.1	116μs	175ns	678ns	0.0583	0	4.28 KB
#6460	`EnrichedLog`	net472	150μs	152ns	588ns	0.673	0.224	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.03μs	0.9ns	3.48ns	0.0318	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.22μs	1.48ns	5.35ns	0.0296	2.2 KB
master	`EnrichedLog`	net472	4.98μs	0.908ns	3.4ns	0.32	2.02 KB
#6460	`EnrichedLog`	net6.0	3.19μs	1.82ns	6.57ns	0.03	2.2 KB
#6460	`EnrichedLog`	netcoreapp3.1	4.11μs	1.64ns	6.12ns	0.0306	2.2 KB
#6460	`EnrichedLog`	net472	4.75μs	1.87ns	7.24ns	0.321	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.49μs	1.37ns	5.3ns	0.0157	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.8μs	0.741ns	2.77ns	0.0153	1.14 KB
master	`SendReceive`	net472	2.09μs	0.741ns	2.87ns	0.184	1.16 KB
#6460	`SendReceive`	net6.0	1.37μs	0.496ns	1.92ns	0.0157	1.14 KB
#6460	`SendReceive`	netcoreapp3.1	1.86μs	0.988ns	3.83ns	0.0149	1.14 KB
#6460	`SendReceive`	net472	1.98μs	1.27ns	4.91ns	0.183	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.78μs	0.736ns	2.75ns	0.0222	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.94μs	2.1ns	8.11ns	0.0218	1.65 KB
master	`EnrichedLog`	net472	4.26μs	2.41ns	9.32ns	0.323	2.04 KB
#6460	`EnrichedLog`	net6.0	2.68μs	0.767ns	2.87ns	0.0215	1.6 KB
#6460	`EnrichedLog`	netcoreapp3.1	3.8μs	3.48ns	13.5ns	0.0227	1.65 KB
#6460	`EnrichedLog`	net472	4.25μs	3.12ns	12.1ns	0.323	2.04 KB

Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6460

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0	1.136	481.30	546.97

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	468ns	0.142ns	0.513ns	0.00813	576 B
master	`StartFinishSpan`	netcoreapp3.1	587ns	0.343ns	1.33ns	0.00764	576 B
master	`StartFinishSpan`	net472	635ns	0.279ns	1.08ns	0.0916	578 B
master	`StartFinishScope`	net6.0	481ns	0.128ns	0.496ns	0.00979	696 B
master	`StartFinishScope`	netcoreapp3.1	695ns	1.89ns	7.3ns	0.00938	696 B
master	`StartFinishScope`	net472	811ns	0.679ns	2.63ns	0.104	658 B
#6460	`StartFinishSpan`	net6.0	474ns	0.237ns	0.918ns	0.00796	576 B
#6460	`StartFinishSpan`	netcoreapp3.1	622ns	0.342ns	1.28ns	0.00781	576 B
#6460	`StartFinishSpan`	net472	597ns	0.19ns	0.736ns	0.0916	578 B
#6460	`StartFinishScope`	net6.0	547ns	0.139ns	0.521ns	0.00982	696 B
#6460	`StartFinishScope`	netcoreapp3.1	746ns	0.38ns	1.42ns	0.00926	696 B
#6460	`StartFinishScope`	net472	802ns	0.544ns	2.11ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	613ns	0.304ns	1.18ns	0.00994	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	928ns	0.298ns	1.11ns	0.00909	696 B
master	`RunOnMethodBegin`	net472	1.1μs	0.364ns	1.41ns	0.104	658 B
#6460	`RunOnMethodBegin`	net6.0	620ns	0.278ns	1.08ns	0.00971	696 B
#6460	`RunOnMethodBegin`	netcoreapp3.1	958ns	1.99ns	7.72ns	0.0094	696 B
#6460	`RunOnMethodBegin`	net472	1.1μs	0.209ns	0.808ns	0.105	658 B

andrewlock · 2024-12-19T06:39:30Z

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6460) (11.204M)   : 0, 11203962
    master (11.249M)   : 0, 11248712
    benchmarks/2.9.0 (11.033M)   : 0, 11032866

    section Automatic
    This PR (6460) (7.138M)   : 0, 7138385
    master (7.347M)   : 0, 7347049
    benchmarks/2.9.0 (7.786M)   : 0, 7785853

    section Trace stats
    master (7.654M)   : 0, 7654087

    section Manual
    master (11.190M)   : 0, 11189743

    section Manual + Automatic
    This PR (6460) (6.590M)   : 0, 6589779
    master (6.679M)   : 0, 6679400

    section DD_TRACE_ENABLED=0
    master (10.188M)   : 0, 10188440

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6460) (9.616M)   : 0, 9615615
    master (9.530M)   : 0, 9530088
    benchmarks/2.9.0 (9.495M)   : 0, 9494821

    section Automatic
    This PR (6460) (6.411M)   : 0, 6411024
    master (6.231M)   : 0, 6230985

    section Trace stats
    master (6.683M)   : 0, 6683249

    section Manual
    master (9.386M)   : 0, 9386293

    section Manual + Automatic
    This PR (6460) (5.924M)   : 0, 5924341
    master (5.912M)   : 0, 5912138

    section DD_TRACE_ENABLED=0
    master (8.814M)   : 0, 8813827

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6460) (10.229M)   : 0, 10229010
    master (10.112M)   : 0, 10112273
    benchmarks/2.9.0 (10.020M)   : 0, 10019592

    section Automatic
    This PR (6460) (6.581M)   : 0, 6581383
    master (6.311M)   : 0, 6310709
    benchmarks/2.9.0 (7.255M)   : 0, 7255257

    section Trace stats
    master (7.120M)   : 0, 7119600

    section Manual
    master (9.566M)   : 0, 9565510

    section Manual + Automatic
    This PR (6460) (6.215M)   : 0, 6214602
    master (6.208M)   : 0, 6208407

    section DD_TRACE_ENABLED=0
    master (9.215M)   : 0, 9215486

datadog-datadog-prod-us1 · 2025-03-06T17:23:41Z

Datadog Report

Branch report: lpimentel/ParseUtility-add-null-checks
Commit report: 4a894e1
Test service: dd-trace-dotnet

✅ 0 Failed, 246093 Passed, 2374 Skipped, 20h 7m 26.9s Total Time
❄️ 17 New Flaky

New Flaky Tests (17)

IntegrationDisabled - Datadog.Trace.ClrProfiler.IntegrationTests.AdoNet.SystemDataSqliteTests - Last Failure
Expand for error
```
 
 ---- System.OutOfMemoryException : Exception of type 'System.OutOfMemoryException' was thrown.
```
AspNetCoreMvc30TestsNoQueryString.MeetsAllAspNetCoreMvcExpectations - Datadog.Trace.ClrProfiler.IntegrationTests.AspNetCore - Last Failure
Expand for error
```
 
 ---- System.OutOfMemoryException : Exception of type 'System.OutOfMemoryException' was thrown.
```
AspNetCoreMvc30TestsQueryString.MeetsAllAspNetCoreMvcExpectations - Datadog.Trace.ClrProfiler.IntegrationTests.AspNetCore - Last Failure
Expand for error
```
 
 ---- System.OutOfMemoryException : Exception of type 'System.OutOfMemoryException' was thrown.
```
MeetsAllAspNetCoreMvcExpectations - Datadog.Trace.ClrProfiler.IntegrationTests.AspNetCore.AspNetCoreMvc31TestsCallTargetWithFeatureFlag - Last Failure
Expand for error
```
 
 ---- System.OutOfMemoryException : Exception of type 'System.OutOfMemoryException' was thrown.
```
MeetsAllAspNetCoreMvcExpectations - Datadog.Trace.ClrProfiler.IntegrationTests.AspNetCore.AspNetCoreMvc31TestsCallTargetWithFeatureFlag - Last Failure
Expand for error
```
 
 ---- System.OutOfMemoryException : Exception of type 'System.OutOfMemoryException' was thrown.
```

bouwkast

Thanks!

github-actions bot added the area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) label Dec 19, 2024

lucaspimentel mentioned this pull request Dec 19, 2024

[dotnet] parametric app improvements DataDog/system-tests#3723

Merged

7 tasks

lucaspimentel force-pushed the lpimentel/ParseUtility-add-null-checks branch from 8d1a69f to 1628997 Compare March 6, 2025 16:49

lucaspimentel added 3 commits March 6, 2025 12:21

add test cases (which fail)

e5c11d4

add null checks for all the foreach

18e6a0a

clean up using directives

4a894e1

lucaspimentel force-pushed the lpimentel/ParseUtility-add-null-checks branch from 1628997 to 4a894e1 Compare March 6, 2025 17:24

lucaspimentel marked this pull request as ready for review March 6, 2025 17:29

lucaspimentel requested a review from a team as a code owner March 6, 2025 17:29

lucaspimentel added the type:bug label Mar 6, 2025

zacharycmontoya approved these changes Mar 6, 2025

View reviewed changes

lucaspimentel requested a review from a team March 6, 2025 17:36

bouwkast approved these changes Mar 6, 2025

View reviewed changes

lucaspimentel merged commit 1aff83b into master Mar 7, 2025
145 of 146 checks passed

lucaspimentel deleted the lpimentel/ParseUtility-add-null-checks branch March 7, 2025 01:09

github-actions bot added this to the vNext-v3 milestone Mar 7, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[tracing] add null checks when iterating headers in propagators #6460

[tracing] add null checks when iterating headers in propagators #6460

lucaspimentel commented Dec 19, 2024 •

edited

Loading

datadog-ddstaging bot commented Dec 19, 2024 •

edited

Loading

andrewlock commented Dec 19, 2024 •

edited

Loading

andrewlock commented Dec 19, 2024 •

edited

Loading

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6460

Raw results

Raw results

andrewlock commented Dec 19, 2024

datadog-datadog-prod-us1 bot commented Mar 6, 2025 •

edited

Loading

bouwkast left a comment

[tracing] add null checks when iterating headers in propagators #6460

[tracing] add null checks when iterating headers in propagators #6460

Conversation

lucaspimentel commented Dec 19, 2024 • edited Loading

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

datadog-ddstaging bot commented Dec 19, 2024 • edited Loading

Datadog Report

❌ Failed Tests (1)

andrewlock commented Dec 19, 2024 • edited Loading

Execution-Time Benchmarks Report ⏱️

andrewlock commented Dec 19, 2024 • edited Loading

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6460

Raw results

Raw results

andrewlock commented Dec 19, 2024

Throughput/Crank Report ⚡

datadog-datadog-prod-us1 bot commented Mar 6, 2025 • edited Loading

Datadog Report

New Flaky Tests (17)

bouwkast left a comment

Choose a reason for hiding this comment

lucaspimentel commented Dec 19, 2024 •

edited

Loading

datadog-ddstaging bot commented Dec 19, 2024 •

edited

Loading

andrewlock commented Dec 19, 2024 •

edited

Loading

andrewlock commented Dec 19, 2024 •

edited

Loading

datadog-datadog-prod-us1 bot commented Mar 6, 2025 •

edited

Loading