[Crashtracking] Add a setting to disable crashtracking filtering #6452

kevingosse · 2024-12-17T15:56:15Z

Summary of changes

Add a DD_CRASHTRACKING_FILTERING_ENABLED environment variable. When set to 0, crashtracking will send all crash reports to telemetry, regardless of whether they're marked as suspicious or not.

Reason for change

It is not always easy for customers to send crash dumps. This can be used as an alternative solution in some cases. We may also be able to use it to get information on some crashes in the CI without having to download the coredump.

Test coverage

Added a test to confirm a report is received in a non-datadog crash when setting DD_CRASHTRACKING_FILTERING_ENABLED=0

tracer/src/Datadog.Trace.Tools.dd_dotnet/CreatedumpCommand.cs

andrewlock · 2024-12-17T16:12:10Z

tracer/src/Datadog.Trace.Tools.dd_dotnet/CreatedumpCommand.cs


-        AnsiConsole.WriteLine("Datadog - The crash may have been caused by automatic instrumentation, sending crash report...");
+            if (filteringEnabled == "0" || filteringEnabled.Equals("false", StringComparison.OrdinalIgnoreCase))


No "off" support? 😛

Nobody uses "off", right? :padme:

andrewlock · 2024-12-17T16:38:43Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6452) - mean (68ms)  : 65, 71
     .   : milestone, 68,
    master - mean (69ms)  : 65, 73
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6452) - mean (976ms)  : 948, 1005
     .   : milestone, 976,
    master - mean (981ms)  : 957, 1005
     .   : milestone, 981,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6452) - mean (106ms)  : 104, 109
     .   : milestone, 106,
    master - mean (108ms)  : 105, 110
     .   : milestone, 108,

    section CallTarget+Inlining+NGEN
    This PR (6452) - mean (679ms)  : 666, 693
     .   : milestone, 679,
    master - mean (679ms)  : 666, 693
     .   : milestone, 679,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6452) - mean (91ms)  : 89, 93
     .   : milestone, 91,
    master - mean (91ms)  : 89, 93
     .   : milestone, 91,

    section CallTarget+Inlining+NGEN
    This PR (6452) - mean (637ms)  : 616, 659
     .   : milestone, 637,
    master - mean (637ms)  : 622, 651
     .   : milestone, 637,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6452) - mean (193ms)  : 189, 197
     .   : milestone, 193,
    master - mean (194ms)  : 189, 199
     .   : milestone, 194,

    section CallTarget+Inlining+NGEN
    This PR (6452) - mean (1,101ms)  : 1076, 1126
     .   : milestone, 1101,
    master - mean (1,100ms)  : 1064, 1136
     .   : milestone, 1100,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6452) - mean (276ms)  : 272, 281
     .   : milestone, 276,
    master - mean (278ms)  : 274, 282
     .   : milestone, 278,

    section CallTarget+Inlining+NGEN
    This PR (6452) - mean (868ms)  : 843, 893
     .   : milestone, 868,
    master - mean (870ms)  : 836, 905
     .   : milestone, 870,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6452) - mean (267ms)  : 262, 271
     .   : milestone, 267,
    master - mean (266ms)  : 262, 269
     .   : milestone, 266,

    section CallTarget+Inlining+NGEN
    This PR (6452) - mean (848ms)  : 818, 878
     .   : milestone, 848,
    master - mean (853ms)  : 825, 881
     .   : milestone, 853,

datadog-ddstaging · 2024-12-17T16:50:10Z

Datadog Report

Branch report: kevin/crashtracking_all_the_things
Commit report: a4f57fc
Test service: dd-trace-dotnet

✅ 0 Failed, 460014 Passed, 2837 Skipped, 19h 36m 2.09s Total Time

andrewlock · 2024-12-18T01:15:38Z

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6452) (11.120M)   : 0, 11120308
    master (11.166M)   : 0, 11165619
    benchmarks/2.9.0 (11.033M)   : 0, 11032866

    section Automatic
    This PR (6452) (7.182M)   : 0, 7181582
    master (7.232M)   : 0, 7232435
    benchmarks/2.9.0 (7.786M)   : 0, 7785853

    section Trace stats
    master (7.555M)   : 0, 7555239

    section Manual
    master (11.218M)   : 0, 11218357

    section Manual + Automatic
    This PR (6452) (6.760M)   : 0, 6759818
    master (6.695M)   : 0, 6694720

    section DD_TRACE_ENABLED=0
    master (10.195M)   : 0, 10194994

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6452) (9.621M)   : 0, 9621226
    master (9.350M)   : 0, 9350086
    benchmarks/2.9.0 (9.495M)   : 0, 9494821

    section Automatic
    This PR (6452) (6.314M)   : 0, 6314458
    master (6.223M)   : 0, 6222880

    section Trace stats
    master (6.644M)   : 0, 6644302

    section Manual
    master (9.490M)   : 0, 9490052

    section Manual + Automatic
    This PR (6452) (5.931M)   : 0, 5931157
    master (5.826M)   : 0, 5826117

    section DD_TRACE_ENABLED=0
    master (8.806M)   : 0, 8806093

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6452) (10.045M)   : 0, 10044918
    master (10.038M)   : 0, 10038108
    benchmarks/2.9.0 (10.020M)   : 0, 10019592

    section Automatic
    This PR (6452) (6.731M)   : 0, 6730729
    master (6.759M)   : 0, 6759031
    benchmarks/2.9.0 (7.255M)   : 0, 7255257

    section Trace stats
    master (7.327M)   : 0, 7327150

    section Manual
    master (10.148M)   : 0, 10147695

    section Manual + Automatic
    This PR (6452) (6.243M)   : 0, 6243138
    master (6.270M)   : 0, 6270298

    section DD_TRACE_ENABLED=0
    master (9.572M)   : 0, 9571995

andrewlock · 2024-12-18T03:22:56Z

Benchmarks Report for tracer 🐌

Benchmarks for #6452 compared to master:

1 benchmarks are faster, with geometric mean 1.131
All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	7.96μs	44.9ns	321ns	0.0119	0.00397	0	5.62 KB
master	`StartStopWithChild`	netcoreapp3.1	10.2μs	56.3ns	356ns	0.0204	0.0102	0	5.8 KB
master	`StartStopWithChild`	net472	16.4μs	42.8ns	166ns	1.05	0.314	0.0966	6.2 KB
#6452	`StartStopWithChild`	net6.0	8.12μs	44.8ns	261ns	0.0156	0.00781	0	5.61 KB
#6452	`StartStopWithChild`	netcoreapp3.1	10.2μs	55.6ns	319ns	0.0206	0.0103	0	5.8 KB
#6452	`StartStopWithChild`	net472	16.6μs	70.7ns	274ns	1.07	0.328	0.107	6.22 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	481μs	450ns	1.62μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	640μs	296ns	1.15μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	847μs	887ns	3.32μs	0.425	3.3 KB
#6452	`WriteAndFlushEnrichedTraces`	net6.0	486μs	162ns	582ns	0	2.7 KB
#6452	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	651μs	806ns	3.12μs	0	2.7 KB
#6452	`WriteAndFlushEnrichedTraces`	net472	842μs	364ns	1.41μs	0.419	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	156μs	893ns	6.8μs	0.143	14.47 KB
master	`SendRequest`	netcoreapp3.1	180μs	1.24μs	12.3μs	0.171	17.27 KB
master	`SendRequest`	net472	0.00296ns	0.00117ns	0.00453ns	0	0 b
#6452	`SendRequest`	net6.0	162μs	1.09μs	10.6μs	0.157	14.47 KB
#6452	`SendRequest`	netcoreapp3.1	176μs	1.16μs	11.2μs	0.167	17.27 KB
#6452	`SendRequest`	net472	0.000899ns	0.000485ns	0.00188ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	565μs	3.1μs	19.1μs	0.296	0	0	41.66 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	707μs	4.14μs	39.3μs	0.331	0	0	41.79 KB
master	`WriteAndFlushEnrichedTraces`	net472	835μs	4.16μs	17.7μs	8.75	2.5	0.417	53.27 KB
#6452	`WriteAndFlushEnrichedTraces`	net6.0	587μs	3.29μs	21.1μs	0.566	0	0	41.68 KB
#6452	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	668μs	3.44μs	16.1μs	0.332	0	0	41.93 KB
#6452	`WriteAndFlushEnrichedTraces`	net472	839μs	3.81μs	14.8μs	8.45	2.53	0.422	53.27 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteNonQuery`	net6.0	1.27μs	1.79ns	6.94ns	0.0142	0	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.79μs	1.89ns	7.08ns	0.0135	0	1.02 KB
master	`ExecuteNonQuery`	net472	2.19μs	3.96ns	15.3ns	0.156	0.00109	987 B
#6452	`ExecuteNonQuery`	net6.0	1.39μs	2.1ns	8.14ns	0.0145	0	1.02 KB
#6452	`ExecuteNonQuery`	netcoreapp3.1	1.74μs	1.02ns	3.82ns	0.0138	0	1.02 KB
#6452	`ExecuteNonQuery`	net472	2.05μs	1.95ns	7.55ns	0.157	0.00102	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.22μs	0.52ns	1.95ns	0.0135	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.53μs	0.756ns	2.83ns	0.013	976 B
master	`CallElasticsearch`	net472	2.53μs	0.959ns	3.59ns	0.157	995 B
master	`CallElasticsearchAsync`	net6.0	1.35μs	0.886ns	3.43ns	0.0134	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.63μs	3.03ns	11.3ns	0.0138	1.02 KB
master	`CallElasticsearchAsync`	net472	2.64μs	0.953ns	3.44ns	0.167	1.05 KB
#6452	`CallElasticsearch`	net6.0	1.25μs	0.729ns	2.63ns	0.0139	976 B
#6452	`CallElasticsearch`	netcoreapp3.1	1.49μs	0.857ns	3.21ns	0.0129	976 B
#6452	`CallElasticsearch`	net472	2.4μs	0.855ns	2.96ns	0.158	995 B
#6452	`CallElasticsearchAsync`	net6.0	1.29μs	0.563ns	2.18ns	0.013	952 B
#6452	`CallElasticsearchAsync`	netcoreapp3.1	1.61μs	0.793ns	2.97ns	0.0137	1.02 KB
#6452	`CallElasticsearchAsync`	net472	2.61μs	2.07ns	8ns	0.167	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6452

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net6.0	1.131	1,404.68	1,242.09

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.4μs	0.816ns	3.16ns	0.0133	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.69μs	0.585ns	2.27ns	0.0126	952 B
master	`ExecuteAsync`	net472	1.83μs	0.365ns	1.37ns	0.145	915 B
#6452	`ExecuteAsync`	net6.0	1.24μs	0.384ns	1.38ns	0.0137	952 B
#6452	`ExecuteAsync`	netcoreapp3.1	1.72μs	1.98ns	7.4ns	0.0127	952 B
#6452	`ExecuteAsync`	net472	1.79μs	1.82ns	7.06ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.51μs	1.11ns	4ns	0.0315	2.31 KB
master	`SendAsync`	netcoreapp3.1	5.26μs	3.27ns	12.7ns	0.0368	2.85 KB
master	`SendAsync`	net472	7.52μs	1.93ns	7.48ns	0.496	3.12 KB
#6452	`SendAsync`	net6.0	4.45μs	1.7ns	6.57ns	0.0319	2.31 KB
#6452	`SendAsync`	netcoreapp3.1	5.4μs	2.97ns	11.1ns	0.0379	2.85 KB
#6452	`SendAsync`	net472	7.3μs	2.05ns	7.96ns	0.494	3.12 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.49μs	0.564ns	2.11ns	0.0232	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.27μs	0.733ns	2.74ns	0.0219	1.64 KB
master	`EnrichedLog`	net472	2.68μs	1.1ns	4.1ns	0.249	1.57 KB
#6452	`EnrichedLog`	net6.0	1.56μs	1.31ns	5.07ns	0.0229	1.64 KB
#6452	`EnrichedLog`	netcoreapp3.1	2.24μs	1.98ns	7.39ns	0.0223	1.64 KB
#6452	`EnrichedLog`	net472	2.63μs	2.53ns	9.81ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	116μs	155ns	559ns	0	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	122μs	224ns	866ns	0.0608	0	4.28 KB
master	`EnrichedLog`	net472	150μs	129ns	498ns	0.675	0.225	4.46 KB
#6452	`EnrichedLog`	net6.0	116μs	262ns	1.01μs	0.0576	0	4.28 KB
#6452	`EnrichedLog`	netcoreapp3.1	122μs	199ns	772ns	0	0	4.28 KB
#6452	`EnrichedLog`	net472	154μs	182ns	704ns	0.687	0.229	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.07μs	1.14ns	4.41ns	0.0309	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.13μs	1.62ns	6.26ns	0.0292	2.2 KB
master	`EnrichedLog`	net472	4.89μs	1.28ns	4.96ns	0.319	2.02 KB
#6452	`EnrichedLog`	net6.0	3μs	0.933ns	3.61ns	0.0301	2.2 KB
#6452	`EnrichedLog`	netcoreapp3.1	4.17μs	1.7ns	6.57ns	0.0291	2.2 KB
#6452	`EnrichedLog`	net472	4.76μs	1.19ns	4.59ns	0.32	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.41μs	1.39ns	5.2ns	0.0162	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.75μs	1.02ns	3.81ns	0.0157	1.14 KB
master	`SendReceive`	net472	2.14μs	1.21ns	4.67ns	0.183	1.16 KB
#6452	`SendReceive`	net6.0	1.45μs	1.17ns	4.54ns	0.0159	1.14 KB
#6452	`SendReceive`	netcoreapp3.1	1.78μs	1.11ns	4.3ns	0.0151	1.14 KB
#6452	`SendReceive`	net472	2.11μs	1.44ns	5.21ns	0.183	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.88μs	3ns	11.6ns	0.0216	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.85μs	3.69ns	14.3ns	0.0213	1.65 KB
master	`EnrichedLog`	net472	4.19μs	2.82ns	10.9ns	0.323	2.04 KB
#6452	`EnrichedLog`	net6.0	2.65μs	0.771ns	2.98ns	0.0225	1.6 KB
#6452	`EnrichedLog`	netcoreapp3.1	3.94μs	1.85ns	7.18ns	0.0215	1.65 KB
#6452	`EnrichedLog`	net472	4.47μs	3.75ns	14ns	0.322	2.04 KB

Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	397ns	0.239ns	0.895ns	0.008	576 B
master	`StartFinishSpan`	netcoreapp3.1	617ns	0.43ns	1.67ns	0.00776	576 B
master	`StartFinishSpan`	net472	704ns	0.203ns	0.785ns	0.0918	578 B
master	`StartFinishScope`	net6.0	558ns	0.432ns	1.67ns	0.0098	696 B
master	`StartFinishScope`	netcoreapp3.1	685ns	0.368ns	1.42ns	0.00942	696 B
master	`StartFinishScope`	net472	897ns	0.523ns	2.03ns	0.104	658 B
#6452	`StartFinishSpan`	net6.0	415ns	0.168ns	0.652ns	0.00809	576 B
#6452	`StartFinishSpan`	netcoreapp3.1	557ns	0.348ns	1.3ns	0.00779	576 B
#6452	`StartFinishSpan`	net472	645ns	0.645ns	2.5ns	0.0917	578 B
#6452	`StartFinishScope`	net6.0	596ns	0.282ns	1.09ns	0.00963	696 B
#6452	`StartFinishScope`	netcoreapp3.1	752ns	0.982ns	3.8ns	0.00918	696 B
#6452	`StartFinishScope`	net472	932ns	0.599ns	2.32ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	615ns	0.399ns	1.54ns	0.00958	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	1μs	0.866ns	3.35ns	0.00899	696 B
master	`RunOnMethodBegin`	net472	1.14μs	1.08ns	4.19ns	0.104	658 B
#6452	`RunOnMethodBegin`	net6.0	628ns	0.306ns	1.18ns	0.00976	696 B
#6452	`RunOnMethodBegin`	netcoreapp3.1	910ns	0.719ns	2.69ns	0.00924	696 B
#6452	`RunOnMethodBegin`	net472	1.09μs	0.833ns	3.23ns	0.104	658 B

kevingosse requested a review from a team as a code owner December 17, 2024 15:56

kevingosse added area:crashtracking type:enhancement Improvement to an existing feature labels Dec 17, 2024

kevingosse force-pushed the kevin/crashtracking_all_the_things branch from b150ebd to 8134672 Compare December 17, 2024 16:04

andrewlock approved these changes Dec 17, 2024

View reviewed changes

kevingosse added 3 commits December 19, 2024 15:01

Add a setting to disable crashtracking filtering

ebdb2b5

Address PR feedback

52e8a11

Update CreatedumpTests.cs

a4f57fc

kevingosse force-pushed the kevin/crashtracking_all_the_things branch from 4c028cc to a4f57fc Compare December 19, 2024 14:01

kevingosse merged commit 757cfba into master Dec 20, 2024
81 of 101 checks passed

kevingosse deleted the kevin/crashtracking_all_the_things branch December 20, 2024 12:33

github-actions bot added this to the vNext-v3 milestone Dec 20, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Crashtracking] Add a setting to disable crashtracking filtering #6452

[Crashtracking] Add a setting to disable crashtracking filtering #6452

kevingosse commented Dec 17, 2024 •

edited

Loading

andrewlock Dec 17, 2024

kevingosse Dec 17, 2024

andrewlock commented Dec 17, 2024 •

edited

Loading

datadog-ddstaging bot commented Dec 17, 2024 •

edited

Loading

andrewlock commented Dec 18, 2024 •

edited

Loading

andrewlock commented Dec 18, 2024 •

edited

Loading

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #6452

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results


		AnsiConsole.WriteLine("Datadog - The crash may have been caused by automatic instrumentation, sending crash report...");
		if (filteringEnabled == "0" \|\| filteringEnabled.Equals("false", StringComparison.OrdinalIgnoreCase))

[Crashtracking] Add a setting to disable crashtracking filtering #6452

[Crashtracking] Add a setting to disable crashtracking filtering #6452

Conversation

kevingosse commented Dec 17, 2024 • edited Loading

Summary of changes

Reason for change

Test coverage

andrewlock Dec 17, 2024

Choose a reason for hiding this comment

kevingosse Dec 17, 2024

Choose a reason for hiding this comment

andrewlock commented Dec 17, 2024 • edited Loading

Execution-Time Benchmarks Report ⏱️

datadog-ddstaging bot commented Dec 17, 2024 • edited Loading

Datadog Report

andrewlock commented Dec 18, 2024 • edited Loading

Throughput/Crank Report ⚡

andrewlock commented Dec 18, 2024 • edited Loading

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #6452

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

kevingosse commented Dec 17, 2024 •

edited

Loading

andrewlock commented Dec 17, 2024 •

edited

Loading

datadog-ddstaging bot commented Dec 17, 2024 •

edited

Loading

andrewlock commented Dec 18, 2024 •

edited

Loading

andrewlock commented Dec 18, 2024 •

edited

Loading