Fix codeql to work on newer version of Ubuntu #6445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area:builds
|
it says so idk maybe we can remove this step entirely ? (until 2026 and the next LTS release |
)
kevingosse
approved these changes
Dec 16, 2024
robertpi
approved these changes
Dec 16, 2024
|
Idk why the azure stuff is not running ? 🤔 |
andrewlock
force-pushed
the
vandonr-patch-1
branch
from
9a5ba7d to
2dbe6d0
Compare
Merged
andrewlock
added a commit
that referenced
this pull request
Dec 17, 2024
## Summary of changes Fix broken github status action ## Reason for change The github status upload is broken, because we're not splitting on `;` as expected ## Implementation details Add missing `export IFS=";"`, accidentally deleted in #6407 ## Test coverage This is the test ## Other details Currently blocking #6445
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since Github updated their runners to use a more recent version of ubuntu, it broke the codeQL job because it couldn't find LLVM using the new version name (
noble).The error we're seeing is
The repository 'http://apt.llvm.org/noble llvm-toolchain-noble-16 Release' does not have a Release file.It turns out Clang-16 is available by default in ubuntu Noble (24.04), so we don't need the script at all and we can just install from apt.
DEBIAN_FRONTEND=noninteractiveis necessary to prevent a prompt from tzdata asking us to choose our timezone.