-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add testing for latest Microsoft.Data.Sqlite #6369
Add testing for latest Microsoft.Data.Sqlite #6369
Conversation
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6369) - mean (69ms) : 66, 71
. : milestone, 69,
master - mean (69ms) : 66, 72
. : milestone, 69,
section CallTarget+Inlining+NGEN
This PR (6369) - mean (979ms) : 949, 1008
. : milestone, 979,
master - mean (981ms) : 961, 1002
. : milestone, 981,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6369) - mean (108ms) : 105, 110
. : milestone, 108,
master - mean (108ms) : 106, 109
. : milestone, 108,
section CallTarget+Inlining+NGEN
This PR (6369) - mean (678ms) : 664, 691
. : milestone, 678,
master - mean (680ms) : 664, 697
. : milestone, 680,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6369) - mean (91ms) : 89, 93
. : milestone, 91,
master - mean (91ms) : 90, 93
. : milestone, 91,
section CallTarget+Inlining+NGEN
This PR (6369) - mean (629ms) : 616, 643
. : milestone, 629,
master - mean (632ms) : 619, 645
. : milestone, 632,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6369) - mean (190ms) : 186, 194
. : milestone, 190,
master - mean (191ms) : 186, 195
. : milestone, 191,
section CallTarget+Inlining+NGEN
This PR (6369) - mean (1,091ms) : 1057, 1125
. : milestone, 1091,
master - mean (1,089ms) : 1059, 1119
. : milestone, 1089,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6369) - mean (276ms) : 272, 281
. : milestone, 276,
master - mean (275ms) : 271, 278
. : milestone, 275,
section CallTarget+Inlining+NGEN
This PR (6369) - mean (868ms) : 844, 893
. : milestone, 868,
master - mean (869ms) : 837, 901
. : milestone, 869,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6369) - mean (266ms) : 262, 269
. : milestone, 266,
master - mean (265ms) : 261, 270
. : milestone, 265,
section CallTarget+Inlining+NGEN
This PR (6369) - mean (854ms) : 810, 898
. : milestone, 854,
master - mean (853ms) : 824, 881
. : milestone, 853,
|
Datadog ReportBranch report: ✅ 0 Failed, 452583 Passed, 2754 Skipped, 19h 36m 25.29s Total Time New Flaky Tests (1)
|
Benchmarks Report for tracer 🐌Benchmarks for #6369 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SpanBenchmark - Slower
|
Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 | 1.135 | 395.67 | 449.28 |
Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net472 | 1.131 | 934.38 | 825.83 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | StartFinishSpan |
net6.0 | 395ns | 0.512ns | 1.84ns | 0.00814 | 0 | 0 | 576 B |
master | StartFinishSpan |
netcoreapp3.1 | 556ns | 2.07ns | 8.01ns | 0.00789 | 0 | 0 | 576 B |
master | StartFinishSpan |
net472 | 724ns | 2.09ns | 8.08ns | 0.0915 | 0 | 0 | 578 B |
master | StartFinishScope |
net6.0 | 540ns | 0.911ns | 3.53ns | 0.00984 | 0 | 0 | 696 B |
master | StartFinishScope |
netcoreapp3.1 | 775ns | 1.25ns | 4.85ns | 0.00926 | 0 | 0 | 696 B |
master | StartFinishScope |
net472 | 934ns | 1.22ns | 4.73ns | 0.104 | 0 | 0 | 658 B |
#6369 | StartFinishSpan |
net6.0 | 449ns | 0.603ns | 2.33ns | 0.00797 | 0 | 0 | 576 B |
#6369 | StartFinishSpan |
netcoreapp3.1 | 591ns | 0.704ns | 2.73ns | 0.00769 | 0 | 0 | 576 B |
#6369 | StartFinishSpan |
net472 | 679ns | 1.21ns | 4.67ns | 0.0916 | 0 | 0 | 578 B |
#6369 | StartFinishScope |
net6.0 | 533ns | 0.475ns | 1.84ns | 0.00977 | 0 | 0 | 696 B |
#6369 | StartFinishScope |
netcoreapp3.1 | 774ns | 2.13ns | 8.25ns | 0.00954 | 0 | 0 | 696 B |
#6369 | StartFinishScope |
net472 | 828ns | 1.61ns | 6.24ns | 0.104 | 0 | 0 | 658 B |
Benchmarks.Trace.TraceAnnotationsBenchmark - Slower ⚠️ Same allocations ✔️
Slower ⚠️ in #6369
Benchmark
diff/base
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0
1.187
576.21
683.71
Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 | 1.187 | 576.21 | 683.71 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | RunOnMethodBegin |
net6.0 | 576ns | 0.608ns | 2.35ns | 0.00977 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
netcoreapp3.1 | 913ns | 1.52ns | 5.9ns | 0.00932 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
net472 | 1.1μs | 1.9ns | 7.37ns | 0.104 | 0 | 0 | 658 B |
#6369 | RunOnMethodBegin |
net6.0 | 684ns | 0.983ns | 3.81ns | 0.00977 | 0 | 0 | 696 B |
#6369 | RunOnMethodBegin |
netcoreapp3.1 | 919ns | 2.24ns | 8.68ns | 0.00923 | 0 | 0 | 696 B |
#6369 | RunOnMethodBegin |
net472 | 997ns | 1.19ns | 4.46ns | 0.104 | 0 | 0 | 658 B |
Throughput/Crank Report ⚡Throughput results for AspNetCoreSimpleController comparing the following branches/commits: Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red. Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards! gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6369) (11.099M) : 0, 11098717
master (11.381M) : 0, 11380797
benchmarks/2.9.0 (11.033M) : 0, 11032866
section Automatic
This PR (6369) (7.322M) : 0, 7321761
master (7.372M) : 0, 7371851
benchmarks/2.9.0 (7.786M) : 0, 7785853
section Trace stats
master (7.651M) : 0, 7651180
section Manual
master (11.409M) : 0, 11409121
section Manual + Automatic
This PR (6369) (6.755M) : 0, 6754533
master (6.820M) : 0, 6819669
section DD_TRACE_ENABLED=0
master (10.284M) : 0, 10284096
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6369) (9.504M) : 0, 9504041
master (9.528M) : 0, 9528332
benchmarks/2.9.0 (9.495M) : 0, 9494821
section Automatic
This PR (6369) (6.326M) : 0, 6325756
master (6.301M) : 0, 6300873
section Trace stats
master (6.689M) : 0, 6689036
section Manual
master (9.357M) : 0, 9356534
section Manual + Automatic
This PR (6369) (5.998M) : 0, 5998013
master (5.894M) : 0, 5894490
section DD_TRACE_ENABLED=0
master (8.921M) : 0, 8920806
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6369) (9.951M) : 0, 9951458
master (9.919M) : 0, 9919361
benchmarks/2.9.0 (10.020M) : 0, 10019592
section Automatic
This PR (6369) (6.445M) : 0, 6444607
master (6.191M) : 0, 6191193
benchmarks/2.9.0 (7.255M) : 0, 7255257
section Trace stats
master (6.913M) : 0, 6912642
section Manual
master (9.741M) : 0, 9741372
section Manual + Automatic
This PR (6369) (5.776M) : 0, 5776307
master (5.793M) : 0, 5793028
section DD_TRACE_ENABLED=0
master (9.131M) : 0, 9130759
|
## Summary of changes Update the test app versions to include 9.0.0 ## Reason for change We want to test the latest package versions ## Implementation details Bumped the supported package versions, and re-generated. I dropped explicit testing of a few of the intermediate versions just to reduce the load ## Test coverage More ## Other details Also updates the supported versions in some cases where the json should have already been updated https://datadoghq.atlassian.net/browse/AIDM-502
Summary of changes
Update the test app versions to include 9.0.0
Reason for change
We want to test the latest package versions
Implementation details
Bumped the supported package versions, and re-generated. I dropped explicit testing of a few of the intermediate versions just to reduce the load
Test coverage
More
Other details
Also updates the supported versions in some cases where the json should have already been updated
https://datadoghq.atlassian.net/browse/AIDM-502