[CI Visibility] Specify if the user is setting the DD_SERVICE #6348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datadog ReportBranch report: ✅ 0 Failed, 454159 Passed, 2765 Skipped, 18h 47m 53.1s Total Time |
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6348) - mean (76ms) : 72, 81
. : milestone, 76,
master - mean (69ms) : 67, 70
. : milestone, 69,
section CallTarget+Inlining+NGEN
This PR (6348) - mean (1,029ms) : 998, 1060
. : milestone, 1029,
master - mean (975ms) : 954, 996
. : milestone, 975,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6348) - mean (118ms) : 112, 124
. : milestone, 118,
master - mean (108ms) : 105, 110
. : milestone, 108,
section CallTarget+Inlining+NGEN
This PR (6348) - mean (720ms) : crit, 699, 740
. : crit, milestone, 720,
master - mean (679ms) : 666, 691
. : milestone, 679,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6348) - mean (102ms) : 96, 108
. : milestone, 102,
master - mean (91ms) : 88, 94
. : milestone, 91,
section CallTarget+Inlining+NGEN
This PR (6348) - mean (671ms) : crit, 655, 688
. : crit, milestone, 671,
master - mean (630ms) : 615, 646
. : milestone, 630,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6348) - mean (191ms) : 186, 197
. : milestone, 191,
master - mean (190ms) : 186, 194
. : milestone, 190,
section CallTarget+Inlining+NGEN
This PR (6348) - mean (1,097ms) : 1069, 1126
. : milestone, 1097,
master - mean (1,094ms) : 1064, 1124
. : milestone, 1094,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6348) - mean (277ms) : 271, 283
. : milestone, 277,
master - mean (277ms) : 272, 282
. : milestone, 277,
section CallTarget+Inlining+NGEN
This PR (6348) - mean (881ms) : 847, 914
. : milestone, 881,
master - mean (871ms) : 837, 906
. : milestone, 871,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6348) - mean (266ms) : 262, 271
. : milestone, 266,
master - mean (266ms) : 261, 271
. : milestone, 266,
section CallTarget+Inlining+NGEN
This PR (6348) - mean (847ms) : 819, 875
. : milestone, 847,
master - mean (851ms) : 810, 893
. : milestone, 851,
|
Throughput/Crank Report ⚡Throughput results for AspNetCoreSimpleController comparing the following branches/commits: Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red. Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards! gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6348) (11.274M) : 0, 11273604
master (11.288M) : 0, 11287537
benchmarks/2.9.0 (11.033M) : 0, 11032866
section Automatic
This PR (6348) (7.362M) : 0, 7362284
master (7.368M) : 0, 7368175
benchmarks/2.9.0 (7.786M) : 0, 7785853
section Trace stats
master (7.646M) : 0, 7646067
section Manual
master (11.262M) : 0, 11262396
section Manual + Automatic
This PR (6348) (6.775M) : 0, 6774642
master (6.845M) : 0, 6845270
section DD_TRACE_ENABLED=0
master (10.394M) : 0, 10394282
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6348) (9.627M) : 0, 9627437
master (9.359M) : 0, 9359375
benchmarks/2.9.0 (9.495M) : 0, 9494821
section Automatic
This PR (6348) (6.473M) : 0, 6473498
master (6.383M) : 0, 6382524
section Trace stats
master (6.787M) : 0, 6787327
section Manual
master (9.600M) : 0, 9600108
section Manual + Automatic
This PR (6348) (6.033M) : 0, 6032636
master (5.904M) : 0, 5903521
section DD_TRACE_ENABLED=0
master (8.752M) : 0, 8752034
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6348) (8.943M) : 0, 8943015
master (8.888M) : 0, 8887744
benchmarks/2.9.0 (10.020M) : 0, 10019592
section Automatic
This PR (6348) (5.849M) : 0, 5848967
master (5.904M) : 0, 5903587
benchmarks/2.9.0 (7.255M) : 0, 7255257
section Trace stats
master (6.431M) : 0, 6430906
section Manual
master (8.868M) : 0, 8868234
section Manual + Automatic
This PR (6348) (5.334M) : 0, 5334246
master (5.541M) : 0, 5540896
section DD_TRACE_ENABLED=0
master (8.290M) : 0, 8289928
|
Benchmarks Report for tracer 🐌Benchmarks for #6348 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️Raw results
|
Snapshots difference summaryThe following differences have been observed in committed snapshots. It is meant to help the reviewer. 1521 occurrences of : + _dd.test.is_user_provided_service: true
|
andrewlock
approved these changes
Nov 26, 2024
| @@ -134,6 +135,11 @@ public static void Initialize() | |||
| { | |||
| // Extract repository name from the git url and use it as a default service name. | |||
| tracerSettings.ServiceNameInternal = GetServiceNameFromRepository(CIEnvironmentValues.Instance.Repository); | |||
| tracerSettings.GlobalTagsInternal[CommonTags.UserProvidedTestServiceTag] = "false"; | |||
There was a problem hiding this comment.
Just a thought, given this is added to every span, maybe you want to add it as part of the serialization directly instead?
There was a problem hiding this comment.
Good idea, I'll do that in a different optimization PR though
veerbia
pushed a commit
that referenced
this pull request
Dec 16, 2024
## Summary of changes
This PR sets a tag to let the ci visibility backend know if the
DD_SERVICE value was provided by the user or auto-generated.
## Reason for change
This required by the backend.
## Test coverage
- Updated snapshots.
- Fixed tests
## Other details
<!-- Fixes #{issue} -->
<!-- ⚠️ Note: where possible, please obtain 2 approvals prior to
merging. Unless CODEOWNERS specifies otherwise, for external teams it is
typically best to have one review from a team member, and one review
from apm-dotnet. Trivial changes do not require 2 reviews. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This PR sets a tag to let the ci visibility backend know if the DD_SERVICE value was provided by the user or auto-generated.
Reason for change
This required by the backend.
Test coverage
Other details