-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop hiding build files in github search #6299
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
THANK YOU
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6299) - mean (72ms) : 63, 81
. : milestone, 72,
master - mean (72ms) : 64, 80
. : milestone, 72,
section CallTarget+Inlining+NGEN
This PR (6299) - mean (1,108ms) : 1091, 1125
. : milestone, 1108,
master - mean (1,107ms) : 1085, 1128
. : milestone, 1107,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6299) - mean (108ms) : 104, 112
. : milestone, 108,
master - mean (108ms) : 106, 110
. : milestone, 108,
section CallTarget+Inlining+NGEN
This PR (6299) - mean (771ms) : 755, 787
. : milestone, 771,
master - mean (771ms) : 757, 785
. : milestone, 771,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6299) - mean (92ms) : 90, 94
. : milestone, 92,
master - mean (92ms) : 90, 93
. : milestone, 92,
section CallTarget+Inlining+NGEN
This PR (6299) - mean (725ms) : 712, 738
. : milestone, 725,
master - mean (726ms) : 707, 745
. : milestone, 726,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6299) - mean (192ms) : 186, 197
. : milestone, 192,
master - mean (191ms) : 186, 195
. : milestone, 191,
section CallTarget+Inlining+NGEN
This PR (6299) - mean (1,218ms) : 1193, 1242
. : milestone, 1218,
master - mean (1,213ms) : 1190, 1236
. : milestone, 1213,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6299) - mean (280ms) : 274, 285
. : milestone, 280,
master - mean (276ms) : 271, 281
. : milestone, 276,
section CallTarget+Inlining+NGEN
This PR (6299) - mean (953ms) : 934, 972
. : milestone, 953,
master - mean (948ms) : 929, 967
. : milestone, 948,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6299) - mean (269ms) : 266, 272
. : milestone, 269,
master - mean (265ms) : 261, 270
. : milestone, 265,
section CallTarget+Inlining+NGEN
This PR (6299) - mean (938ms) : 919, 956
. : milestone, 938,
master - mean (931ms) : 913, 950
. : milestone, 931,
|
Datadog ReportBranch report: ✅ 0 Failed, 447186 Passed, 2734 Skipped, 19h 20m 11.97s Total Time ⌛ Performance Regressions vs Default Branch (1)
|
Benchmarks Report for tracer 🐌Benchmarks for #6299 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.RedisBenchmark - Slower
|
Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.RedisBenchmark.SendReceive‑net6.0 | 1.128 | 1,326.93 | 1,496.24 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | SendReceive |
net6.0 | 1.33μs | 0.648ns | 2.42ns | 0.016 | 0 | 0 | 1.14 KB |
master | SendReceive |
netcoreapp3.1 | 1.72μs | 0.684ns | 2.56ns | 0.015 | 0 | 0 | 1.14 KB |
master | SendReceive |
net472 | 2.13μs | 1.38ns | 4.96ns | 0.183 | 0 | 0 | 1.16 KB |
#6299 | SendReceive |
net6.0 | 1.5μs | 0.811ns | 3.14ns | 0.0157 | 0 | 0 | 1.14 KB |
#6299 | SendReceive |
netcoreapp3.1 | 1.78μs | 0.746ns | 2.89ns | 0.0152 | 0 | 0 | 1.14 KB |
#6299 | SendReceive |
net472 | 2.1μs | 1.45ns | 5.62ns | 0.183 | 0 | 0 | 1.16 KB |
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | EnrichedLog |
net6.0 | 2.79μs | 1.43ns | 5.54ns | 0.0223 | 0 | 0 | 1.6 KB |
master | EnrichedLog |
netcoreapp3.1 | 3.96μs | 1.16ns | 4.49ns | 0.0217 | 0 | 0 | 1.65 KB |
master | EnrichedLog |
net472 | 4.34μs | 2.77ns | 10.4ns | 0.323 | 0 | 0 | 2.04 KB |
#6299 | EnrichedLog |
net6.0 | 2.9μs | 0.755ns | 2.92ns | 0.0217 | 0 | 0 | 1.6 KB |
#6299 | EnrichedLog |
netcoreapp3.1 | 3.83μs | 3.36ns | 13ns | 0.0211 | 0 | 0 | 1.65 KB |
#6299 | EnrichedLog |
net472 | 4.29μs | 2.01ns | 7.78ns | 0.322 | 0 | 0 | 2.04 KB |
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️
Slower ⚠️ in #6299
Benchmark
diff/base
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472
1.224
578.53
708.14
Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472 | 1.224 | 578.53 | 708.14 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | StartFinishSpan |
net6.0 | 399ns | 0.654ns | 2.53ns | 0.00807 | 0 | 0 | 576 B |
master | StartFinishSpan |
netcoreapp3.1 | 550ns | 0.669ns | 2.59ns | 0.00767 | 0 | 0 | 576 B |
master | StartFinishSpan |
net472 | 578ns | 0.705ns | 2.73ns | 0.0916 | 0 | 0 | 578 B |
master | StartFinishScope |
net6.0 | 472ns | 0.652ns | 2.53ns | 0.00971 | 0 | 0 | 696 B |
master | StartFinishScope |
netcoreapp3.1 | 675ns | 0.648ns | 2.51ns | 0.00909 | 0 | 0 | 696 B |
master | StartFinishScope |
net472 | 920ns | 0.861ns | 3.34ns | 0.104 | 0 | 0 | 658 B |
#6299 | StartFinishSpan |
net6.0 | 403ns | 0.562ns | 2.18ns | 0.00815 | 0 | 0 | 576 B |
#6299 | StartFinishSpan |
netcoreapp3.1 | 567ns | 0.895ns | 3.47ns | 0.00778 | 0 | 0 | 576 B |
#6299 | StartFinishSpan |
net472 | 709ns | 1.35ns | 5.22ns | 0.0917 | 0 | 0 | 578 B |
#6299 | StartFinishScope |
net6.0 | 485ns | 0.938ns | 3.63ns | 0.00985 | 0 | 0 | 696 B |
#6299 | StartFinishScope |
netcoreapp3.1 | 729ns | 1.25ns | 4.84ns | 0.00952 | 0 | 0 | 696 B |
#6299 | StartFinishScope |
net472 | 899ns | 1.17ns | 4.21ns | 0.104 | 0 | 0 | 658 B |
Benchmarks.Trace.TraceAnnotationsBenchmark - Faster 🎉 Same allocations ✔️
Faster 🎉 in #6299
Benchmark
base/diff
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0
1.125
661.45
588.00
Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 | 1.125 | 661.45 | 588.00 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | RunOnMethodBegin |
net6.0 | 660ns | 0.927ns | 3.59ns | 0.00968 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
netcoreapp3.1 | 937ns | 2.1ns | 8.15ns | 0.00935 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
net472 | 1.12μs | 2.23ns | 8.64ns | 0.104 | 0 | 0 | 658 B |
#6299 | RunOnMethodBegin |
net6.0 | 587ns | 1.01ns | 3.92ns | 0.00965 | 0 | 0 | 696 B |
#6299 | RunOnMethodBegin |
netcoreapp3.1 | 901ns | 0.835ns | 3.12ns | 0.0093 | 0 | 0 | 696 B |
#6299 | RunOnMethodBegin |
net472 | 1.08μs | 1.13ns | 4.08ns | 0.104 | 0 | 0 | 658 B |
Throughput/Crank Report ⚡Throughput results for AspNetCoreSimpleController comparing the following branches/commits: Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red. Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards! gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6299) (11.229M) : 0, 11229089
master (11.088M) : 0, 11087997
benchmarks/2.9.0 (11.033M) : 0, 11032866
section Automatic
This PR (6299) (7.231M) : 0, 7230645
master (7.189M) : 0, 7189433
benchmarks/2.9.0 (7.786M) : 0, 7785853
section Trace stats
master (7.540M) : 0, 7540032
section Manual
master (10.979M) : 0, 10978609
section Manual + Automatic
This PR (6299) (6.796M) : 0, 6796226
master (6.705M) : 0, 6704874
section DD_TRACE_ENABLED=0
master (10.210M) : 0, 10210338
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6299) (9.594M) : 0, 9594483
master (9.281M) : 0, 9280802
benchmarks/2.9.0 (9.495M) : 0, 9494821
section Automatic
This PR (6299) (6.304M) : 0, 6303853
master (6.361M) : 0, 6360955
section Trace stats
master (6.592M) : 0, 6591771
section Manual
master (9.244M) : 0, 9244472
section Manual + Automatic
This PR (6299) (5.919M) : 0, 5918564
master (5.916M) : 0, 5915508
section DD_TRACE_ENABLED=0
master (8.775M) : 0, 8774768
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6299) (9.526M) : 0, 9526425
master (9.738M) : 0, 9737778
benchmarks/2.9.0 (10.020M) : 0, 10019592
section Automatic
This PR (6299) (6.098M) : 0, 6097814
master (6.366M) : 0, 6366399
benchmarks/2.9.0 (7.255M) : 0, 7255257
section Trace stats
master (6.991M) : 0, 6990849
section Manual
master (9.876M) : 0, 9876192
section Manual + Automatic
This PR (6299) (5.587M) : 0, 5587389
master (5.693M) : 0, 5692584
section DD_TRACE_ENABLED=0
master (9.017M) : 0, 9017039
|
c06ae7a
to
65d8e20
Compare
Summary of changes
By default, when using the "Go to file" on Github, files in a
build
folder or subfolder are excluded. This PR removes the exclusion.Reason for change
Keeping my (our?) sanity.
Implementation details
Apparently we control this by editing the
.gitattributes
file: https://docs.github.com/en/search-github/searching-on-github/finding-files-on-github#customizing-excluded-files