-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RUM-7018] RN Image Recording Support #2435
base: jmoskovich/rum-6195/caches-any-key
Are you sure you want to change the base?
[RUM-7018] RN Image Recording Support #2435
Conversation
1eefd82
to
6b6e99d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## jmoskovich/rum-6195/caches-any-key #2435 +/- ##
======================================================================
- Coverage 70.24% 69.79% -0.45%
======================================================================
Files 767 768 +1
Lines 28513 28517 +4
Branches 4782 4781 -1
======================================================================
- Hits 20028 19902 -126
- Misses 7149 7277 +128
- Partials 1336 1338 +2
|
56c49e9
to
ebafe41
Compare
5f5d088
to
7d66065
Compare
7d66065
to
881456a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the drawOnCanvas
copying of the drawables, it should be safe as the only place that references it in the call chain looks like it already copies the drawable. The methods that are protected I think it's enough indication that they are internal. Regarding the ImageViewUtils
, if we can move it to the internal module and you can access it from there it will probably be the best solution
...datadog/android/sessionreplay/internal/recorder/resources/DefaultImageWireframeHelperTest.kt
Outdated
Show resolved
Hide resolved
...datadog/android/sessionreplay/internal/recorder/resources/DefaultImageWireframeHelperTest.kt
Outdated
Show resolved
Hide resolved
...datadog/android/sessionreplay/internal/recorder/resources/DefaultImageWireframeHelperTest.kt
Outdated
Show resolved
Hide resolved
customResourceIdCacheKey = null, | ||
asyncJobStatusCallback = mockAsyncJobStatusCallback | ||
) | ||
wireframes[0] as MobileSegment.Wireframe.ImageWireframe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
result is not stored anywhere, is it expected?
...datadog/android/sessionreplay/internal/recorder/resources/DefaultImageWireframeHelperTest.kt
Outdated
Show resolved
Hide resolved
...datadog/android/sessionreplay/internal/recorder/resources/DefaultImageWireframeHelperTest.kt
Outdated
Show resolved
Hide resolved
...datadog/android/sessionreplay/internal/recorder/resources/DefaultImageWireframeHelperTest.kt
Outdated
Show resolved
Hide resolved
...datadog/android/sessionreplay/internal/recorder/resources/DefaultImageWireframeHelperTest.kt
Outdated
Show resolved
Hide resolved
...replay/src/test/kotlin/com/datadog/android/sessionreplay/internal/utils/DrawableUtilsTest.kt
Outdated
Show resolved
Hide resolved
...ion-replay/src/main/kotlin/com/datadog/android/sessionreplay/internal/utils/DrawableUtils.kt
Outdated
Show resolved
Hide resolved
I had to do some refactoring to move the ImageViewUtils to the dd-sdk-android-internal package, because the class was relying on Session Replay |
c510e0e
to
f602b9b
Compare
...replay/src/test/kotlin/com/datadog/android/sessionreplay/internal/utils/DrawableUtilsTest.kt
Outdated
Show resolved
Hide resolved
cf032ee
to
adb475d
Compare
adb475d
to
bf7e7da
Compare
What does this PR do?
This PR introduces changes required for granting support to new Session Replay features on React Native.
What changed
Open Points
drawOnCanvas
(see comments)BaseAsyncBackgroundWireframeMapper
now exposes some methods asprotected open
. Should we add clues that they are only intended for internal usage? What's the best way to do that?ImageViewUtils
? We currently re-use most of it in React Native and perhaps we could avoid duplicating that codeTODO
Review checklist (to be filled by reviewers)