Merged
Conversation
7580433 to
cc345f5
Compare
4e49c33 to
c288005
Compare
7c45b8e to
0903004
Compare
a3ab067 to
7fe648d
Compare
Gandem
reviewed
Aug 18, 2025
| totalSampleCount += stats.totalSampleCount | ||
| totalPIDsWithNoProcessMetadata += stats.pidWithNoMetadata | ||
| tags := createTagsForProfile(r.tags, profileSeq, e.service, e.inferredService) | ||
| for e, perServiceEvents := range reportedEvents { |
Member
There was a problem hiding this comment.
Nit: rename e to s since it's the service entity attributes
0903004 to
3705ec0
Compare
7fe648d to
107eac4
Compare
* Use a unique dummy mapping * Use "kernel" as the source file for kernel frames
107eac4 to
e35e964
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Store trace events in a tree (similar to open-telemetry/opentelemetry-ebpf-profiler#528):
[ContainerId, Service] -> [Origin] (CPU,OffCPU,...) -> [Hash,Comm,Pid,Tid]This makes emitting profile by service easier since events are already split by service.
This moves service determination from reporting time to trace event collection time, meaning that changes to process metadata (eg. exe name) will not be taken into account for already collected traces.
Also:
executablePathandapmServiceNamefromTraceAndMetaKeysince they were not used./proc/<pid>/exeinaddProcessMetadataif successfulTraceEventMeta.ExecutablePathif not emptyTraceAndMetaKey.Comm: since it's retrieved by eBPF it can be non empty even ifTraceAndMetaKey.ProcessNameis empty