Skip to content
This repository has been archived by the owner on Sep 23, 2024. It is now read-only.

[feat]: add resource labels attribs as span tags and use service.name #6

Merged
merged 1 commit into from
Sep 18, 2020

Conversation

ericmustin
Copy link
Contributor

This PR Adds the Resource labels as span tags, and also uses the more canonical resource service.name to set the span's service when it exists.

This work brings us closer to the spec of how OTEL service naming should work, and it's a pattern that's been addressed in other vendor/backend specific exporters

Work following this will be to ensure our documentation is appropriate for onboarding as well

@ericmustin ericmustin added the enhancement New feature or request label Sep 18, 2020
@ericmustin ericmustin self-assigned this Sep 18, 2020
@ericmustin ericmustin merged commit 9bd1751 into master Sep 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant