-
Notifications
You must be signed in to change notification settings - Fork 394
[AWSX-1559] feat: update Python version to 3.13 #924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sanassi-cisse
merged 10 commits into
master
from
sanassi.morycisse/AWSX-1559-ktlo-logs-forwarder-support-python-3.13
Jul 23, 2025
Merged
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
af860ef
[AWSX-1559] feat: update Python version to 3.13
sanassi-cisse 2666be4
[AWSX-1559] feat: update version
sanassi-cisse 85aef8c
[AWSX-1559] chore: update version
sanassi-cisse 96fea8e
[AWSX-1559] feat: bump cfn-lint to 1.19.0
sanassi-cisse 115f375
[AWSX-1559] feat: use ddtrace v3.0.0
sanassi-cisse fd62126
[AWSX-1559] chore: update python version in docs
sanassi-cisse 331ca54
[AWSX-1559] chore: set ddtrace version to 3.0.0 instead of >=
sanassi-cisse 9779472
[AWSX-1559] refactor: update requirements for ddd-lambda, dd, ddtrace
sanassi-cisse 365a4c6
[AWSX-1559] chore: update version in docs for next forwarder version
sanassi-cisse d1ae1f4
[AWSX-1559] refactor: apply doc suggestion
sanassi-cisse File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -115,7 +115,7 @@ resource "aws_cloudformation_stack" "datadog_forwarder" { | |
|
|
||
| If you can't install the Forwarder using the provided CloudFormation template, you can install the Forwarder manually following the steps below. Feel free to open an issue or pull request to let us know if there is anything we can improve to make the template work for you. | ||
|
|
||
| 1. Create a Python 3.12 Lambda function using `aws-dd-forwarder-<VERSION>.zip` from the latest [releases][101]. | ||
| 1. Create a Python 3.13 Lambda function using `aws-dd-forwarder-<VERSION>.zip` from the latest [releases][101]. | ||
| 2. Save your [Datadog API key][102] in AWS Secrets Manager, set environment variable `DD_API_KEY_SECRET_ARN` with the secret ARN on the Lambda function, and add the `secretsmanager:GetSecretValue` permission to the Lambda execution role. | ||
| 3. If you need to forward logs from S3 buckets, add the `s3:GetObject` permission to the Lambda execution role. | ||
| 4. Set the environment variable `DD_ENHANCED_METRICS` to `false` on the Forwarder. This stops the Forwarder from generating enhanced metrics itself, but it will still forward custom metrics from other lambdas.DdFetchLambdaTags | ||
|
|
@@ -148,8 +148,11 @@ The <a href="#cloudformation-parameters">environment variables provided on this | |
|
|
||
| If you encounter issues upgrading to the latest version, check the Troubleshooting section. | ||
|
|
||
| ### Upgrade an older verison to 4.12.0+ | ||
| The supported Python version of this release is 3.13. | ||
|
|
||
| ### Upgrade an older verison to 4.3.0+ | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please add a new entry targeting version 4.12.0+ |
||
| Starting verison 4.3.0 Lambda forwarder will support a single python version only. The supported Python version of this release is 3.12. | ||
| Starting verison 4.3.0 Lambda forwarder will support a single python version only. The supported Python version of this release is 3.12. | ||
|
|
||
| ### Upgrade an older version to +4.0.0 | ||
| Starting version 4.0.0 `source`, `service` and `host` identification logic will be pulled out from the Lambda forwarder's code and set in directly in Datadog's backend. The first migrated log source is `RDS`. | ||
|
|
@@ -748,7 +751,7 @@ The value of the `service` tag is determined based on multiple inputs. These inp | |
| 1. Log message custom tags: If the log message has a `ddtags` key which contains a `service` tag value, it will be used to override the `service` tag in the log event. | ||
| 2. Lambda tags cache (applicable for Lambda logs only): Activating `DdFetchLambdaTags` will fetch and store all Lambda functions tags and will override the `service` tag if it wasn't set previously or was set to a default value i.e. `source` value. | ||
| 3. Cloudwatch log group tags cache (applicable for Cloudwatch logs only): Activating `DdFetchLogGroupTags` will fetch and store all Cloudwatch log groups tags which are added to the `ddtags` entry in the log event. If `service` tag value was set in the tags cache it will be used to set the `service` tag for the log event. | ||
| 4. Directly setting a `service` tag value in the forwarder's `ddtags` ENV var. | ||
| 4. Directly setting a `service` tag value in the forwarder's `ddtags` ENV var. | ||
| 5. Default value equal to the `source` tag. | ||
|
|
||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,10 +12,10 @@ | |
| author="Datadog, Inc.", | ||
| author_email="[email protected]", | ||
| classifiers=[ | ||
| "Programming Language :: Python :: 3.12", | ||
| "Programming Language :: Python :: 3.13", | ||
| ], | ||
| keywords="datadog aws lambda layer", | ||
| python_requires=">=3.12, <3.13", | ||
| python_requires=">=3.13, <3.14", | ||
| extras_require={ | ||
| "dev": ["nose2==0.9.1", "flake8==3.7.9", "requests==2.22.0", "boto3==1.10.33"] | ||
| }, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
aws/logs_monitoring/tools/integration_tests/cache_test_lambda/serverless.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion