Skip to content

Conversation

@ViBiOh
Copy link
Contributor

@ViBiOh ViBiOh commented Mar 17, 2025

What does this PR do?

Remove the S3 ARN identification for S3 Access Logs, moved to backend.

Motivation

Remove business logic from the forwarder to have it centralized in the backend.

Testing Guidelines

Additional Notes

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)
  • This PR passes the unit tests
  • This PR passes the installation tests (ask a Datadog member to run the tests)

@ViBiOh ViBiOh requested a review from a team as a code owner March 17, 2025 17:36
@github-actions github-actions bot added the aws label Mar 17, 2025
Copy link
Contributor

@ge0Aja ge0Aja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ge0Aja ge0Aja self-assigned this Mar 21, 2025
@ViBiOh ViBiOh merged commit 145ea9f into master Mar 28, 2025
10 checks passed
@ViBiOh ViBiOh deleted the vibioh/AWSX-1389_remove_s3_arn_as_host branch March 28, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants