Add Ruby 4.0.0-preview2 headers #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes DataDog#17 Along the same lines as 852162a, this commit imports the Ruby 4.0.0-preview2 headers into the gem. ** Motivation ** It's not possible to install this gem on 4.0.0-preview2 without these headers. Falling back to 3.5.0-preview1 does not work, since there is an ABI change in shape.h ** How to test the change? ** Adding these headers allowed me to install the gem on Ruby 4.0.0-preview2. I guess we'll eventually want dd-trace-rb CI to run against Ruby 4.0.
ivoanjo
added a commit
that referenced
this pull request
Nov 25, 2025
**What does this PR do?** This PR bumps the gem version to 3.4.2 in preparation for releasing Ruby 4.0.0-preview2 support (added in #18). It also updates the `test-compilation.yml` checks to run with Ruby 4. **Motivation:** Release a new version with support for 4.0.0-preview2. **Additional Notes:** **How to test the change?** The CI check validates this change + I've tested it locally by running `bundle exec rake package`, installing the result, and then confirming the profiler successfully builds with it (tested Ruby 3.4 and 4.0 manually).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17
Along the same lines as 852162a, this commit imports the Ruby 4.0.0-preview2 headers into the gem.
Motivation
It's not possible to install this gem on 4.0.0-preview2 without these headers. Falling back to 3.5.0-preview1 does not work, since there is an ABI change affecting shape.h
How to test the change?
Adding these headers allowed me to install the gem on Ruby 4.0.0-preview2. I guess we'll eventually want dd-trace-rb CI to run against Ruby 4.0.