-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Remove requests and all its dependencies. #547
Changes from all commits
b937626
5182136
92baaf6
992e388
1a60db4
ef66ae7
4d066d7
659faf8
a9a86dc
b1f0490
4ab59df
c719f58
358fd4d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,6 @@ | ||
{ | ||
"devDependencies": { | ||
"serverless-plugin-datadog": "^2.18.0" | ||
"serverless-plugin-datadog": "^2.18.0", | ||
"serverless-python-requirements": "^6.1.1" | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
certifi==2024.12.14 | ||
charset-normalizer==3.4.1 | ||
idna==3.10 | ||
requests==2.32.3 |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,6 +20,21 @@ provider: | |
iam: | ||
# IAM permissions require that all functions are deployed with this role | ||
role: "arn:aws:iam::425362996713:role/serverless-integration-test-lambda-role" | ||
layers: | ||
- { Ref: PythonLambdaLayer } | ||
- { Ref: PythonRequirementsLambdaLayer } | ||
|
||
plugins: | ||
- serverless-python-requirements | ||
|
||
custom: | ||
pythonRequirements: | ||
pythonBin: python3 | ||
pipCmdExtraArgs: | ||
- --no-deps # install just requests | ||
layer: | ||
compatibleRuntimes: | ||
- ${env:SERVERLESS_RUNTIME} | ||
Comment on lines
+25
to
+37
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why do we need to add new requirements? Could you give me a brief explanation so I understand it? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We removed There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks! I imagine these are the ones that ping URLs? |
||
|
||
layers: | ||
python: | ||
|
@@ -32,8 +47,6 @@ functions: | |
name: integration-tests-python-${sls:stage}-async-metrics_${env:RUNTIME} | ||
handler: handle.handle | ||
runtime: ${env:SERVERLESS_RUNTIME} | ||
layers: | ||
- { Ref: PythonLambdaLayer } | ||
environment: | ||
DD_FLUSH_TO_LOG: true | ||
|
||
|
@@ -42,5 +55,3 @@ functions: | |
name: integration-tests-python-${sls:stage}-sync-metrics_${env:RUNTIME} | ||
handler: handle.handle | ||
runtime: ${env:SERVERLESS_RUNTIME} | ||
layers: | ||
- { Ref: PythonLambdaLayer } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't we also need to run a
poetry update
to refresh the poetry lock file?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh good call