Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SVLS-5265] S3 Event Handler Span Pointers #513

Merged

Conversation

apiarian-datadog
Copy link
Contributor

@apiarian-datadog apiarian-datadog commented Sep 18, 2024

What does this PR do?

Adding Span Pointers for the upstream S3 objects when a lambda is triggered by an S3 ObjectCreated event.

Motivation

This is required to support auto-span-linking when S3 objects are used to chain lambda functions together.

Testing Guidelines

Added unit tests.

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@apiarian-datadog
Copy link
Contributor Author

apiarian-datadog commented Sep 27, 2024

This PR somewhat surprisingly passes integration tests. The S3 lambda handler spans do in fact include span pointers, but they're not being serialized in dd-trace-py in the extension-less integration test environment. The extension does ship these span links correctly, though.

We'll follow up with a patch on dd-trace-py to correctly include the span links and then our integration tests here will need to be updated accordingly: DataDog/dd-trace-py#10850

@apiarian-datadog apiarian-datadog marked this pull request as ready for review September 27, 2024 16:41
@apiarian-datadog apiarian-datadog requested a review from a team as a code owner September 27, 2024 16:41
@apiarian-datadog apiarian-datadog merged commit c52970f into main Sep 27, 2024
51 checks passed
@apiarian-datadog apiarian-datadog deleted the aleksandr.pasechnik/svls-5265-s3-event-span-pointers branch September 27, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants