Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rust compiler to base image builder #489

Merged
merged 1 commit into from
May 21, 2024
Merged

Conversation

brettlangdon
Copy link
Member

What does this PR do?

Install rust compiler in the image builder stage.

Motivation

This will be needed in order to build dd-trace-py from source in the future

Testing Guidelines

I updated the pyproject.toml to point to a branch of dd-trace-py which needs a rust compiler.

I then ran the following command to build the image:

docker buildx build -t datadog-lambda-python-amd64 . --no-cache --build-arg "image=python:3.12" --bu
ild-arg "runtime=python3.12" --platform linux/amd64

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

This will be needed in order to build dd-trace-py from source in the future
@brettlangdon brettlangdon requested a review from a team as a code owner May 21, 2024 16:44
@brettlangdon brettlangdon merged commit 4d07a0e into main May 21, 2024
58 checks passed
@brettlangdon brettlangdon deleted the brettlangdon/add.rustc branch May 21, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants