Prevent function crash when setting unknown log level. #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duncanista
reviewed
Feb 14, 2024
purple4reina
force-pushed
the
rey.abolofia/loglevels
branch
from
a5077e5
to
4e5d3e5
Compare
purple4reina
force-pushed
the
rey.abolofia/loglevels
branch
2 times, most recently
from
85e5f50
to
b9e7f05
Compare
purple4reina
force-pushed
the
rey.abolofia/loglevels
branch
from
b9e7f05
to
16d2bde
Compare
duncanista
reviewed
Feb 14, 2024
|
|
||
| from datadog_lambda.logger import initialize_logging | ||
|
|
||
| _test_initialize_logging = ( |
There was a problem hiding this comment.
in python, it's spelled parametrizing, whoever wrote it forgot the second e 😆
There was a problem hiding this comment.
I wonder which one is the english version and which is the american one lol
There was a problem hiding this comment.
According to wikipedia I guess both spells are correct? And that they're all british? https://en.wiktionary.org/wiki/parametrize
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Prevents function crash when setting
DD_LOG_LEVELto an unknown value. Also increases the number of available default log levels.Motivation
#417
Testing Guidelines
Additional Notes
Types of Changes
Check all that apply