Add comment to update NODE_VERSION in serverless-tools. #691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
purple4reina
force-pushed
the
rey.abolofia/comment-reminder
branch
from
831b43e to
ecc54b1
Compare
duncanista
reviewed
Nov 20, 2025
.gitlab/input_files/build.yaml.tpl
Outdated
| - cp .layers/datadog_lambda_node*.zip datadog_lambda_js-{{ if eq $environment.name "prod"}}signed-{{ end }}bundle-${CI_JOB_ID} | ||
| {{ end }} | ||
|
|
||
| serverless-tools-benchmarks: |
Contributor
There was a problem hiding this comment.
Suggested change
| serverless-tools-benchmarks: | |
| benchmarks: |
maybe?
Contributor
Author
There was a problem hiding this comment.
I can go with that.
Contributor
Author
There was a problem hiding this comment.
@duncanista FYI, I decided scrap adding the serverless-tools tests here. I was hoping it would be an easy add, but it seems it would require a bit more changes in serverless-tools than I was hoping. We can come back to it later if needed.
duncanista
reviewed
Nov 20, 2025
.gitlab/input_files/build.yaml.tpl
Outdated
| - git clone https://gitlab-ci-token:${CI_JOB_TOKEN}@gitlab.ddbuild.io/DataDog/serverless-tools.git ./serverless-tools && cd ./serverless-tools | ||
| - ./ci/check_trigger_status.sh | ||
|
|
||
| serverless-tools-benchmarks-trigger: |
Contributor
There was a problem hiding this comment.
Suggested change
| serverless-tools-benchmarks-trigger: | |
| benchmarks-trigger: |
duncanista
approved these changes
Nov 20, 2025
purple4reina
force-pushed
the
rey.abolofia/comment-reminder
branch
from
fd3fbf7 to
3667581
Compare
purple4reina
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the tests from serverless-tools to the test stage of the pipeline for this project.
Motivation
This PR #689 made a change to our build script but we forgot to make the corresponding change in serverless-tools. That led to all PRs failing on dd-trace-js.
By adding the serverless-tools tests to this repo's pipeline, we will be ensured that does not happen again.
Testing Guidelines
Additional Notes
Types of Changes
Check all that apply