Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SVLS-4999] Add Lambda tags to metrics sent via the API #559

Merged
merged 12 commits into from
Jul 16, 2024

Conversation

DylanLovesCoffee
Copy link
Contributor

@DylanLovesCoffee DylanLovesCoffee commented Jun 28, 2024

What does this PR do?

When the Extension is present, the Lambda library will use the DD API to send distribution metrics with timestamps instead of the Extension, since the Extension does not support historical distribution metrics. Metrics sent via the API currently do not get tagged with Lambda tags.

This adds some essential tags like those added via DD_TAGS and the function_arn. With the function_arn tag available, custom metrics will be enriched with other tags collected by the metadata crawler if the AWS integration is enabled:
Screenshot 2024-06-28 at 10 42 53 AM

Also added a warning log for historical distribution metrics that are sent to the API with an unsupported timestamp (>=4hrs).
Screenshot 2024-06-28 at 10 24 08 AM

Motivation

DataDog/datadog-lambda-python#398 and #545

Testing Guidelines

Built the layer and tested manually.

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@DylanLovesCoffee DylanLovesCoffee requested a review from a team as a code owner June 28, 2024 15:57
src/metrics/listener.ts Outdated Show resolved Hide resolved
src/metrics/listener.ts Outdated Show resolved Hide resolved
@duncanista duncanista merged commit 211d047 into main Jul 16, 2024
25 checks passed
@duncanista duncanista deleted the dylan/tag-historical-metrics branch July 16, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants