Skip to content

Conversation

@astuyve
Copy link
Contributor

@astuyve astuyve commented Jul 24, 2023

What does this PR do?

fixes #404
Fixes an issue where aws-sdk can not be instrumented when directly importing an indvidual client or clients.

Motivation

Testing Guidelines

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@astuyve astuyve requested a review from a team as a code owner July 24, 2023 20:31
@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2023

Codecov Report

Merging #410 (53fc271) into main (4b3d979) will not change coverage.
The diff coverage is n/a.

❗ Current head 53fc271 differs from pull request most recent head 92a6518. Consider uploading reports for the commit 92a6518 to get more accurate results

@@           Coverage Diff           @@
##             main     #410   +/-   ##
=======================================
  Coverage   80.91%   80.91%           
=======================================
  Files          38       38           
  Lines        1986     1986           
  Branches      460      460           
=======================================
  Hits         1607     1607           
  Misses        320      320           
  Partials       59       59           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@astuyve astuyve merged commit df166d9 into main Jul 24, 2023
@astuyve astuyve deleted the aj/bump-dd-trace-fix-callback branch July 24, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read properties of undefined (reading 'then')

4 participants