Skip to content

Fix race condition in statsd external_env initialization #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StephenWakely merged 1 commit into from
Jan 30, 2026
Merged

Fix race condition in statsd external_env initialization #352

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion statsd/external_env.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,21 +2,25 @@ package statsd

import (
"os"
"sync"
"unicode"
)

// ddExternalEnvVarName specifies the env var to inject the environment name.
const ddExternalEnvVarName = "DD_EXTERNAL_ENV"

var (
externalEnv = ""
externalEnv = ""
externalEnvMu sync.RWMutex // Protects concurrent access to externalEnv
)

// initExternalEnv initializes the external environment name.
func initExternalEnv() {
var value = os.Getenv(ddExternalEnvVarName)
if value != "" {
externalEnvMu.Lock()
externalEnv = sanitizeExternalEnv(value)
externalEnvMu.Unlock()
}
}

Expand All @@ -36,5 +40,7 @@ func sanitizeExternalEnv(externalEnv string) string {
}

func getExternalEnv() string {
externalEnvMu.RLock()
defer externalEnvMu.RUnlock()
return externalEnv
}
Loading