Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add return type for functions #279

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Conversation

lym953
Copy link
Contributor

@lym953 lym953 commented Aug 15, 2024

What does this PR do?

Add explicit return type for functions.

Motivation

Most functions in the codebase don't have an explicit return type. Adding it would make code more readable, improving developer experience.

Testing Guidelines

npm test

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog

@lym953 lym953 requested a review from a team as a code owner August 15, 2024 19:32
@lym953
Copy link
Contributor Author

lym953 commented Aug 15, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Aug 15, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 4m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit 3d9e190 into main Aug 15, 2024
13 checks passed
@dd-mergequeue dd-mergequeue bot deleted the yiming.luo/add-return-type branch August 15, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants