Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove Go package from current repo #276

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

lym953
Copy link
Contributor

@lym953 lym953 commented Aug 9, 2024

What does this PR do?

Delete the generated Go package from the current repo.

Motivation

The package is supposed to be in datadog-cdk-constructs-go repo.

I'm not sure how the package was added here in 27d2ac7. Maybe I ran the publish command npx -p publib@latest publib-golang with the wrong (stale) configuration, i.e. when the moduleName in .projenrc.js was still pointing at the current repo (datadog-cdk-constructs) instead of the new repo (datadog-cdk-constructs-go). Below's the correct config:

  publishToGo: {
    moduleName: "github.com/DataDog/datadog-cdk-constructs-go",
    packageName: "ddcdkconstruct",
  },

https://github.com/DataDog/datadog-cdk-constructs/blob/main/.projenrc.js#L23-L26

Testing Guidelines

N/A. This PR should be safe because it just deletes unused code.

After this PR is merged, I'll try to publish the Go package again. Hopefully that will only update datadog-cdk-constructs-go repo instead of the current datadog-cdk-constructs repo.

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog

@lym953 lym953 requested review from a team as code owners August 9, 2024 02:25
@lym953
Copy link
Contributor Author

lym953 commented Aug 9, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Aug 9, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 4m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit 8d0f92f into main Aug 9, 2024
19 checks passed
@dd-mergequeue dd-mergequeue bot deleted the yiming.luo/support-golang branch August 9, 2024 21:16
@lym953 lym953 linked an issue Aug 20, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Go support
3 participants