Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SLES-1529] Java doesn't have an arm layer, also clean up some code #246

Merged
merged 1 commit into from
Jan 30, 2024
Merged

[SLES-1529] Java doesn't have an arm layer, also clean up some code #246

merged 1 commit into from
Jan 30, 2024

Conversation

astuyve
Copy link
Contributor

@astuyve astuyve commented Jan 30, 2024

What does this PR do?

Motivation

  1. Fixes an issue where java doesn't have an ARM layer
  2. Cleans up our isNode/isArm logic.
  3. Cleans up our error handling logic

Testing Guidelines

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog

@astuyve astuyve requested a review from a team as a code owner January 30, 2024 01:38
duncanista
duncanista approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@duncanista duncanista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@astuyve astuyve merged commit 73a9b7b into main Jan 30, 2024
12 checks passed
@astuyve astuyve deleted the aj/no-arm-for-java branch January 30, 2024 20:24
alexgallotta
alexgallotta reviewed Jan 31, 2024
View reviewed changes
v2/src/layer.ts
log.error(errorMessage);
errors.push(errorMessage);
return;
return handleLayerError(errors, lam.node.id, "Node.js", "node");
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a method for error handling is a great idea, unfortunately this looks like the function is returning something, which never does.
It would be great to think about enforcing some typescript rule to avoid these cases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgallotta alexgallotta alexgallotta left review comments

@duncanista duncanista duncanista approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@astuyve @alexgallotta @duncanista