Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove integration_tests from packaging #233

Merged
merged 1 commit into from
Dec 4, 2023
Merged

chore: remove integration_tests from packaging #233

merged 1 commit into from
Dec 4, 2023

Conversation

duncanista
Copy link
Contributor

What does this PR do?

We were packaging integration_tests.

Motivation

This is bad because it cause some dependencies to be peer dependencies.
Relevant to #227

Testing Guidelines

Checked that the package was not present in the tgz for Node and Python builds.

Additional Notes

n/a

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog

@duncanista duncanista requested a review from a team as a code owner December 1, 2023 19:34
joeyzhao2018
joeyzhao2018 approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@joeyzhao2018 joeyzhao2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@duncanista duncanista merged commit 555d951 into main Dec 4, 2023
12 checks passed
@duncanista duncanista deleted the jordan.gonzalez/remove-integration-tests-from-packaging branch December 4, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeyzhao2018 joeyzhao2018 joeyzhao2018 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@duncanista @joeyzhao2018