Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Example Python CDK Stack and Consolidate TypeScript CDK Stacks #223

Merged
merged 9 commits into from
Nov 2, 2023

Conversation

duncanpharvey
Copy link
Contributor

@duncanpharvey duncanpharvey commented Nov 1, 2023

What does this PR do?

  • Adds example Python CDK stack with Node, Python, and Go Lambda functions
  • Consolidates TypeScript CDK stacks to a single stack with the same Node, Python, and Go Lambda functions

Motivation

https://datadoghq.atlassian.net/browse/SVLS-3956

Testing Guidelines

Detailed in README.md of the example stacks.

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog

@duncanpharvey duncanpharvey requested review from a team as code owners November 1, 2023 17:57
Copy link
Contributor

@duncanista duncanista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add the documentation back, I think it's very important. I imagine they need to be updated. Let's just make sure users can see those docs if they want to use it either in Python or Typescript.

examples/ts-stack-al2-arm-go-handler/README.md Outdated Show resolved Hide resolved
examples/ts-stack-js-python-handlers/README.md Outdated Show resolved Hide resolved
@duncanpharvey duncanpharvey marked this pull request as draft November 1, 2023 18:30
@duncanpharvey duncanpharvey marked this pull request as ready for review November 1, 2023 22:03
Copy link
Contributor

@hestonhoffman hestonhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor edits, but LGTM

examples/python-stack/README.md Show resolved Hide resolved
examples/python-stack/README.md Outdated Show resolved Hide resolved
examples/python-stack/README.md Outdated Show resolved Hide resolved
examples/typescript-stack/README.md Show resolved Hide resolved
examples/typescript-stack/README.md Outdated Show resolved Hide resolved
examples/typescript-stack/README.md Outdated Show resolved Hide resolved
@duncanpharvey
Copy link
Contributor Author

Left some minor edits, but LGTM

Thanks @hestonhoffman! I committed your suggested changes

Copy link
Contributor

@duncanista duncanista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - left some non-blocking suggestions.

@duncanpharvey duncanpharvey merged commit 4dc5bcd into main Nov 2, 2023
12 checks passed
@duncanpharvey duncanpharvey deleted the duncan-harvey/cdk-examples branch November 2, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants