-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Example Python CDK Stack and Consolidate TypeScript CDK Stacks #223
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add the documentation back, I think it's very important. I imagine they need to be updated. Let's just make sure users can see those docs if they want to use it either in Python or Typescript.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some minor edits, but LGTM
Co-authored-by: Heston Hoffman <[email protected]>
Thanks @hestonhoffman! I committed your suggested changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - left some non-blocking suggestions.
What does this PR do?
Motivation
https://datadoghq.atlassian.net/browse/SVLS-3956
Testing Guidelines
Detailed in
README.md
of the example stacks.Additional Notes
Types of Changes
Check all that apply