Skip to content

[pkg/otlp/model] Fix default for sendCountSum #9273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mx-psi merged 4 commits into from
Sep 28, 2021
Merged

[pkg/otlp/model] Fix default for sendCountSum #9273

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
61b8ab7
[pkg/otlp/model] Fix default for sendCountSum
mx-psi Sep 28, 2021
84bbd94
Address review comment
mx-psi Sep 28, 2021
95945e8
Add check for illegal configuration
mx-psi Sep 28, 2021
463ef63
Fix format
mx-psi Sep 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/otlp/model/translator/metrics_translator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ type Translator struct {
func New(logger *zap.Logger, options ...Option) (*Translator, error) {
cfg := translatorConfig{
HistMode: HistogramModeNoBuckets,
SendCountSum: true,
SendCountSum: false,
Comment thread
mx-psi marked this conversation as resolved.
Quantiles: false,
SendMonotonic: true,
ResourceAttributesAsTags: false,
Expand Down