Skip to content

[pkg/otlp] Fixes on translator and NewPipeline #9266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mx-psi merged 1 commit into from
Sep 27, 2021
Merged

[pkg/otlp] Fixes on translator and NewPipeline #9266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkg/otlp/collector.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,10 @@ func NewPipeline(cfg PipelineConfig) (*Pipeline, error) {
if err != nil {
return nil, err
}

// HACK: ensure flags are not-nil
// TODO: fix this upstream.
_ = service.NewCommand(col)
return &Pipeline{col}, nil
}

Expand Down
2 changes: 1 addition & 1 deletion pkg/otlp/model/translator/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ func WithHistogramMode(mode HistogramMode) Option {
return func(t *translatorConfig) error {

switch mode {
case HistogramModeNoBuckets, HistogramModeCounters:
case HistogramModeNoBuckets, HistogramModeCounters, HistogramModeDistributions:
t.HistMode = mode
default:
return fmt.Errorf("unknown histogram mode: %q", mode)
Expand Down