Add otelcollector.installation_method and set for DDOT bare-metal#47919
Conversation
BaptisteFoy
left a comment
BaptisteFoy
left a comment
There was a problem hiding this comment.
LGTM for Fleet.
Just a note: for the Agent we have an file (I believe install_info?) that already has the install method. Maybe we should do something similar?
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2b3ddd0c5e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
songy23
left a comment
songy23
left a comment
There was a problem hiding this comment.
This needs to wait for 0.148.0 upgrade?
Yeah I'm keeping it as a draft until then |
Files inventory check summaryFile checks results against ancestor d90f1b55: Results for datadog-agent_7.78.0~devel.git.734.44b4de6.pipeline.103525083-1_amd64.deb:No change detected |
Static quality checks✅ Please find below the results from static quality gates Successful checksInfo
29 successful checks with minimal change (< 2 KiB)
On-wire sizes (compressed)
|
We discussed this more offline and decided that we should keep |
liustanley
added
changelog/no-changelog
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: b2695c6 Optimization Goals: ❌ Regression(s) detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | +2.13 | [-0.95, +5.21] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ❌ | quality_gate_logs | % cpu utilization | +8.41 | [+6.66, +10.15] | 1 | Logs bounds checks dashboard |
| ➖ | docker_containers_cpu | % cpu utilization | +2.13 | [-0.95, +5.21] | 1 | Logs |
| ➖ | quality_gate_metrics_logs | memory utilization | +0.71 | [+0.47, +0.95] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_logs | memory utilization | +0.42 | [+0.35, +0.48] | 1 | Logs |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | +0.38 | [+0.32, +0.44] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | +0.32 | [+0.18, +0.46] | 1 | Logs |
| ➖ | ddot_metrics | memory utilization | +0.18 | [-0.00, +0.37] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +0.16 | [+0.04, +0.29] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | +0.05 | [-0.47, +0.56] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | -0.00 | [-0.40, +0.39] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.12, +0.11] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_v3 | ingress throughput | -0.01 | [-0.21, +0.19] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | -0.01 | [-0.05, +0.03] | 1 | Logs bounds checks dashboard |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | -0.02 | [-0.11, +0.08] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.02 | [-0.22, +0.18] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.06 | [-0.49, +0.37] | 1 | Logs |
| ➖ | docker_containers_memory | memory utilization | -0.08 | [-0.16, -0.01] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | -0.10 | [-0.15, -0.05] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_metrics_sum_delta | memory utilization | -0.10 | [-0.27, +0.07] | 1 | Logs |
| ➖ | file_tree | memory utilization | -0.20 | [-0.25, -0.15] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | -0.33 | [-0.55, -0.10] | 1 | Logs |
| ➖ | otlp_ingest_metrics | memory utilization | -0.42 | [-0.57, -0.26] | 1 | Logs |
| ➖ | otlp_ingest_logs | memory utilization | -0.67 | [-0.77, -0.56] | 1 | Logs |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | observed_value | links |
|---|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | 711 ≥ 26 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | 274.66MiB ≤ 370MiB | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | 611 ≥ 26 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | 0.19GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_0ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | 0.23GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_1000ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | 0.20GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_100ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | 0.21GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_500ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | 3 = 3 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | 172.95MiB ≤ 175MiB | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | 2 ≤ 3 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | 489.53MiB ≤ 550MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | 3 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | 209.52MiB ≤ 220MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | 355.63 ≤ 2000 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | 3 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | 419.32MiB ≤ 475MiB | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
liustanley
force-pushed
the
stanley.liu/OTAGENT-916
branch
from
cf77522 to
dd2b791
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 86de4bafaf
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| func setDDOTServiceEnvVars() error { | ||
| key, _, err := registry.CreateKey( | ||
| registry.LOCAL_MACHINE, | ||
| `SYSTEM\CurrentControlSet\Services\`+otelServiceName+`\Environment`, |
There was a problem hiding this comment.
Our Windows service helper writes a service's environment as an Environment multi-string value directly on HKLM\SYSTEM\CurrentControlSet\Services\<name> (test/new-e2e/tests/windows/common/service.go:257-267), but this code creates a ...\Services\datadog-otel-agent\Environment subkey and writes that subkey's default value instead. In Windows installs that rely on this hook, the DDOT service will still start without DD_OTELCOLLECTOR_INSTALLATION_METHOD, so the new installation_method remains empty even though installation succeeds.
Useful? React with 👍 / 👎.
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
5 participants
What does this PR do?
Add
otelcollector.installation_methodconfig option to be set by deployment tooling. This config option is used to setextensions.datadog.installation_methodin DDOT (open-telemetry/opentelemetry-collector-contrib#46881).For DDOT bare-metal,
installation_methodis set through the environment variable in the system definition files for Linux, and in the post install script for Windows.Motivation
Track usage for DDOT across different installation methods.
Describe how you validated your changes
Unit tests and ran locally
Additional Notes
Adds replace for
github.com/open-telemetry/opentelemetry-collector-contrib/extension/datadogextensionto use the cherry picked commits from open-telemetry/opentelemetry-collector-contrib#46896 and open-telemetry/opentelemetry-collector-contrib#46881 due to a delay in the collector release. These will be removed once #47989 is merged.