Skip to content

Pin gopsutil go v4.25.11 to fix disk bug (7.76.x backport)#46596

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into7.76.xfrom
pgimalac/pin-gopsutil-disk-bug
Feb 18, 2026
Merged

Pin gopsutil go v4.25.11 to fix disk bug (7.76.x backport)#46596
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into7.76.xfrom
pgimalac/pin-gopsutil-disk-bug

Conversation

@pgimalac
Copy link
Copy Markdown
Member

What does this PR do?

#incident-49623
Gopsutil 4.25.12 includes a bug which has a big impact on tags emitted by the disk check.
Pinning 4.25.11 to fix it in the release.

Root cause PR shirou/gopsutil#1931

Motivation

Avoid the bug mentioned above.

Describe how you validated your changes

Will deploy a custom build internally to validate.

Additional Notes

A fix was already merged in gopsutil but it's safer for us to revert and investigate separately.

@pgimalac pgimalac added changelog/no-changelog No changelog entry needed qa/done QA done before merge and regressions are covered by tests team/agent-runtimes labels Feb 18, 2026
@github-actions github-actions Bot added the short review PR is simple enough to be reviewed quickly label Feb 18, 2026
@agent-platform-auto-pr
Copy link
Copy Markdown
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor ab0909e
📊 Static Quality Gates Dashboard

Successful checks

Info

Quality gate Change Size (prev → curr → max)
agent_deb_amd64_fips -11.86 KiB (0.00% reduction) 712.160 → 712.149 → 715.320
agent_rpm_amd64_fips -11.86 KiB (0.00% reduction) 712.144 → 712.132 → 715.310
agent_suse_amd64_fips -11.86 KiB (0.00% reduction) 712.144 → 712.132 → 715.310
docker_agent_amd64 -12.88 KiB (0.00% reduction) 814.292 → 814.280 → 817.140
docker_agent_arm64 -5.81 KiB (0.00% reduction) 817.624 → 817.618 → 824.020
docker_agent_jmx_amd64 -12.88 KiB (0.00% reduction) 1005.204 → 1005.191 → 1008.020
docker_agent_jmx_arm64 -5.8 KiB (0.00% reduction) 997.317 → 997.312 → 1003.620
docker_cluster_agent_amd64 -14.35 KiB (0.01% reduction) 181.202 → 181.188 → 181.200
docker_cluster_agent_arm64 -14.37 KiB (0.01% reduction) 197.004 → 196.990 → 198.490
dogstatsd_deb_arm64 -3.97 KiB (0.01% reduction) 28.223 → 28.219 → 29.110
iot_agent_deb_amd64 -4.0 KiB (0.01% reduction) 43.045 → 43.041 → 43.290
iot_agent_deb_arm64 -4.0 KiB (0.01% reduction) 40.147 → 40.143 → 40.920
iot_agent_rpm_amd64 -4.0 KiB (0.01% reduction) 43.046 → 43.042 → 43.290
iot_agent_suse_amd64 -4.0 KiB (0.01% reduction) 43.046 → 43.042 → 43.290
17 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
agent_deb_amd64 752.159 MiB
agent_heroku_amd64 325.613 MiB
agent_msi 662.478 MiB
agent_rpm_amd64 752.142 MiB
agent_rpm_arm64 730.902 MiB
agent_rpm_arm64_fips 693.349 MiB
agent_suse_amd64 752.142 MiB
agent_suse_arm64 730.902 MiB
agent_suse_arm64_fips 693.349 MiB
docker_cws_instrumentation_amd64 7.135 MiB
docker_cws_instrumentation_arm64 6.689 MiB
docker_dogstatsd_amd64 38.859 MiB
docker_dogstatsd_arm64 37.191 MiB
dogstatsd_deb_amd64 30.074 MiB
dogstatsd_rpm_amd64 30.074 MiB
dogstatsd_suse_amd64 30.074 MiB
iot_agent_deb_armhf 40.713 MiB
On-wire sizes (compressed)
Quality gate Change Size (prev → curr → max)
agent_deb_amd64 -57.19 KiB (0.03% reduction) 183.769 → 183.714 → 184.810
agent_deb_amd64_fips -11.35 KiB (0.01% reduction) 176.170 → 176.158 → 177.560
agent_heroku_amd64 -2.46 KiB (0.00% reduction) 87.100 → 87.097 → 88.450
agent_msi +28.0 KiB (0.02% increase) 143.148 → 143.176 → 143.300
agent_rpm_amd64 +44.07 KiB (0.02% increase) 186.807 → 186.850 → 188.160
agent_rpm_amd64_fips neutral 177.776 MiB → 178.900
agent_rpm_arm64 +22.54 KiB (0.01% increase) 168.335 → 168.357 → 169.930
agent_rpm_arm64_fips -80.79 KiB (0.05% reduction) 161.546 → 161.467 → 163.120
agent_suse_amd64 +44.07 KiB (0.02% increase) 186.807 → 186.850 → 188.160
agent_suse_amd64_fips neutral 177.776 MiB → 178.900
agent_suse_arm64 +22.54 KiB (0.01% increase) 168.335 → 168.357 → 169.930
agent_suse_arm64_fips -80.79 KiB (0.05% reduction) 161.546 → 161.467 → 163.120
docker_agent_amd64 +9.6 KiB (0.00% increase) 276.377 → 276.386 → 277.400
docker_agent_arm64 +5.59 KiB (0.00% increase) 263.844 → 263.850 → 266.040
docker_agent_jmx_amd64 +18.74 KiB (0.01% increase) 345.024 → 345.042 → 346.020
docker_agent_jmx_arm64 -7.72 KiB (0.00% reduction) 328.483 → 328.475 → 330.660
docker_cluster_agent_amd64 -4.05 KiB (0.01% reduction) 64.010 → 64.006 → 64.510
docker_cluster_agent_arm64 +8.68 KiB (0.01% increase) 60.275 → 60.283 → 61.170
docker_cws_instrumentation_amd64 neutral 2.995 MiB → 3.330
docker_cws_instrumentation_arm64 neutral 2.726 MiB → 3.090
docker_dogstatsd_amd64 neutral 15.037 MiB → 15.820
docker_dogstatsd_arm64 neutral 14.364 MiB → 14.830
dogstatsd_deb_amd64 neutral 7.949 MiB → 8.790
dogstatsd_deb_arm64 neutral 6.829 MiB → 7.710
dogstatsd_rpm_amd64 neutral 7.960 MiB → 8.800
dogstatsd_suse_amd64 neutral 7.960 MiB → 8.800
iot_agent_deb_amd64 -6.31 KiB (0.05% reduction) 11.297 → 11.291 → 12.040
iot_agent_deb_arm64 -2.1 KiB (0.02% reduction) 9.653 → 9.651 → 10.450
iot_agent_deb_armhf -2.66 KiB (0.03% reduction) 9.850 → 9.847 → 10.620
iot_agent_rpm_amd64 -5.35 KiB (0.05% reduction) 11.313 → 11.308 → 12.060
iot_agent_suse_amd64 -5.35 KiB (0.05% reduction) 11.313 → 11.308 → 12.060

@cit-pr-commenter-54b7da
Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 0ea8c7db-68cb-48d9-90c1-ed545aa2a774

Baseline: ab0909e
Comparison: a6d8359
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization -1.78 [-4.80, +1.24] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
ddot_logs memory utilization +1.42 [+1.35, +1.50] 1 Logs
file_tree memory utilization +0.97 [+0.92, +1.03] 1 Logs
quality_gate_logs % cpu utilization +0.97 [-0.55, +2.48] 1 Logs bounds checks dashboard
ddot_metrics memory utilization +0.41 [+0.19, +0.63] 1 Logs
quality_gate_metrics_logs memory utilization +0.40 [+0.18, +0.62] 1 Logs bounds checks dashboard
otlp_ingest_logs memory utilization +0.33 [+0.24, +0.43] 1 Logs
ddot_metrics_sum_cumulative memory utilization +0.23 [+0.07, +0.39] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.16 [-0.22, +0.55] 1 Logs
quality_gate_idle_all_features memory utilization +0.08 [+0.04, +0.12] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency egress throughput +0.02 [-0.41, +0.45] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.11, +0.13] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.10, +0.10] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput -0.01 [-0.14, +0.12] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.02 [-0.06, +0.03] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.06 [-0.56, +0.44] 1 Logs
ddot_metrics_sum_delta memory utilization -0.27 [-0.47, -0.06] 1 Logs
docker_containers_memory memory utilization -0.29 [-0.38, -0.20] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization -0.33 [-0.57, -0.10] 1 Logs
quality_gate_idle memory utilization -0.38 [-0.43, -0.34] 1 Logs bounds checks dashboard
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.45 [-0.51, -0.39] 1 Logs
otlp_ingest_metrics memory utilization -0.76 [-0.90, -0.62] 1 Logs
docker_containers_cpu % cpu utilization -1.78 [-4.80, +1.24] 1 Logs
tcp_syslog_to_blackhole ingress throughput -1.78 [-1.85, -1.72] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency lost_bytes 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@avonengel
Copy link
Copy Markdown
Contributor

/merge

@gh-worker-devflow-routing-ef8351
Copy link
Copy Markdown

gh-worker-devflow-routing-ef8351 Bot commented Feb 18, 2026

View all feedbacks in Devflow UI.

2026-02-18 09:48:35 UTC ℹ️ Start processing command /merge


2026-02-18 09:48:41 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in 7.76.x is approximately 48m (p90).


2026-02-18 11:05:07 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot merged commit a529ed6 into 7.76.x Feb 18, 2026
631 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot deleted the pgimalac/pin-gopsutil-disk-bug branch February 18, 2026 11:05
@github-actions github-actions Bot added this to the 7.76.0 milestone Feb 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog No changelog entry needed qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly team/agent-runtimes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants