Skip to content

Fix OTLP testutil to avoid crashing when receiving sketches#40628

Merged
dd-mergequeue[bot] merged 2 commits into
mainfrom
jade-guiton-dd/fix-otlp-testutil
Sep 8, 2025
Merged

Fix OTLP testutil to avoid crashing when receiving sketches#40628
dd-mergequeue[bot] merged 2 commits into
mainfrom
jade-guiton-dd/fix-otlp-testutil

Conversation

@jade-guiton-dd
Copy link
Copy Markdown
Contributor

@jade-guiton-dd jade-guiton-dd commented Sep 5, 2025

What does this PR do?

This PR fixes the mock "logs" backend defined in comp/otelcol/otlp/testutil so that it can receive requests to unknown endpoints without crashing. At the moment, all unknown requests are treated like requests to /, which results in attempting to parse them as gzip-compressed JSON, crashing the test if that isn't the correct format. By setting the path to /{$} instead, we limit this processing to the / path.

Motivation

One of our integration tests for the Datadog exporter started failing because it's exporting the OTel Collector's internal telemetry, which since a recent PR now includes a histogram metric, meaning the exporter makes a call to the sketch endpoint, which the mock backend doesn't have a handler for, and which uses a very different format.

@jade-guiton-dd jade-guiton-dd added the qa/no-code-change No code change in Agent code requiring validation label Sep 5, 2025
@github-actions github-actions Bot added the short review PR is simple enough to be reviewed quickly label Sep 5, 2025
@jade-guiton-dd jade-guiton-dd added the changelog/no-changelog No changelog entry needed label Sep 5, 2025
@jade-guiton-dd jade-guiton-dd marked this pull request as ready for review September 5, 2025 12:44
@jade-guiton-dd jade-guiton-dd requested a review from a team as a code owner September 5, 2025 12:44
@cit-pr-commenter
Copy link
Copy Markdown

cit-pr-commenter Bot commented Sep 5, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 7ee7fd9a-511e-4c5b-8a81-d03c75693cf5

Baseline: ff4c8bb
Comparison: 17c34e7
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +1.54 [-1.64, +4.73] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +1.54 [-1.64, +4.73] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.55 [+0.50, +0.61] 1 Logs
ddot_logs memory utilization +0.46 [+0.35, +0.57] 1 Logs
quality_gate_metrics_logs memory utilization +0.29 [-0.03, +0.60] 1 Logs bounds checks dashboard
file_to_blackhole_100ms_latency egress throughput +0.02 [-0.54, +0.58] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.01 [-0.02, +0.04] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.06, +0.06] 1 Logs
ddot_metrics memory utilization -0.02 [-0.21, +0.17] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.02 [-0.54, +0.50] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.05 [-0.10, +0.01] 1 Logs
file_tree memory utilization -0.05 [-0.08, -0.01] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.06 [-0.67, +0.54] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.06 [-0.70, +0.57] 1 Logs
otlp_ingest_metrics memory utilization -0.09 [-0.27, +0.09] 1 Logs
quality_gate_idle memory utilization -0.10 [-0.14, -0.06] 1 Logs bounds checks dashboard
otlp_ingest_logs memory utilization -0.25 [-0.40, -0.10] 1 Logs
quality_gate_idle_all_features memory utilization -0.66 [-0.70, -0.62] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization -0.80 [-3.53, +1.93] 1 Logs bounds checks dashboard
docker_containers_memory memory utilization -2.78 [-2.94, -2.62] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 8/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 8/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@agent-platform-auto-pr
Copy link
Copy Markdown
Contributor

agent-platform-auto-pr Bot commented Sep 5, 2025

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor ff4c8bb

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
agent_deb_amd64 $${-0.19}$$ $${701.38}$$ < $${702.41}$$ $${-0.15}$$ $${177.1}$$ < $${178.15}$$
agent_deb_amd64_fips $${-0.19}$$ $${695.86}$$ < $${696.89}$$ $${-0.04}$$ $${176.16}$$ < $${177.15}$$
agent_heroku_amd64 $${-0.19}$$ $${339.82}$$ < $${340.9}$$ $${-0.16}$$ $${90.32}$$ < $${91.41}$$
agent_msi $${-0.19}$$ $${984.19}$$ < $${985.05}$$ $${-0.23}$$ $${150.97}$$ < $${152.13}$$
agent_rpm_amd64 $${-0.19}$$ $${701.37}$$ < $${702.4}$$ $${-0.19}$$ $${179.23}$$ < $${180.32}$$
agent_rpm_amd64_fips $${-0.19}$$ $${695.85}$$ < $${696.88}$$ $${-0.18}$$ $${177.71}$$ < $${178.79}$$
agent_rpm_arm64 $${-0.19}$$ $${688.14}$$ < $${689.18}$$ $${-0.17}$$ $${161.0}$$ < $${162.11}$$
agent_rpm_arm64_fips $${-0.19}$$ $${683.4}$$ < $${684.44}$$ $${-0.15}$$ $${159.88}$$ < $${161.0}$$
agent_suse_amd64 $${-0.19}$$ $${701.37}$$ < $${702.4}$$ $${-0.19}$$ $${179.23}$$ < $${180.32}$$
agent_suse_amd64_fips $${-0.19}$$ $${695.85}$$ < $${696.88}$$ $${-0.18}$$ $${177.71}$$ < $${178.79}$$
agent_suse_arm64 $${-0.19}$$ $${688.14}$$ < $${689.18}$$ $${-0.17}$$ $${161.0}$$ < $${162.11}$$
agent_suse_arm64_fips $${-0.19}$$ $${683.4}$$ < $${684.44}$$ $${-0.15}$$ $${159.88}$$ < $${161.0}$$
docker_agent_amd64 $${-0.19}$$ $${772.79}$$ < $${773.82}$$ $${-0.17}$$ $${265.15}$$ < $${266.25}$$
docker_agent_arm64 $${-0.19}$$ $${783.52}$$ < $${784.56}$$ $${-0.17}$$ $${251.61}$$ < $${252.72}$$
docker_agent_jmx_amd64 $${-0.19}$$ $${963.66}$$ < $${964.69}$$ $${-0.17}$$ $${333.77}$$ < $${334.88}$$
docker_agent_jmx_arm64 $${-0.19}$$ $${962.99}$$ < $${964.02}$$ $${-0.18}$$ $${316.23}$$ < $${317.33}$$
docker_cluster_agent_amd64 $${-0}$$ $${212.82}$$ < $${213.74}$$ $${-0}$$ $${72.26}$$ < $${73.2}$$
docker_cluster_agent_arm64 $${0}$$ $${228.73}$$ < $${229.68}$$ $${+0}$$ $${68.52}$$ < $${69.48}$$
docker_cws_instrumentation_amd64 $${-0}$$ $${7.07}$$ < $${7.12}$$ $${-0}$$ $${2.95}$$ < $${3.29}$$
docker_cws_instrumentation_arm64 $${-0}$$ $${6.69}$$ < $${6.92}$$ $${-0}$$ $${2.71}$$ < $${3.07}$$
docker_dogstatsd_amd64 $${-0}$$ $${38.36}$$ < $${39.3}$$ $${-0}$$ $${14.82}$$ < $${15.76}$$
docker_dogstatsd_arm64 $${+0}$$ $${36.99}$$ < $${37.94}$$ $${-0}$$ $${14.26}$$ < $${14.83}$$
dogstatsd_deb_amd64 $${-0}$$ $${29.59}$$ < $${30.53}$$ $${-0}$$ $${7.8}$$ < $${8.75}$$
dogstatsd_deb_arm64 $${-0}$$ $${28.18}$$ < $${29.12}$$ $${+0}$$ $${6.76}$$ < $${7.71}$$
dogstatsd_rpm_amd64 $${-0}$$ $${29.59}$$ < $${30.53}$$ $${-0}$$ $${7.81}$$ < $${8.77}$$
dogstatsd_suse_amd64 $${-0}$$ $${29.59}$$ < $${30.53}$$ $${-0}$$ $${7.81}$$ < $${8.77}$$
iot_agent_deb_amd64 $${-0.19}$$ $${54.45}$$ < $${54.97}$$ $${-0.18}$$ $${13.59}$$ < $${14.45}$$
iot_agent_deb_arm64 $${-0.19}$$ $${51.75}$$ < $${51.9}$$ $${-0.18}$$ $${11.73}$$ < $${12.63}$$
iot_agent_deb_armhf $${-0.19}$$ $${51.31}$$ < $${51.84}$$ $${-0.17}$$ $${11.8}$$ < $${12.74}$$
iot_agent_rpm_amd64 $${-0.19}$$ $${54.45}$$ < $${54.97}$$ $${-0.18}$$ $${13.61}$$ < $${14.47}$$
iot_agent_suse_amd64 $${-0.19}$$ $${54.45}$$ < $${54.97}$$ $${-0.18}$$ $${13.61}$$ < $${14.47}$$

@jade-guiton-dd
Copy link
Copy Markdown
Contributor Author

/merge

@dd-devflow-routing-codex
Copy link
Copy Markdown

dd-devflow-routing-codex Bot commented Sep 8, 2025

View all feedbacks in Devflow UI.

2025-09-08 11:07:47 UTC ℹ️ Start processing command /merge


2025-09-08 11:07:53 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 33m (p90).


2025-09-08 11:23:26 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue Bot merged commit c0e8c81 into main Sep 8, 2025
264 checks passed
@dd-mergequeue dd-mergequeue Bot deleted the jade-guiton-dd/fix-otlp-testutil branch September 8, 2025 11:23
@github-actions github-actions Bot added this to the 7.72.0 milestone Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog No changelog entry needed qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants