Skip to content

[pkg/opentelemetry-mapping-go/otlp/metrics] Sync metrics with v0.32.0#40055

Merged
dd-mergequeue[bot] merged 1 commit into
mainfrom
mx-psi/port-infer-delta-diff
Aug 20, 2025
Merged

[pkg/opentelemetry-mapping-go/otlp/metrics] Sync metrics with v0.32.0#40055
dd-mergequeue[bot] merged 1 commit into
mainfrom
mx-psi/port-infer-delta-diff

Conversation

@mx-psi
Copy link
Copy Markdown
Member

@mx-psi mx-psi commented Aug 20, 2025

What does this PR do?

Ports DataDog/opentelemetry-mapping-go/pull/765 to this repo's copy of the mapping-go modules.

Motivation

Keep modules in sync for eventual unification.

@mx-psi mx-psi requested a review from jackgopack4 August 20, 2025 14:57
@mx-psi mx-psi requested a review from a team as a code owner August 20, 2025 14:57
@github-actions github-actions Bot added the medium review PR review might take time label Aug 20, 2025
@mx-psi mx-psi added team/opentelemetry OpenTelemetry team qa/done QA done before merge and regressions are covered by tests changelog/no-changelog No changelog entry needed labels Aug 20, 2025
@cit-pr-commenter
Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: ee8642c5-66f2-4564-9aba-3952cbbc2d9a

Baseline: 0768724
Comparison: 253d5d6
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +2.10 [-0.96, +5.15] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +2.77 [-0.01, +5.55] 1 Logs bounds checks dashboard
docker_containers_cpu % cpu utilization +2.10 [-0.96, +5.15] 1 Logs
ddot_metrics memory utilization +0.18 [+0.07, +0.29] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.09 [-0.50, +0.68] 1 Logs
quality_gate_idle_all_features memory utilization +0.04 [+0.01, +0.07] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput +0.02 [-0.05, +0.09] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.02 [-0.56, +0.59] 1 Logs
quality_gate_idle memory utilization +0.01 [-0.02, +0.05] 1 Logs bounds checks dashboard
file_to_blackhole_100ms_latency egress throughput +0.01 [-0.62, +0.64] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.01 [-0.01, +0.02] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.00 [-0.61, +0.62] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.32, +0.31] 1 Logs
otlp_ingest_logs memory utilization -0.10 [-0.22, +0.03] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.13 [-0.18, -0.09] 1 Logs
otlp_ingest_metrics memory utilization -0.16 [-0.31, -0.01] 1 Logs
file_tree memory utilization -0.23 [-0.27, -0.20] 1 Logs
ddot_logs memory utilization -0.46 [-0.55, -0.37] 1 Logs
quality_gate_metrics_logs memory utilization -1.88 [-2.28, -1.48] 1 Logs bounds checks dashboard
docker_containers_memory memory utilization -2.62 [-2.78, -2.45] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@agent-platform-auto-pr
Copy link
Copy Markdown
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 0768724

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
agent_deb_amd64 $${0}$$ $${701.33}$$ < $${704.84}$$ $${+0}$$ $${177.62}$$ < $${178.58}$$
agent_deb_amd64_fips $${0}$$ $${688.61}$$ < $${703.09}$$ $${+0.02}$$ $${174.54}$$ < $${178.12}$$
agent_heroku_amd64 $${0}$$ $${350.87}$$ < $${355.37}$$ $${-0}$$ $${94.58}$$ < $${95.72}$$
agent_msi $${0}$$ $${974.43}$$ < $${980.61}$$ $${+0.01}$$ $${147.38}$$ < $${149.31}$$
agent_rpm_amd64 $${0}$$ $${701.32}$$ < $${704.83}$$ $${+0.01}$$ $${179.84}$$ < $${180.22}$$
agent_rpm_amd64_fips $${0}$$ $${688.6}$$ < $${703.08}$$ $${-0}$$ $${175.99}$$ < $${179.85}$$
agent_rpm_arm64 $${0}$$ $${690.27}$$ < $${694.74}$$ $${-0.05}$$ $${162.09}$$ < $${163.96}$$
agent_rpm_arm64_fips $${0}$$ $${678.38}$$ < $${693.05}$$ $${+0.06}$$ $${158.77}$$ < $${163.0}$$
agent_suse_amd64 $${0}$$ $${701.32}$$ < $${704.83}$$ $${+0.01}$$ $${179.84}$$ < $${180.22}$$
agent_suse_amd64_fips $${0}$$ $${688.6}$$ < $${703.08}$$ $${-0}$$ $${175.99}$$ < $${179.85}$$
agent_suse_arm64 $${0}$$ $${690.27}$$ < $${694.74}$$ $${-0.05}$$ $${162.09}$$ < $${163.96}$$
agent_suse_arm64_fips $${0}$$ $${678.38}$$ < $${693.05}$$ $${+0.06}$$ $${158.77}$$ < $${163.0}$$
docker_agent_amd64 $${+0}$$ $${783.31}$$ < $${788.65}$$ $${+0}$$ $${270.0}$$ < $${272.01}$$
docker_agent_arm64 $${-0}$$ $${795.59}$$ < $${802.0}$$ $${-0.01}$$ $${256.74}$$ < $${259.7}$$
docker_agent_jmx_amd64 $${-0}$$ $${974.61}$$ < $${979.84}$$ $${+0}$$ $${339.02}$$ < $${340.95}$$
docker_agent_jmx_arm64 $${+0}$$ $${975.49}$$ < $${981.8}$$ $${+0}$$ $${321.77}$$ < $${324.65}$$
docker_cluster_agent_amd64 $${+0}$$ $${211.87}$$ < $${214.5}$$ $${-0}$$ $${72.03}$$ < $${73.51}$$
docker_cluster_agent_arm64 $${+0}$$ $${227.86}$$ < $${230.33}$$ $${+0}$$ $${68.33}$$ < $${69.77}$$
docker_cws_instrumentation_amd64 $${0}$$ $${7.07}$$ < $${7.12}$$ $${0}$$ $${2.95}$$ < $${3.29}$$
docker_cws_instrumentation_arm64 $${0}$$ $${6.69}$$ < $${6.92}$$ $${0}$$ $${2.7}$$ < $${3.07}$$
docker_dogstatsd_amd64 $${0}$$ $${38.58}$$ < $${39.57}$$ $${+0}$$ $${14.91}$$ < $${15.76}$$
docker_dogstatsd_arm64 $${0}$$ $${37.23}$$ < $${38.2}$$ $${+0}$$ $${14.35}$$ < $${14.83}$$
dogstatsd_deb_amd64 $${0}$$ $${29.81}$$ < $${31.4}$$ $${+0}$$ $${7.87}$$ < $${8.95}$$
dogstatsd_deb_arm64 $${0}$$ $${28.4}$$ < $${29.97}$$ $${+0}$$ $${6.83}$$ < $${7.89}$$
dogstatsd_rpm_amd64 $${0}$$ $${29.81}$$ < $${31.4}$$ $${-0}$$ $${7.87}$$ < $${8.96}$$
dogstatsd_suse_amd64 $${0}$$ $${29.81}$$ < $${31.4}$$ $${-0}$$ $${7.87}$$ < $${8.96}$$
iot_agent_deb_amd64 $${0}$$ $${54.17}$$ < $${54.55}$$ $${-0}$$ $${13.65}$$ < $${14.45}$$
iot_agent_deb_arm64 $${0}$$ $${51.5}$$ < $${51.9}$$ $${+0}$$ $${11.82}$$ < $${12.63}$$
iot_agent_deb_armhf $${0}$$ $${51.04}$$ < $${51.42}$$ $${-0}$$ $${11.88}$$ < $${12.74}$$
iot_agent_rpm_amd64 $${0}$$ $${54.17}$$ < $${54.55}$$ $${+0}$$ $${13.67}$$ < $${14.47}$$
iot_agent_suse_amd64 $${0}$$ $${54.17}$$ < $${54.55}$$ $${+0}$$ $${13.67}$$ < $${14.47}$$

Copy link
Copy Markdown
Contributor

@jackgopack4 jackgopack4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything lines up, thanks for putting this in

@mx-psi
Copy link
Copy Markdown
Member Author

mx-psi commented Aug 20, 2025

/merge

@dd-devflow-routing-codex
Copy link
Copy Markdown

dd-devflow-routing-codex Bot commented Aug 20, 2025

View all feedbacks in Devflow UI.

2025-08-20 16:59:58 UTC ℹ️ Start processing command /merge


2025-08-20 17:00:06 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 38m (p90).


2025-08-20 17:28:27 UTC ℹ️ MergeQueue: This merge request was merged

@jackgopack4
Copy link
Copy Markdown
Contributor

jackgopack4 commented Aug 20, 2025

@mx-psi looks like this is missing pkg/otlp/rum, will open a separate PR to add that codebase

Edit: NVM, that's being done in https://github.com/DataDog/datadog-agent/pull/40020/files

jackgopack4 added a commit that referenced this pull request Aug 20, 2025
@dd-mergequeue dd-mergequeue Bot merged commit b7ab3de into main Aug 20, 2025
284 of 287 checks passed
@dd-mergequeue dd-mergequeue Bot deleted the mx-psi/port-infer-delta-diff branch August 20, 2025 17:28
@github-actions github-actions Bot added this to the 7.71.0 milestone Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog No changelog entry needed medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/opentelemetry OpenTelemetry team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants