Feature parity between Python disk check and Go disk check - #33116

Merged

dd-mergequeue[bot] merged 198 commits into

mainfrom

jose/disk_feature_parity

Apr 29, 2025

Commits on Jan 20, 2025

add test when 'include_all_devices' is not present (default value=True)
jose-manuel-almaza
committed
5321bc8
add release notes
jose-manuel-almaza
committed
2cebed1
add test when 'include_all_devices' is True
jose-manuel-almaza
committed
df8d05b
add test when 'include_all_devices' is False
jose-manuel-almaza
committed
5ed612e
refactor mocks
jose-manuel-almaza
committed
48b78e0
add test when disk.Partitions returns an error
jose-manuel-almaza
committed
2a2142d
add debug logs present in python check
jose-manuel-almaza
committed
f145f53

Commits on Jan 21, 2025

Merge branch 'main' into jose/disk_feature_parity
jose-manuel-almaza
committed
447c523

Commits on Jan 22, 2025

add 'all_partitions' tests
jose-manuel-almaza
committed
8fb789f
Merge branch 'main' into jose/disk_feature_parity
jose-manuel-almaza
committed
1e6b88c
process 'device_exclude' config key
jose-manuel-almaza
committed
cc5c03c
process 'device_blacklist' config key
jose-manuel-almaza
committed
59e568c
process 'excluded_disks' config key
jose-manuel-almaza
committed
8c98e0f
process 'excluded_disk_re' config key
jose-manuel-almaza
committed
56b2fc5
move 'mountpoint' variable closer to its use
jose-manuel-almaza
committed
e2abd45

Commits on Jan 23, 2025

Commits on Jan 24, 2025

Commits on Jan 27, 2025

remove comments
jose-manuel-almaza
committed
d0fb680
add 'device_global_blacklist' and 'mount_point_global_blacklist' deprecation message
jose-manuel-almaza
committed
e655942
process 'device_global_exclude' error in config
jose-manuel-almaza
committed
096c7a5
rename tests
jose-manuel-almaza
committed
835a461
add 'file_system_whitelist' deprecation message
jose-manuel-almaza
committed
cedcb2b
add 'file_system_blacklist' deprecation message
jose-manuel-almaza
committed
a53f049
add 'device_whitelist' deprecation message
jose-manuel-almaza
committed
6e95e4c
add 'device_blacklist' deprecation message
jose-manuel-almaza
committed
280d939
add 'mount_point_whitelist' deprecation message
jose-manuel-almaza
committed
93d4b35
add 'mount_point_blacklist' deprecation message
jose-manuel-almaza
committed
ec812d4
add 'excluded_filesystems' deprecation message
jose-manuel-almaza
committed
fc326c9
add 'excluded_disks' and 'excluded_disk_re' deprecation message
jose-manuel-almaza
committed
d2cc47d
add 'excluded_mountpoint_re' deprecation message
jose-manuel-almaza
committed
a18c176
process 'min_disk_size' config key
jose-manuel-almaza
committed
c3678ee
assert log message when 'diskUsage' system call fails
jose-manuel-almaza
committed
430f09d
assert log message when partition is excluded because of size check
jose-manuel-almaza
committed
cd36d33
Merge branch 'main' into jose/disk_feature_parity
jose-manuel-almaza
committed
56e3250
process 'tag_by_filesystem' config key
jose-manuel-almaza
committed
47328a1
process 'use_mount' config key
jose-manuel-almaza
committed
789ebd9

Commits on Jan 28, 2025

process 'device_tag_re' config key
jose-manuel-almaza
committed
5b7d280
prevent using the 'use_lsblk' and 'blkid_cache_file' config keys at the same time
jose-manuel-almaza
committed
eaae963
small refactor
jose-manuel-almaza
committed
c0efc48

Commits on Jan 29, 2025

process 'tag_by_label' config key
jose-manuel-almaza
committed
22fa311
add test where 'tag_by_filesystem' configkey is false
jose-manuel-almaza
committed
f5c2cd2
small refactor
jose-manuel-almaza
committed
7358e41
process 'service_check_rw' config key
jose-manuel-almaza
committed
6f9757e
add tests for 'disk.IOCounters' use cases
jose-manuel-almaza
committed
a103522
added logs
jose-manuel-almaza
committed
e91c367

Commits on Jan 30, 2025

Commits on Jan 31, 2025

Commits on Feb 10, 2025

Commits on Feb 11, 2025

add 'blkid' command call for non-windows
jose-manuel-almaza
committed
102681f
update config file
jose-manuel-almaza
committed
3129ef8

Commits on Feb 12, 2025

process 'use_lsblk' and 'blkid_cache_file'
jose-manuel-almaza
committed
6a8653b
Merge branch 'main' into jose/disk_feature_parity
jose-manuel-almaza
committed
635c68d

Commits on Feb 14, 2025

Merge branch 'main' into jose/disk_feature_parity
jose-manuel-almaza
committed
a3ab0fd

Commits on Feb 17, 2025

remove unnecessary comments and build tags
jose-manuel-almaza
committed
efddc0d
fix revive errors
jose-manuel-almaza
committed
8054c4e
rename 'diskConfigure' to 'configureDiskCheck'
jose-manuel-almaza
committed
33469ed
remove unneeded conversion
jose-manuel-almaza
committed
5f4fcf3
remove unneeded conversion
jose-manuel-almaza
committed
e1f5484
Merge branch 'jose/disk_feature_parity' of github.com:DataDog/datadog-agent into jose/disk_feature_parity
jose-manuel-almaza
committed
b600c2e
add labelRegExpression as const value
jose-manuel-almaza
committed
63ded7e
move a type declaration and method to private
jose-manuel-almaza
committed
f8441b5
add default values
jose-manuel-almaza
committed
4c0c1be
regex as var
jose-manuel-almaza
committed
e8f30a4
fixed linter error
jose-manuel-almaza
committed
ca2e61c
fixed linter error
jose-manuel-almaza
committed
e964ab4

Commits on Feb 18, 2025

make device type private
jose-manuel-almaza
committed
9deeb1a

Commits on Mar 27, 2025

Merge branch 'main' into jose/disk_feature_parity
jose-manuel-almaza
committed
38b985e
fixed error
jose-manuel-almaza
committed
61f85fa
run unit tests in all platforms
jose-manuel-almaza
committed
8eb5fc0
moved create mounts config read to a method
jose-manuel-almaza
committed
cb1d7ca
add tests for 'file_system_global_exclude' default values
jose-manuel-almaza
committed
ba6568b
add tests for 'mount_point_global_exclude' default values
jose-manuel-almaza
committed
3ea5f79
moved tag tests to not windows build
jose-manuel-almaza
committed
314a7e9

Commits on Mar 28, 2025

moved tests to linux or windows
jose-manuel-almaza
committed
b1cef97
moved some consts to the correct file
jose-manuel-almaza
committed
bf88dc1
moved 'create_mounts' code to windows
jose-manuel-almaza
committed
8f65909
added python comments pointing to issues
jose-manuel-almaza
committed
1649760
rename unused variable
jose-manuel-almaza
committed
a3877e0
fixed error with some 'min_disk_size' use cases
jose-manuel-almaza
committed
45ee528

Commits on Apr 1, 2025

Commits on Apr 2, 2025

Commits on Apr 4, 2025

Update pkg/collector/corechecks/system/disk/diskv2/disk_nix.go

jose-manuel-almaza
and
pgimalac
authored
3324ba8
Merge branch 'main' into jose/disk_feature_parity
jose-manuel-almaza
committed
37b3c0f
fixed error
jose-manuel-almaza
committed
0de301d
skip empty labels
jose-manuel-almaza
committed
515b5fc
remove unnecessary code when creating remote path
jose-manuel-almaza
committed
c264205
fixed windows test
jose-manuel-almaza
committed
f82740f

Commits on Apr 8, 2025

Merge branch 'main' into jose/disk_feature_parity
jose-manuel-almaza
committed
66dd905
add 'use_diskv2_check' config key
jose-manuel-almaza
committed
18ef777
update release notes
jose-manuel-almaza
committed
a6bf013
Update releasenotes/notes/disk_feature_parity-f26158df4ead7b63.yaml

jose-manuel-almaza
and
pgimalac
authored
1eea9d8
Update pkg/config/setup/config.go

jose-manuel-almaza
and
pgimalac
authored
b1ad617
create remotePath func
jose-manuel-almaza
committed
1ca00b2
fixed NetAddConnection calls
jose-manuel-almaza
committed
b85dd06

Commits on Apr 9, 2025

Commits on Apr 11, 2025

add 'lowercase_device_tag' config key
jose-manuel-almaza
committed
8f1b3f0
add base_device_name func
jose-manuel-almaza
committed
d4d65b3
add 'utilized' metrics
jose-manuel-almaza
committed
ad35774
send inodes metrics only in linux
jose-manuel-almaza
committed
f1b0584
copy comment from python check
jose-manuel-almaza
committed
2db79ef
skip cd-rom drives in windows
jose-manuel-almaza
committed
41fcd5f
ignore all the bits not part of the mountpoint name
jose-manuel-almaza
committed
35c2879
fix unused-parameter error
jose-manuel-almaza
committed
df4d6ac
Update pkg/collector/corechecks/system/disk/diskv2/disk.go

jose-manuel-almaza
and
pgimalac
authored
3e359c7
copy 'device_name' related test to windows
jose-manuel-almaza
committed
b9d7f08
copy 'device_name' related test to windows
jose-manuel-almaza
committed
ef48fd5

Commits on Apr 14, 2025

fix windows test
jose-manuel-almaza
committed
5fea541
fix 'include_all_devices' to true test
jose-manuel-almaza
committed
9ab049f
fix 'include_all_devices' to false test
jose-manuel-almaza
committed
84d31c6
fix empty device test
jose-manuel-almaza
committed
27a589e
fix 'all_partitions' to false test
jose-manuel-almaza
committed
32c31b5
fix 'all_partitions' to true test
jose-manuel-almaza
committed
b8cf023
fix device include and whitelist tests
jose-manuel-almaza
committed
4523119
fix cdrom tests
jose-manuel-almaza
committed
e5422d4
migrate some tests to windows
jose-manuel-almaza
committed
20be185

Commits on Apr 15, 2025

fix tracefs tests
jose-manuel-almaza
committed
e8f7cbe
fix 'file_system_global_exclude' tests
jose-manuel-almaza
committed
c967a37
fix 'file_system_*' tests
jose-manuel-almaza
committed
2472848
small refactor
jose-manuel-almaza
committed
0fd01c4
fix 'file_system_include' and 'file_system_whitelist' tests
jose-manuel-almaza
committed
ef2bb7a
fix mock.AnythingOfType error
jose-manuel-almaza
committed
1c114ed
Merge branch 'main' into jose/disk_feature_parity
jose-manuel-almaza
committed
df5138c
fix 'mount_point_global_exclude' and 'mount_point_global_blacklist' tests
jose-manuel-almaza
committed
d31c54c
fix 'mount_point_exclude' and 'mount_point_blacklist' tests
jose-manuel-almaza
committed
17245f2
fix 'excluded_mountpoint_re' test
jose-manuel-almaza
committed
6eb9a67
fix 'tag_by_filesystem' to true test
jose-manuel-almaza
committed
2dcde71
fix 'use_mount' and 'service_check_rw' to true tests
jose-manuel-almaza
committed
3ccd034
fix TestGivenADiskCheckWithFileSystemGlobalExcludeNotConfigured_WhenCheckRuns_ThenUsageMetricsAreNotReportedForPartitionsWithTracefsFileSystems
jose-manuel-almaza
committed
8af93c8

Commits on Apr 16, 2025

Commits on Apr 17, 2025

small refactor
jose-manuel-almaza
committed
c465d67
round to 1 decimal metric values in e2e
jose-manuel-almaza
committed
a94ac80
add const metricCompareDecimals set to 1
jose-manuel-almaza
committed
a8ff7f6
custom comparer alternative
jose-manuel-almaza
committed
8593390
add timeout to disk usage call
jose-manuel-almaza
committed
a7d157a
fixed comparer
jose-manuel-almaza
committed
2fcd4d7
remove commented lines
jose-manuel-almaza
committed
5af9363
Merge branch 'main' into jose/disk_feature_parity
jose-manuel-almaza
committed
a91cc30

Commits on Apr 23, 2025

feat: add Windows e2e test for disk
pgimalac
committed
a77bee4
fix: use os argument to pick the os in e2e tests
pgimalac
committed
7728bac
Merge branch 'main' into jose/disk_feature_parity
jose-manuel-almaza
committed
f0a9721

Commits on Apr 24, 2025

Commits on Apr 28, 2025

use 'github.com/benbjohnson/clock'
jose-manuel-almaza
committed
fa784b0
regexes for filesystem include always case insensitive
jose-manuel-almaza
committed
d52e624
Update pkg/collector/corechecks/system/disk/diskv2/disk.go

jose-manuel-almaza
and
pgimalac
authored
3045a72
fix import error
jose-manuel-almaza
committed
0711e50
trim tags
jose-manuel-almaza
committed
17f67b2
add warning log for invalid regular expressions
jose-manuel-almaza
committed
8e49460
remove CI_PIPELINE_ID mention
jose-manuel-almaza
committed
40830e8

Commits on Apr 29, 2025